* [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers)
@ 2009-05-21 20:17 Mika Korhonen
2009-05-23 9:14 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Mika Korhonen @ 2009-05-21 20:17 UTC (permalink / raw)
To: David Brownell; +Cc: linux-mtd Mailing List, David Woodhouse, Adrian Hunter
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
2009/4/29 David Brownell <david-b@pacbell.net>:
> On Wednesday 29 April 2009, Adrian Hunter wrote:
>> + .shutdown = __devexit_p(omap2_onenand_shutdown),
>
> That looks wrong. Shutdown functions shouldn't get discarded
> like exit functions. I'd think the fix for that would be taking
> away any __devexit annotation on the shutdown function.
>
>
Here follows the revised patch, fixed as suggested.
Mika
[-- Attachment #2: 0001-Fix-devexit-macro-usage-in-OMAP-OneNAND.patch --]
[-- Type: text/x-patch, Size: 1333 bytes --]
From 090161dcc28f685a9b1f15c2c652925f052bdf18 Mon Sep 17 00:00:00 2001
From: Mika Korhonen <mika.j.korhonen@gmail.com>
Date: Thu, 21 May 2009 23:09:42 +0300
Subject: [PATCH] Fix devexit macro usage in OMAP OneNAND
Add missing __devexit_p wrapper and no more mark shutdown with __devesit.
Fixes build in configurations where devexit functions get discarded.
Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
drivers/mtd/onenand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..df26db8 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -566,7 +566,7 @@ int omap2_onenand_rephase(void)
NULL, __adjust_timing);
}
-static void __devexit omap2_onenand_shutdown(struct platform_device *pdev)
+static void omap2_onenand_shutdown(struct platform_device *pdev)
{
struct omap2_onenand *c = dev_get_drvdata(&pdev->dev);
@@ -778,7 +778,7 @@ static int __devexit omap2_onenand_remove(struct platform_device *pdev)
static struct platform_driver omap2_onenand_driver = {
.probe = omap2_onenand_probe,
- .remove = omap2_onenand_remove,
+ .remove = __devexit_p(omap2_onenand_remove),
.shutdown = omap2_onenand_shutdown,
.driver = {
.name = DRIVER_NAME,
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers)
2009-05-21 20:17 [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers) Mika Korhonen
@ 2009-05-23 9:14 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2009-05-23 9:14 UTC (permalink / raw)
To: Mika Korhonen
Cc: David Brownell, David Woodhouse, linux-mtd Mailing List, Adrian Hunter
On Thu, 2009-05-21 at 23:17 +0300, Mika Korhonen wrote:
> 2009/4/29 David Brownell <david-b@pacbell.net>:
> > On Wednesday 29 April 2009, Adrian Hunter wrote:
> >> + .shutdown = __devexit_p(omap2_onenand_shutdown),
> >
> > That looks wrong. Shutdown functions shouldn't get discarded
> > like exit functions. I'd think the fix for that would be taking
> > away any __devexit annotation on the shutdown function.
> >
> >
>
> Here follows the revised patch, fixed as suggested.
I've taken this patch to l2-mtd-2.6.git.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-23 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-21 20:17 [PATCH] [MTD] ONENAND: Fix devexit macro usage in OMAP OneNAND (was Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers) Mika Korhonen
2009-05-23 9:14 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.