All of lore.kernel.org
 help / color / mirror / Atom feed
* No stdout when using dash
@ 2009-05-23 11:34 Andreas Thienemann
       [not found] ` <Pine.LNX.4.58.0905231331400.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  0 siblings, 1 reply; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-23 11:34 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA


When using the 00dash module in dracut, the emergency_shell currently has 
no stderr.

Problem is related to dash closing stderr if opening /dev/tty fails.

I just triggered an update to dash in fedora F11 and rawhide fixing this 
behaviour.
This should make the emergency shell much easier to work with.

regards,
 andreas
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found] ` <Pine.LNX.4.58.0905231331400.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
@ 2009-05-23 12:29   ` Victor Lowther
       [not found]     ` <1243081747.29452.38.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
  2009-05-23 12:48   ` Victor Lowther
  2009-05-26  2:42   ` [PATCH] dracut: make initial devices outside of initramfs David Dillow
  2 siblings, 1 reply; 22+ messages in thread
From: Victor Lowther @ 2009-05-23 12:29 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Sat, 2009-05-23 at 13:34 +0200, Andreas Thienemann wrote:
> When using the 00dash module in dracut, the emergency_shell currently has 
> no stderr.
> 
> Problem is related to dash closing stderr if opening /dev/tty fails.
> 
> I just triggered an update to dash in fedora F11 and rawhide fixing this 
> behaviour.
> This should make the emergency shell much easier to work with.

Can you also post the fix upstream?  That way those of us who are not
developing on Fedora can also benefit. :)

> regards,
>  andreas
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Victor Lowther
RHCE# 805008539634727
LPIC-2# LPI000140019

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found] ` <Pine.LNX.4.58.0905231331400.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  2009-05-23 12:29   ` Victor Lowther
@ 2009-05-23 12:48   ` Victor Lowther
       [not found]     ` <1243082881.29452.45.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
  2009-05-26  2:42   ` [PATCH] dracut: make initial devices outside of initramfs David Dillow
  2 siblings, 1 reply; 22+ messages in thread
From: Victor Lowther @ 2009-05-23 12:48 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Sat, 2009-05-23 at 13:34 +0200, Andreas Thienemann wrote:
> When using the 00dash module in dracut, the emergency_shell currently has 
> no stderr.
> 
> Problem is related to dash closing stderr if opening /dev/tty fails.
> 
> I just triggered an update to dash in fedora F11 and rawhide fixing this 
> behaviour.
> This should make the emergency shell much easier to work with.

In the meantime, though...

diff --git a/modules.d/99base/init b/modules.d/99base/init
index ac6a2d8..fbebff1 100755
--- a/modules.d/99base/init
+++ b/modules.d/99base/init
@@ -35,6 +35,7 @@ NEWROOT="/sysroot"
 
 trap "emergency_shell" 0
 
+# we need /dev/null really early
 mknod /dev/null c 1 3
 
 # mount some important things
@@ -42,15 +43,17 @@ mount -t proc /proc /proc >/dev/null 2>&1
 mount -t sysfs /sys /sys >/dev/null 2>&1
 mount -t tmpfs -omode=0755 udev /dev >/dev/null 2>&1
 
-read CMDLINE </proc/cmdline;
-getarg ramfsdebug && set -x
 # Make some basic devices first, let udev handle the rest
 mknod /dev/null c 1 3
 mknod /dev/ptmx c 5 2
 mknod /dev/console c 5 1
+mknod /dev/tty c 5 0
 mkdir /dev/pts
 mount -t devpts -o gid=5,mode=620 /dev/pts /dev/pts >/dev/null 2>&1
 
+read CMDLINE </proc/cmdline;
+getarg ramfsdebug && set -x
+
 # pre-udev scripts run before udev starts, and are run only once.
 getarg 'break=pre-udev' && emergency_shell
 source_all pre-udev


> regards,
>  andreas
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Victor Lowther
RHCE# 805008539634727
LPIC-2# LPI000140019

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found]     ` <1243081747.29452.38.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
@ 2009-05-23 12:51       ` Andreas Thienemann
       [not found]         ` <Pine.LNX.4.58.0905231450240.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  0 siblings, 1 reply; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-23 12:51 UTC (permalink / raw)
  To: Victor Lowther; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On Sat, 23 May 2009, Victor Lowther wrote:

> > I just triggered an update to dash in fedora F11 and rawhide fixing this 
> > behaviour.
> > This should make the emergency shell much easier to work with.
> Can you also post the fix upstream?  That way those of us who are not
> developing on Fedora can also benefit. :)

No need. The patch has been pulled from upstream git.There just hasn't 
been a new upstream release:

commit fcc4134a7b76d82d39dea635c41ec593a41d6d19
Author: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Date:   Sun Feb 22 19:29:48 2009 +0800


regards,
 andreas
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found]     ` <1243082881.29452.45.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
@ 2009-05-23 13:06       ` Andreas Thienemann
  2009-05-23 13:26       ` Kay Sievers
  1 sibling, 0 replies; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-23 13:06 UTC (permalink / raw)
  To: Victor Lowther; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On Sat, 23 May 2009, Victor Lowther wrote:

> In the meantime, though...

That patch is unneeded for the current functionality.
/dev/tty cannot be opened, even though you're creating it.

strace gives:
open("/dev/tty", O_RDWR) = -1 ENXIO (No such device or address)

Thus reshuffling the set -x call later doesn't do any good.

Furthermore: tty is not needed for basic shell functionality at all.

regards,
 andreas
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found]     ` <1243082881.29452.45.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
  2009-05-23 13:06       ` Andreas Thienemann
@ 2009-05-23 13:26       ` Kay Sievers
       [not found]         ` <ac3eb2510905230626k5a8b3d25l5c4de0c9017b9c80-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  1 sibling, 1 reply; 22+ messages in thread
From: Kay Sievers @ 2009-05-23 13:26 UTC (permalink / raw)
  To: Victor Lowther; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On Sat, May 23, 2009 at 14:48, Victor Lowther <victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> +getarg ramfsdebug && set -x

Btw, "ramfs" is a well known kernel filesystem type, I don't think we
should use that name here.

The kernel parameter which binary to start in initramfs is "rdinit",
unlike "init" which is the binary to start in the real rootfs. Maybe
we just keep the rd-prefix for such variables?

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found]         ` <Pine.LNX.4.58.0905231450240.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
@ 2009-05-23 16:56           ` Victor Lowther
  0 siblings, 0 replies; 22+ messages in thread
From: Victor Lowther @ 2009-05-23 16:56 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On May 23, 2009, at 7:51 AM, Andreas Thienemann <andreas-XTk7JcP0uDNeoWH0uzbU5w@public.gmane.org>  
wrote:

> On Sat, 23 May 2009, Victor Lowther wrote:
>
>>> I just triggered an update to dash in fedora F11 and rawhide  
>>> fixing this
>>> behaviour.
>>> This should make the emergency shell much easier to work with.
>> Can you also post the fix upstream?  That way those of us who are not
>> developing on Fedora can also benefit. :)
>
> No need. The patch has been pulled from upstream git.There just hasn't
> been a new upstream release:

Cool, just wanted to be sure.

>
> commit fcc4134a7b76d82d39dea635c41ec593a41d6d19
> Author: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
> Date:   Sun Feb 22 19:29:48 2009 +0800
>
>
> regards,
> andreas
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs"  
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: No stdout when using dash
       [not found]         ` <ac3eb2510905230626k5a8b3d25l5c4de0c9017b9c80-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2009-05-23 16:57           ` Victor Lowther
  0 siblings, 0 replies; 22+ messages in thread
From: Victor Lowther @ 2009-05-23 16:57 UTC (permalink / raw)
  To: Kay Sievers; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On May 23, 2009, at 8:26 AM, Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org> wrote:

> On Sat, May 23, 2009 at 14:48, Victor Lowther <victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org 
> > wrote:
>
>> +getarg ramfsdebug && set -x
>
> Btw, "ramfs" is a well known kernel filesystem type, I don't think we
> should use that name here.
>
> The kernel parameter which binary to start in initramfs is "rdinit",
> unlike "init" which is the binary to start in the real rootfs. Maybe
> we just keep the rd-prefix for such variables?

Sounds reasonable.

>
> Thanks,
> Kay
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH] dracut: make initial devices outside of initramfs
       [not found] ` <Pine.LNX.4.58.0905231331400.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  2009-05-23 12:29   ` Victor Lowther
  2009-05-23 12:48   ` Victor Lowther
@ 2009-05-26  2:42   ` David Dillow
       [not found]     ` <1243305738.3584.40.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
  2 siblings, 1 reply; 22+ messages in thread
From: David Dillow @ 2009-05-26  2:42 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

dash gets upset when it cannot open /dev/tty, and we lose stderr. Even
if we make /dev/tty once we're in the initramfs, it will still be too
late for the inital dash shell running the init script. So, make a small
set of nodes in the dracut script while building the directory structure
of the initramfs.

This allowed the error from the duplicate mknod /dev/null in the
initramfs to surface, so consider it tested. :)
---
On Sat, 2009-05-23 at 13:34 +0200, Andreas Thienemann wrote:
> When using the 00dash module in dracut, the emergency_shell currently has 
> no stderr.
> 
> Problem is related to dash closing stderr if opening /dev/tty fails.

Here's an alternate fix that works with today's dash in F10.
Dave

diff --git a/dracut b/dracut
index 942c420..02e9137 100755
--- a/dracut
+++ b/dracut
@@ -116,6 +116,12 @@ for d in bin sbin usr/bin usr/sbin usr/lib etc proc sys sysroot dev/pts var/run;
     mkdir -p "$initdir/$d"; 
 done
 
+# Make some basic devices in the initramfs, udev will handle the rest.
+mknod "$initdir/dev/null" c 1 3
+mknod "$initdir/dev/tty" c 5 0
+mknod "$initdir/dev/console" c 5 1
+mknod "$initdir/dev/ptmx" c 5 2
+
 # check all our modules to see if they should be sourced
 check_modules
   
@@ -153,4 +159,4 @@ unset item
 
 [[ "$beverbose" = "yes" ]] && ls -lh "$outfile"
 
-exit 0
\ No newline at end of file
+exit 0
diff --git a/modules.d/99base/init b/modules.d/99base/init
index 5ee897e..9a72b30 100755
--- a/modules.d/99base/init
+++ b/modules.d/99base/init
@@ -28,19 +28,12 @@ trap "emergency_shell" 0
 
 . /lib/dracut-lib
 
-mknod /dev/null c 1 3
-
 # mount some important things
 mount -t proc /proc /proc >/dev/null 2>&1
 mount -t sysfs /sys /sys >/dev/null 2>&1
 mount -t tmpfs -omode=0755 udev /dev >/dev/null 2>&1
 
 getarg rdinitdebug && set -x
-# Make some basic devices first, let udev handle the rest
-mknod /dev/null c 1 3
-mknod /dev/ptmx c 5 2
-mknod /dev/console c 5 1
-mkdir /dev/pts
 mount -t devpts -o gid=5,mode=620 /dev/pts /dev/pts >/dev/null 2>&1
 
 # pre-udev scripts run before udev starts, and are run only once.




--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]     ` <1243305738.3584.40.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
@ 2009-05-26  2:44       ` Jeremy Katz
       [not found]         ` <20090526024454.GA10049-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 22+ messages in thread
From: Jeremy Katz @ 2009-05-26  2:44 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

On Monday, May 25 2009, David Dillow said:
> dash gets upset when it cannot open /dev/tty, and we lose stderr. Even
> if we make /dev/tty once we're in the initramfs, it will still be too
> late for the inital dash shell running the init script. So, make a small
> set of nodes in the dracut script while building the directory structure
> of the initramfs.

Creating the nodes in the dracut script means that you can't create the
initramfs as non-root, though.  :(

Jeremy
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]         ` <20090526024454.GA10049-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2009-05-26  2:58           ` David Dillow
       [not found]             ` <1243306682.3584.42.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
  2009-05-27 20:26           ` Warren Togami
  1 sibling, 1 reply; 22+ messages in thread
From: David Dillow @ 2009-05-26  2:58 UTC (permalink / raw)
  To: Jeremy Katz; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Mon, 2009-05-25 at 22:44 -0400, Jeremy Katz wrote:
> On Monday, May 25 2009, David Dillow said:
> > dash gets upset when it cannot open /dev/tty, and we lose stderr. Even
> > if we make /dev/tty once we're in the initramfs, it will still be too
> > late for the inital dash shell running the init script. So, make a small
> > set of nodes in the dracut script while building the directory structure
> > of the initramfs.
> 
> Creating the nodes in the dracut script means that you can't create the
> initramfs as non-root, though.  :(

Bummer, that. And while it makes the initial dash able to give us
stderr, it doesn't fix the emergency shell. Of course, I noticed this
after hitting send... so bad patch all around. :(

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]             ` <1243306682.3584.42.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
@ 2009-05-26  3:44               ` David Dillow
  2009-05-26 14:36               ` Andreas Thienemann
  1 sibling, 0 replies; 22+ messages in thread
From: David Dillow @ 2009-05-26  3:44 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

On Mon, 2009-05-25 at 22:58 -0400, David Dillow wrote:
> On Mon, 2009-05-25 at 22:44 -0400, Jeremy Katz wrote:
> > On Monday, May 25 2009, David Dillow said:
> > > dash gets upset when it cannot open /dev/tty, and we lose stderr. Even
> > > if we make /dev/tty once we're in the initramfs, it will still be too
> > > late for the inital dash shell running the init script. So, make a small
> > > set of nodes in the dracut script while building the directory structure
> > > of the initramfs.
> > 
> > Creating the nodes in the dracut script means that you can't create the
> > initramfs as non-root, though.  :(
> 
> Bummer, that. And while it makes the initial dash able to give us
> stderr, it doesn't fix the emergency shell. Of course, I noticed this
> after hitting send... so bad patch all around. :(

I'm a dope, initial dash has always had stderr.

This ugliness points /dev/tty at the actual device of /dev/console while
running the emergency shell, then puts it back when done so if we do
manage to mount things, /dev will have the right devices when
switch_root moves it.

I'm not sure if its worth it, but at least I have a prompt and stderr in
the emergency shell now, even after udev runs.

diff --git a/modules.d/99base/init b/modules.d/99base/init
index 5ee897e..4e2d73f 100755
--- a/modules.d/99base/init
+++ b/modules.d/99base/init
@@ -11,7 +11,13 @@ emergency_shell()
     echo ; echo
     echo "Bug in initramfs /init detected. Dropping to a shell. Good luck!"
     echo
+    # Point /dev/tty at the device for /dev/console as we don't have a
+    # controlling shell here and dash won't give us stderr or a prompt
+    # w/o a working /dev/tty
+    rm -f /dev/tty; mknod /dev/tty c 5 1
     sh -i
+    # Point it back to the real device
+    rm -f /dev/tty; mknod /dev/tty c 5 0
 }
 
 source_all() {


--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]             ` <1243306682.3584.42.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
  2009-05-26  3:44               ` David Dillow
@ 2009-05-26 14:36               ` Andreas Thienemann
       [not found]                 ` <Pine.LNX.4.58.0905261634470.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  1 sibling, 1 reply; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-26 14:36 UTC (permalink / raw)
  To: David Dillow; +Cc: Jeremy Katz, initramfs-u79uwXL29TY76Z2rM5mHXA

On Mon, 25 May 2009, David Dillow wrote:

> Bummer, that. And while it makes the initial dash able to give us
> stderr, it doesn't fix the emergency shell. Of course, I noticed this
> after hitting send... so bad patch all around. :(

I think the patch is unnecessary in any case.

Dash loosing stderr when /dev/tty is unavailable is a dash bug. It's been 
fixed in upstream git and the patch has been applied to rawhide and F11.

I think the problem should be considered fixed and we won't have to
introduce workarounds like pre-creating device nodes.

regards,
 andreas
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                 ` <Pine.LNX.4.58.0905261634470.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
@ 2009-05-26 14:59                   ` David Dillow
       [not found]                     ` <1243349941.19603.5.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
  0 siblings, 1 reply; 22+ messages in thread
From: David Dillow @ 2009-05-26 14:59 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 2009-05-26 at 16:36 +0200, Andreas Thienemann wrote:
> On Mon, 25 May 2009, David Dillow wrote:
> 
> > Bummer, that. And while it makes the initial dash able to give us
> > stderr, it doesn't fix the emergency shell. Of course, I noticed this
> > after hitting send... so bad patch all around. :(
> 
> I think the patch is unnecessary in any case.
> 
> Dash loosing stderr when /dev/tty is unavailable is a dash bug. It's been 
> fixed in upstream git and the patch has been applied to rawhide and F11.
> 
> I think the problem should be considered fixed and we won't have to
> introduce workarounds like pre-creating device nodes.

Some of us want to use dracut on F10, or better yet CentOS 5.3. And we
test on released distros, not an unreleased one (albeit coming very
soon).

Does my later patch, that just makes /dev/tty point to /dev/console for
the emergency shell seem unobtrusive enough to take upstream?

If I need to carry this locally, I don't mind, but I figure others could
use the fix when working on the initramfs.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                     ` <1243349941.19603.5.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
@ 2009-05-26 16:15                       ` Harald Hoyer
       [not found]                         ` <4A1C159B.1070009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  2009-05-26 16:20                       ` Andreas Thienemann
  1 sibling, 1 reply; 22+ messages in thread
From: Harald Hoyer @ 2009-05-26 16:15 UTC (permalink / raw)
  To: David Dillow; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On 05/26/2009 04:59 PM, David Dillow wrote:
> On Tue, 2009-05-26 at 16:36 +0200, Andreas Thienemann wrote:
>> On Mon, 25 May 2009, David Dillow wrote:
>>
>>> Bummer, that. And while it makes the initial dash able to give us
>>> stderr, it doesn't fix the emergency shell. Of course, I noticed this
>>> after hitting send... so bad patch all around. :(
>> I think the patch is unnecessary in any case.
>>
>> Dash loosing stderr when /dev/tty is unavailable is a dash bug. It's been
>> fixed in upstream git and the patch has been applied to rawhide and F11.
>>
>> I think the problem should be considered fixed and we won't have to
>> introduce workarounds like pre-creating device nodes.
>
> Some of us want to use dracut on F10, or better yet CentOS 5.3. And we
> test on released distros, not an unreleased one (albeit coming very
> soon).
>
> Does my later patch, that just makes /dev/tty point to /dev/console for
> the emergency shell seem unobtrusive enough to take upstream?
>
> If I need to carry this locally, I don't mind, but I figure others could
> use the fix when working on the initramfs.
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

just omit the dash module for debugging purposes :)

dracut --omit dash

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                     ` <1243349941.19603.5.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
  2009-05-26 16:15                       ` Harald Hoyer
@ 2009-05-26 16:20                       ` Andreas Thienemann
       [not found]                         ` <Pine.LNX.4.58.0905261818090.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
  1 sibling, 1 reply; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-26 16:20 UTC (permalink / raw)
  To: David Dillow; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 26 May 2009, David Dillow wrote:

> Some of us want to use dracut on F10, or better yet CentOS 5.3. And we
> test on released distros, not an unreleased one (albeit coming very
> soon).

I can push an upgrade for F10. But Centos? I'm not sure they  even have 
dash.


> Does my later patch, that just makes /dev/tty point to /dev/console for
> the emergency shell seem unobtrusive enough to take upstream?

Personally, I don't like it. It's a workaround for one single shell, which 
has this bug already fixed in it's code repo.

I think we shouldn't start putting workarounds into dracut yet. We'll have 
to do that early enough already, no need to be premature. :D
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                         ` <4A1C159B.1070009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2009-05-26 19:53                           ` David Dillow
  0 siblings, 0 replies; 22+ messages in thread
From: David Dillow @ 2009-05-26 19:53 UTC (permalink / raw)
  To: Harald Hoyer; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 2009-05-26 at 18:15 +0200, Harald Hoyer wrote:
> On 05/26/2009 04:59 PM, David Dillow wrote:
> > If I need to carry this locally, I don't mind, but I figure others could
> > use the fix when working on the initramfs.
>
> just omit the dash module for debugging purposes :)
> 
> dracut --omit dash

Yeah, but I want to be a good citizen and make sure my scripts work with
dash, which often requires debugging. :)

If you guys don't want to put in fixes for this, I'm fine with carrying
it locally. I can understand not wanting to work around every broken
utility out there, but at some point it may make sense to list the
distro's we're going to explicitly support, and then we may want to have
workarounds available for the tools provided.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                         ` <Pine.LNX.4.58.0905261818090.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
@ 2009-05-26 19:55                           ` David Dillow
       [not found]                             ` <1243367721.19603.10.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
  0 siblings, 1 reply; 22+ messages in thread
From: David Dillow @ 2009-05-26 19:55 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 2009-05-26 at 18:20 +0200, Andreas Thienemann wrote:
> On Tue, 26 May 2009, David Dillow wrote:
> 
> > Some of us want to use dracut on F10, or better yet CentOS 5.3. And we
> > test on released distros, not an unreleased one (albeit coming very
> > soon).
> 
> I can push an upgrade for F10. But Centos? I'm not sure they  even have 
> dash.

They do.

> > Does my later patch, that just makes /dev/tty point to /dev/console for
> > the emergency shell seem unobtrusive enough to take upstream?
> 
> Personally, I don't like it. It's a workaround for one single shell, which 
> has this bug already fixed in it's code repo.
> 
> I think we shouldn't start putting workarounds into dracut yet. We'll have 
> to do that early enough already, no need to be premature. :D

Ok, I'm fine with carrying this locally until F10 gets fixed. I agree
with not wanting to have to accumulate workarounds until we start
listing supported distros.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                             ` <1243367721.19603.10.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
@ 2009-05-26 20:39                               ` Andreas Thienemann
  2009-05-26 20:39                               ` David Dillow
  1 sibling, 0 replies; 22+ messages in thread
From: Andreas Thienemann @ 2009-05-26 20:39 UTC (permalink / raw)
  To: David Dillow; +Cc: Andreas Thienemann, initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 26 May 2009, David Dillow wrote:

> > I can push an upgrade for F10. But Centos? I'm not sure they  even have 
> > dash.
> They do.

Not in main AFAICS and EPEL doesn't have it either. So no way of me fixing 
the issue there. 

But F10 just got an updated dash built.

 
> Ok, I'm fine with carrying this locally until F10 gets fixed. I agree
> with not wanting to have to accumulate workarounds until we start
> listing supported distros.

Right, which could be an interesting excercise in itself... :/

regards,
 andreas
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                             ` <1243367721.19603.10.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
  2009-05-26 20:39                               ` Andreas Thienemann
@ 2009-05-26 20:39                               ` David Dillow
       [not found]                                 ` <1243370347.19603.14.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
  1 sibling, 1 reply; 22+ messages in thread
From: David Dillow @ 2009-05-26 20:39 UTC (permalink / raw)
  To: Andreas Thienemann; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 2009-05-26 at 15:55 -0400, David Dillow wrote:
> On Tue, 2009-05-26 at 18:20 +0200, Andreas Thienemann wrote:
> > On Tue, 26 May 2009, David Dillow wrote:
> > 
> > > Some of us want to use dracut on F10, or better yet CentOS 5.3. And we
> > > test on released distros, not an unreleased one (albeit coming very
> > > soon).
> > 
> > I can push an upgrade for F10. But Centos? I'm not sure they  even have 
> > dash.
> 
> They do.

Bah! I cannot read -- I saw dasher instead of dash, so they do not
include it.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]         ` <20090526024454.GA10049-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  2009-05-26  2:58           ` David Dillow
@ 2009-05-27 20:26           ` Warren Togami
  1 sibling, 0 replies; 22+ messages in thread
From: Warren Togami @ 2009-05-27 20:26 UTC (permalink / raw)
  To: initramfs

On 05/25/2009 10:44 PM, Jeremy Katz wrote:
> On Monday, May 25 2009, David Dillow said:
>> dash gets upset when it cannot open /dev/tty, and we lose stderr. Even
>> if we make /dev/tty once we're in the initramfs, it will still be too
>> late for the inital dash shell running the init script. So, make a small
>> set of nodes in the dracut script while building the directory structure
>> of the initramfs.
>
> Creating the nodes in the dracut script means that you can't create the
> initramfs as non-root, though.  :(
>

Unless we write a separate program that outputs cpio files.  Perhaps not 
worth the effort?  How important is it to make initrd from non-root?

Warren Togami
wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] dracut: make initial devices outside of initramfs
       [not found]                                 ` <1243370347.19603.14.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
@ 2009-05-27 20:31                                   ` Warren Togami
  0 siblings, 0 replies; 22+ messages in thread
From: Warren Togami @ 2009-05-27 20:31 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

On 05/26/2009 04:39 PM, David Dillow wrote:
> Bah! I cannot read -- I saw dasher instead of dash, so they do not
> include it.

Anybody can join EPEL as a packager to add and maintain packages in the 
EPEL collection.

Warren Togami
wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2009-05-27 20:31 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-23 11:34 No stdout when using dash Andreas Thienemann
     [not found] ` <Pine.LNX.4.58.0905231331400.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
2009-05-23 12:29   ` Victor Lowther
     [not found]     ` <1243081747.29452.38.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
2009-05-23 12:51       ` Andreas Thienemann
     [not found]         ` <Pine.LNX.4.58.0905231450240.2058-bvJ793YqIODNUDpmljszgg@public.gmane.org>
2009-05-23 16:56           ` Victor Lowther
2009-05-23 12:48   ` Victor Lowther
     [not found]     ` <1243082881.29452.45.camel-76q0VzFBGGqhmyxYjSZgiRL4W9x8LtSr@public.gmane.org>
2009-05-23 13:06       ` Andreas Thienemann
2009-05-23 13:26       ` Kay Sievers
     [not found]         ` <ac3eb2510905230626k5a8b3d25l5c4de0c9017b9c80-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-23 16:57           ` Victor Lowther
2009-05-26  2:42   ` [PATCH] dracut: make initial devices outside of initramfs David Dillow
     [not found]     ` <1243305738.3584.40.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2009-05-26  2:44       ` Jeremy Katz
     [not found]         ` <20090526024454.GA10049-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-26  2:58           ` David Dillow
     [not found]             ` <1243306682.3584.42.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2009-05-26  3:44               ` David Dillow
2009-05-26 14:36               ` Andreas Thienemann
     [not found]                 ` <Pine.LNX.4.58.0905261634470.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
2009-05-26 14:59                   ` David Dillow
     [not found]                     ` <1243349941.19603.5.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2009-05-26 16:15                       ` Harald Hoyer
     [not found]                         ` <4A1C159B.1070009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-26 19:53                           ` David Dillow
2009-05-26 16:20                       ` Andreas Thienemann
     [not found]                         ` <Pine.LNX.4.58.0905261818090.2270-bvJ793YqIODNUDpmljszgg@public.gmane.org>
2009-05-26 19:55                           ` David Dillow
     [not found]                             ` <1243367721.19603.10.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2009-05-26 20:39                               ` Andreas Thienemann
2009-05-26 20:39                               ` David Dillow
     [not found]                                 ` <1243370347.19603.14.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2009-05-27 20:31                                   ` Warren Togami
2009-05-27 20:26           ` Warren Togami

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.