dtc build failures on OS X

dtc build failures on OS X

[Timur Tabi]

I'm trying to build dtc on Mac OS X.  The compilation seems to go
okay, but the linker dies.  First, it says this:

	 LD libfdt/libfdt.so
ld: unknown option: --version-script=libfdt/version.lds
collect2: ld returned 1 exit status

A Google search suggested that I can just delete the --version-script
option.  I did that, and now I get this error:

	 LD libfdt/libfdt.so
ld: unknown option: -soname
collect2: ld returned 1 exit status

This web page: http://lists.apple.com/archives/unix-porting/2003/Oct/msg00032.html
had some suggestions on how to fix that, so my Makefile now looks like
this:

$(LIBFDT_lib):
        @$(VECHO) LD $@
        $(CC) $(LDFLAGS) -fPIC -Wl,-dylib_install_name -Wl,$(notdir
$@) -shared -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).so $^
        ln -s libfdt-$(DTC_VERSION).so $(LIBFDT_objdir)/libfdt.so

But now I get this error:

	 LD libfdt/libfdt.so
Undefined symbols:
  "_main", referenced from:
      start in crt1.10.5.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

So now I'm stuck.  Has anyone tried this before?  Can anyone tell me
how to fix this?

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: dtc build failures on OS X

[David Gibson]

On Tue, May 19, 2009 at 09:08:14PM -0500, Timur Tabi wrote:
> I'm trying to build dtc on Mac OS X.  The compilation seems to go
> okay, but the linker dies.  First, it says this:

Well, I'm not surprised something has gone wrong - not much work has
gone into making dtc portable yet (though it has been compiled on
FreeBSD, at least).

> 	 LD libfdt/libfdt.so
> ld: unknown option: --version-script=libfdt/version.lds
> collect2: ld returned 1 exit status
> 
> A Google search suggested that I can just delete the --version-script
> option.  I did that, and now I get this error:

Hrm.  What toolchain are you using?

> 	 LD libfdt/libfdt.so
> ld: unknown option: -soname
> collect2: ld returned 1 exit status
> 
> This web page: http://lists.apple.com/archives/unix-porting/2003/Oct/msg00032.html
> had some suggestions on how to fix that, so my Makefile now looks like
> this:
> 
> $(LIBFDT_lib):
>         @$(VECHO) LD $@
>         $(CC) $(LDFLAGS) -fPIC -Wl,-dylib_install_name -Wl,$(notdir
> $@) -shared -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).so $^
>         ln -s libfdt-$(DTC_VERSION).so $(LIBFDT_objdir)/libfdt.so
> 
> But now I get this error:
> 
> 	 LD libfdt/libfdt.so
> Undefined symbols:
>   "_main", referenced from:
>       start in crt1.10.5.o
> ld: symbol(s) not found
> collect2: ld returned 1 exit status

*That* looks like it's trying to build an executable, rather than a
shared library.  Hence including the crt1.o module, which wants to
call main().

> So now I'm stuck.  Has anyone tried this before?  Can anyone tell me
> how to fix this?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: dtc build failures on OS X

[Jean-Christophe PLAGNIOL-VILLARD]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

On 21:08 Tue 19 May     , Timur Tabi wrote:
> I'm trying to build dtc on Mac OS X.  The compilation seems to go
> okay, but the linker dies.  First, it says this:
> 
> 	 LD libfdt/libfdt.so
> ld: unknown option: --version-script=libfdt/version.lds
> collect2: ld returned 1 exit status
> 
> A Google search suggested that I can just delete the --version-script
> option.  I did that, and now I get this error:
> 
> 	 LD libfdt/libfdt.so
> ld: unknown option: -soname
> collect2: ld returned 1 exit status
> 
> This web page: http://lists.apple.com/archives/unix-porting/2003/Oct/msg00032.html
> had some suggestions on how to fix that, so my Makefile now looks like
> this:
> 
> $(LIBFDT_lib):
>         @$(VECHO) LD $@
>         $(CC) $(LDFLAGS) -fPIC -Wl,-dylib_install_name -Wl,$(notdir
> $@) -shared -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).so $^
>         ln -s libfdt-$(DTC_VERSION).so $(LIBFDT_objdir)/libfdt.so
> 
> But now I get this error:
> 
> 	 LD libfdt/libfdt.so
> Undefined symbols:
>   "_main", referenced from:
>       start in crt1.10.5.o
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> 
> So now I'm stuck.  Has anyone tried this before?  Can anyone tell me
> how to fix this?
-shared is incorrect on mac os it's -dynamiclib
see attached patch

Best Regards,
J.

[-- Attachment #2: 0001-add-Mac-OS-X-support.patch --]
[-- Type: text/x-diff, Size: 1985 bytes --]

>From 37a2ddc183fa381cc025adf8e9d9d143029fe159 Mon Sep 17 00:00:00 2001
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Date: Wed, 20 May 2009 09:50:31 +0200
Subject: [PATCH] add Mac OS X support

use dylib shared lib extention
allow to specifiy os specific shared lib link option
Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
and does not support --version-script

to buid on it do

make OSX=y

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
---
 Makefile |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index be0fc8b..d8b3353 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,14 @@ BINDIR = $(PREFIX)/bin
 LIBDIR = $(PREFIX)/lib
 INCLUDEDIR = $(PREFIX)/include
 
+ifdef OSX
+SHAREDLIB_EXT=dylib
+SHAREDLIB_LINK_OPTIONS=-dynamiclib -Wl,-install_name -Wl,
+else
+SHAREDLIB_EXT=so
+SHAREDLIB_LINK_OPTIONS=-shared -Wl,--version-script=$(LIBFDT_version) -Wl,-soname,
+endif
+
 #
 # Overall rules
 #
@@ -116,7 +124,7 @@ endif
 LIBFDT_objdir = libfdt
 LIBFDT_srcdir = libfdt
 LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
-LIBFDT_lib = $(LIBFDT_objdir)/libfdt.so
+LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
 LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
 LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
 
@@ -220,8 +228,8 @@ clean: libfdt_clean tests_clean
 
 $(LIBFDT_lib):
 	@$(VECHO) LD $@
-	$(CC) $(LDFLAGS) -fPIC -Wl,--version-script=$(LIBFDT_version) -Wl,-soname,$(notdir $@) -shared -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).so $^
-	ln -s libfdt-$(DTC_VERSION).so $(LIBFDT_objdir)/libfdt.so
+	$(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(notdir $@) -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $^
+	ln -sf libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
 
 %.lex.c: %.l
 	@$(VECHO) LEX $@
-- 
1.6.0.4


[-- Attachment #3: Type: text/plain, Size: 194 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
https://ozlabs.org/mailman/listinfo/devicetree-discuss

Re: dtc build failures on OS X

[Segher Boessenkool]

> I'm trying to build dtc on Mac OS X.  The compilation seems to go
> okay, but the linker dies.

It doesn't die, it just complains ;-)

You're trying to build a Linux shared library on OSX.  This won't
work.  Not only are the command line options not the same, the
semantics are totally different as well; importantly, the versioning
mechanism is very different.  Given that, you do not want to use
a shared library at all -- just use a normal (static) library.
IMNSHO that should be the default, on Linux as well...


Segher

Re: dtc build failures on OS X

[David Gibson]

On Wed, May 20, 2009 at 02:38:49PM +0200, Segher Boessenkool wrote:
>> I'm trying to build dtc on Mac OS X.  The compilation seems to go
>> okay, but the linker dies.
>
> It doesn't die, it just complains ;-)
>
> You're trying to build a Linux shared library on OSX.  This won't
> work.  Not only are the command line options not the same, the
> semantics are totally different as well; importantly, the versioning
> mechanism is very different.  Given that, you do not want to use
> a shared library at all -- just use a normal (static) library.
> IMNSHO that should be the default, on Linux as well...

It was, originally, but someone wanted a shared lib.

Actually, the current Makefile builds both, by default.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: dtc build failures on OS X

[Segher Boessenkool]

>>> I'm trying to build dtc on Mac OS X.  The compilation seems to go
>>> okay, but the linker dies.
>>
>> It doesn't die, it just complains ;-)
>>
>> You're trying to build a Linux shared library on OSX.  This won't
>> work.  Not only are the command line options not the same, the
>> semantics are totally different as well; importantly, the versioning
>> mechanism is very different.  Given that, you do not want to use
>> a shared library at all -- just use a normal (static) library.
>> IMNSHO that should be the default, on Linux as well...
>
> It was, originally, but someone wanted a shared lib.

And you decided to take on all that maintenance pain?  You're
too good for this world.  Or gullible, heh.

> Actually, the current Makefile builds both, by default.

It shouldn't try to build Linux shared objects unless you are
building a Linux target; easiest would be to just never build
the shared library by default.  Your choice :-)


Segher

Re: dtc build failures on OS X

[David Gibson]

On Thu, May 21, 2009 at 07:46:04PM +0200, Segher Boessenkool wrote:
>>>> I'm trying to build dtc on Mac OS X.  The compilation seems to go
>>>> okay, but the linker dies.
>>>
>>> It doesn't die, it just complains ;-)
>>>
>>> You're trying to build a Linux shared library on OSX.  This won't
>>> work.  Not only are the command line options not the same, the
>>> semantics are totally different as well; importantly, the versioning
>>> mechanism is very different.  Given that, you do not want to use
>>> a shared library at all -- just use a normal (static) library.
>>> IMNSHO that should be the default, on Linux as well...
>>
>> It was, originally, but someone wanted a shared lib.
>
> And you decided to take on all that maintenance pain?  You're
> too good for this world.  Or gullible, heh.

Something like that.

>> Actually, the current Makefile builds both, by default.
>
> It shouldn't try to build Linux shared objects unless you are
> building a Linux target; easiest would be to just never build
> the shared library by default.  Your choice :-)

Well, to be fair, the current rule should be right, or close to it,
for most ELF systems, not just Linux.

Actually, another issue with this is that currently we build all the
libfdt objects with -fPIC, which significantly increases their size.
That tends to frighten people who are looking at building libfdt into
their firmware.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: dtc build failures on OS X

[Timur Tabi]

On Wed, May 20, 2009 at 2:46 AM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:

> -shared is incorrect on mac os it's -dynamiclib
> see attached patch

Acked-by: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

It would be nice if it auto-detected OS X, but I'm glad it works.  Thanks.

-- 
Timur Tabi
Linux kernel developer at Freescale

[PATCH V2] add Mac OS X support

[Jean-Christophe PLAGNIOL-VILLARD]

use dylib shared lib extention
allow to specifiy os specific shared lib link option
Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
and does not support --version-script

add HOSTOS macro to detect the current os you are

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
---
V2
detect dynamicly the host OS
 Makefile |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index be0fc8b..d7549b2 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,17 @@ BINDIR = $(PREFIX)/bin
 LIBDIR = $(PREFIX)/lib
 INCLUDEDIR = $(PREFIX)/include
 
+HOSTOS := $(shell uname -s | tr '[:upper:]' '[:lower:]' | \
+	    sed -e 's/\(cygwin\).*/cygwin/')
+
+ifeq ($(HOSTOS),darwin)
+SHAREDLIB_EXT=dylib
+SHAREDLIB_LINK_OPTIONS=-dynamiclib -Wl,-install_name -Wl,
+else
+SHAREDLIB_EXT=so
+SHAREDLIB_LINK_OPTIONS=-shared -Wl,--version-script=$(LIBFDT_version) -Wl,-soname,
+endif
+
 #
 # Overall rules
 #
@@ -116,7 +127,7 @@ endif
 LIBFDT_objdir = libfdt
 LIBFDT_srcdir = libfdt
 LIBFDT_archive = $(LIBFDT_objdir)/libfdt.a
-LIBFDT_lib = $(LIBFDT_objdir)/libfdt.so
+LIBFDT_lib = $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
 LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES))
 LIBFDT_version = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_VERSION))
 
@@ -220,8 +231,8 @@ clean: libfdt_clean tests_clean
 
 $(LIBFDT_lib):
 	@$(VECHO) LD $@
-	$(CC) $(LDFLAGS) -fPIC -Wl,--version-script=$(LIBFDT_version) -Wl,-soname,$(notdir $@) -shared -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).so $^
-	ln -s libfdt-$(DTC_VERSION).so $(LIBFDT_objdir)/libfdt.so
+	$(CC) $(LDFLAGS) -fPIC $(SHAREDLIB_LINK_OPTIONS)$(notdir $@) -o $(LIBFDT_objdir)/libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $^
+	ln -sf libfdt-$(DTC_VERSION).$(SHAREDLIB_EXT) $(LIBFDT_objdir)/libfdt.$(SHAREDLIB_EXT)
 
 %.lex.c: %.l
 	@$(VECHO) LEX $@
-- 
1.6.0.4

Re: [PATCH V2] add Mac OS X support

[Timur Tabi]

On Tue, May 26, 2009 at 1:07 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> use dylib shared lib extention
> allow to specifiy os specific shared lib link option
> Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
> and does not support --version-script
>
> add HOSTOS macro to detect the current os you are
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>

Acked-by: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [PATCH V2] add Mac OS X support

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:07 Tue 26 May     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> use dylib shared lib extention
> allow to specifiy os specific shared lib link option
> Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
> and does not support --version-script
> 
> add HOSTOS macro to detect the current os you are
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> ---
jdl do you have any plan to apply it?

Best Regards,
J.

Re: [PATCH V2] add Mac OS X support

[Timur Tabi]

Jon, are you still updating dtc.git?

On Sat, Jun 13, 2009 at 2:21 PM, Jean-Christophe
PLAGNIOL-VILLARD<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> On 20:07 Tue 26 May     , Jean-Christophe PLAGNIOL-VILLARD wrote:
>> use dylib shared lib extention
>> allow to specifiy os specific shared lib link option
>> Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
>> and does not support --version-script
>>
>> add HOSTOS macro to detect the current os you are
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
>> ---
> jdl do you have any plan to apply it?
>
> Best Regards,
> J.
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
> https://ozlabs.org/mailman/listinfo/devicetree-discuss
>



-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [PATCH V2] add Mac OS X support

[Jon Loeliger]

> Jon, are you still updating dtc.git?

Yep.

jdl

Re: [PATCH V2] add Mac OS X support

[Timur Tabi]

On Wed, Jul 15, 2009 at 7:43 PM, Jon Loeliger<jdl-CYoMK+44s/E@public.gmane.org> wrote:
>> Jon, are you still updating dtc.git?
>
> Yep.

Then would you be so kind as to apply my patch, if you have no objections?

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [PATCH V2] add Mac OS X support

[Jon Loeliger]

> use dylib shared lib extention
> allow to specifiy os specific shared lib link option
> Mac OS use -dynamiclib instead of -shared, -install_name instead of -soname
> and does not support --version-script
> 
> add HOSTOS macro to detect the current os you are
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> ---
> V2
> detect dynamicly the host OS


Applied and pushed out.

Thanks,
jdl