Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

matthieu castet <castet.matthieu@free.fr> wrote:
> airo driver hang with 2.6.24-6 on a PIII.
> It seems it it because it need aes crypto.
> It will first try to load padlock-aes, but it fails to load
> Then it load geode_aes which load, and airo hang (airo seems to use
> geode_aes). [1]
[...]

geode_aes is a PCI driver and should be automatically loaded if the PCI
device it handles is present.  However, since it also declares the alias
"aes", when the crypto system attempts to load the "aes" module it may
load this module and then wait for up to a minute for it to initialise
and register the "aes" algorithm.  geode_aes will never do this, since
if there was a suitable device present it would already have been
loaded.

(The padlock modules don't seem to have the same problem because their
module initialisation functions immediately return failure if the CPU
doesn't support.)

I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS
declaration or (2) making the module initialisation function fail if the
device is not present.  The latter behaviour is generally wrong for PCI
drivers, but this device presumably cannot be hotplugged.

Ben.

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

[Herbert Xu]

Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS
> declaration or (2) making the module initialisation function fail if the
> device is not present.  The latter behaviour is generally wrong for PCI
> drivers, but this device presumably cannot be hotplugged.

I was going to remove this alias but found that it was already
removed two years ago.  Please revise your theory based on this
new discovery :)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-image-2.6.24-1-686: airo hang when loading because of aes

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Tue, 2009-06-02 at 15:12 +1000, Herbert Xu wrote:
> Ben Hutchings <ben@decadent.org.uk> wrote:
> > 
> > I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS
> > declaration or (2) making the module initialisation function fail if the
> > device is not present.  The latter behaviour is generally wrong for PCI
> > drivers, but this device presumably cannot be hotplugged.
> 
> I was going to remove this alias but found that it was already
> removed two years ago.  Please revise your theory based on this
> new discovery :)

As the subject says, this bug was found in 2.6.24.  Sorry I forgot to
check the current version; I generally would do that.  I think you've
confirmed that (1) is the correct fix.

Ben.

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]