uclibc.inc: remove gnu hash for mips and mipsel

uclibc.inc: remove gnu hash for mips and mipsel

[Denis 'Gnutoo' Carikli]

hi,
I had this failure(mips and uclibc wanted gnu hash but GNU hash is incompatible with mips and mipsel):
ERROR: log data follows (/home/embedded/oetmp_wrt54oe/work/wrt54-linux-uclibc/uclibc-initial-0.9.30.1-r2/temp/log.do_configure.22086)
| NOTE: make STRIPTOOL=true LD=mipsel-linux-uclibc-ld LOCALE_DATA_FILENAME=uClibc-locale-030818.tgz CC=ccache mipsel-linux-uclibc-gcc  HOSTCFLAGS=-I/home/embedded/oetmp_wrt54oe/staging/i686-linux/usr/include oldconfig
|   MKDIR include/config
| ../../Rules.mak:543: *** Your binutils don't support --hash-style option, while you want to use it.  Stop.
| make: *** [extra/config/conf] Error 2
| FATAL: oe_runmake failed
| yes: standard output: Broken pipe
| yes: write error
NOTE: Task failed: /home/embedded/oetmp_wrt54oe/work/wrt54-linux-uclibc/uclibc-initial-0.9.30.1-r2/temp/log.do_configure.22086
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/embedded/oe/org.openembedded.dev/recipes/uclibc/uclibc-initial_0.9.30.1.bb do_configure failed
ERROR: Task 437 (/home/embedded/oe/org.openembedded.dev/recipes/uclibc/uclibc-initial_0.9.30.1.bb, do_configure) failed
NOTE: Tasks Summary: Attempted 155 tasks of which 73 didn't need to be rerun and 1 failed.
ERROR: '/home/embedded/oe/org.openembedded.dev/recipes/uclibc/uclibc-initial_0.9.30.1.bb' failed

it can be fixed with 2 fixes:

the first one is the one that I send for review:
in uclibc.inc it prevent it from having a config that trigger gnu hash

the second one is for distros:
I was told by Tartarus:
May 29 22:11:47 <Tartarus>      I think the right answer is that the logic in conf/distro/include/*.inc needs to get into {eglibc,glibc,uclibc}.inc
May 29 22:11:57 <Tartarus>      yeah, bingo
May 29 22:12:05 <Tartarus>      right now it's in angstrom-*libc.inc and sane-toolchain-*libc.inc

so I added this to the distro I used(wrt54oe):
+require conf/distro/include/sane-toolchain-${LIBC}.inc

and it made it pass the error

Denis

[PATCH] uclibc.inc : also exclude mips and mipsel from GNU hash.

[Denis 'Gnutoo' Carikli]

diff --git a/recipes/uclibc/uclibc.inc b/recipes/uclibc/uclibc.inc
index f2f3e9b..a967954 100644
--- a/recipes/uclibc/uclibc.inc
+++ b/recipes/uclibc/uclibc.inc
@@ -95,7 +95,7 @@ configmangle = 's,^KERNEL_SOURCE=.*,KERNEL_SOURCE="${KERNEL_SOURCE}",g; \
 		s,^SHARED_LIB_LOADER_PREFIX=.*,SHARED_LIB_LOADER_PREFIX="/lib",; \
 		s,.*UCLIBC_HAS_WCHAR.*,UCLIBC_HAS_WCHAR=y,g; \
 		${@["","s,.*UCLIBC_HAS_LOCALE.*,UCLIBC_HAS_LOCALE=y,;"][bb.data.getVar("USE_NLS", d, 1) == "yes"]} \
-		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) == "avr32"]} \
+		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) in ['mips', 'mipsel', 'avr32']]} \
                '
 
 CFLAGS := "${@oe_filter_out('-I\S+', '${CFLAGS}', d)}"
-- 
1.6.0.6

Re: [PATCH] uclibc.inc : also exclude mips and mipsel from GNU hash.

[Tom Rini]

On Wed, Jun 03, 2009 at 12:29:58AM +0200, Denis 'Gnutoo' Carikli wrote:

Acked-by: Tom Rini <trini@embeddedalley.com>

> diff --git a/recipes/uclibc/uclibc.inc b/recipes/uclibc/uclibc.inc
> index f2f3e9b..a967954 100644
> --- a/recipes/uclibc/uclibc.inc
> +++ b/recipes/uclibc/uclibc.inc
> @@ -95,7 +95,7 @@ configmangle = 's,^KERNEL_SOURCE=.*,KERNEL_SOURCE="${KERNEL_SOURCE}",g; \
>  		s,^SHARED_LIB_LOADER_PREFIX=.*,SHARED_LIB_LOADER_PREFIX="/lib",; \
>  		s,.*UCLIBC_HAS_WCHAR.*,UCLIBC_HAS_WCHAR=y,g; \
>  		${@["","s,.*UCLIBC_HAS_LOCALE.*,UCLIBC_HAS_LOCALE=y,;"][bb.data.getVar("USE_NLS", d, 1) == "yes"]} \
> -		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) == "avr32"]} \
> +		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) in ['mips', 'mipsel', 'avr32']]} \
>                 '
>  
>  CFLAGS := "${@oe_filter_out('-I\S+', '${CFLAGS}', d)}"
> -- 
> 1.6.0.6
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 

-- 
Tom Rini

Re: [PATCH] uclibc.inc : also exclude mips and mipsel from GNU hash.

[GNUtoo]

On Tue, 2009-06-02 at 15:56 -0700, Tom Rini wrote:
> On Wed, Jun 03, 2009 at 12:29:58AM +0200, Denis 'Gnutoo' Carikli wrote:
> 
> Acked-by: Tom Rini <trini@embeddedalley.com>
> 
> > diff --git a/recipes/uclibc/uclibc.inc b/recipes/uclibc/uclibc.inc
> > index f2f3e9b..a967954 100644
> > --- a/recipes/uclibc/uclibc.inc
> > +++ b/recipes/uclibc/uclibc.inc
> > @@ -95,7 +95,7 @@ configmangle = 's,^KERNEL_SOURCE=.*,KERNEL_SOURCE="${KERNEL_SOURCE}",g; \
> >  		s,^SHARED_LIB_LOADER_PREFIX=.*,SHARED_LIB_LOADER_PREFIX="/lib",; \
> >  		s,.*UCLIBC_HAS_WCHAR.*,UCLIBC_HAS_WCHAR=y,g; \
> >  		${@["","s,.*UCLIBC_HAS_LOCALE.*,UCLIBC_HAS_LOCALE=y,;"][bb.data.getVar("USE_NLS", d, 1) == "yes"]} \
> > -		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) == "avr32"]} \
> > +		${@["","s,.*LDSO_GNU_HASH_SUPPORT.*,# LDSO_GNU_HASH_SUPPORT is not set,;"][bb.data.getVar("TARGET_ARCH", d, 1) in ['mips', 'mipsel', 'avr32']]} \
> >                 '
> >  
> >  CFLAGS := "${@oe_filter_out('-I\S+', '${CFLAGS}', d)}"
> > -- 
> > 1.6.0.6
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> > 
pushed
Thanks
Denis