* [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n
@ 2009-06-07 13:05 Peter Korsgaard
2009-06-08 14:39 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2009-06-07 13:05 UTC (permalink / raw)
To: ben-linux, linux-fbdev-devel, linux-arm-kernel; +Cc: Peter Korsgaard, wookey
Fixes `s3c_fb_remove' referenced in section `.data' of
drivers/built-in.o: defined in discarded section `.devexit.text' of
drivers/built-in.o
With CONFIG_HOTPLUG=n functions marked with __devexit gets removed, so
make sure we use __devexit_p when referencing pointers to them.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/video/s3c-fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index d3a568e..db71de1 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1018,7 +1018,7 @@ static int s3c_fb_resume(struct platform_device *pdev)
static struct platform_driver s3c_fb_driver = {
.probe = s3c_fb_probe,
- .remove = s3c_fb_remove,
+ .remove = __devexit_p(s3c_fb_remove),
.suspend = s3c_fb_suspend,
.resume = s3c_fb_resume,
.driver = {
--
1.6.2
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n
2009-06-07 13:05 [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n Peter Korsgaard
@ 2009-06-08 14:39 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2009-06-08 14:39 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: ben-linux, linux-fbdev-devel, linux-arm-kernel, wookey
On Sun, Jun 07, 2009 at 03:05:39PM +0200, Peter Korsgaard wrote:
> Fixes `s3c_fb_remove' referenced in section `.data' of
> drivers/built-in.o: defined in discarded section `.devexit.text' of
> drivers/built-in.o
>
> With CONFIG_HOTPLUG=n functions marked with __devexit gets removed, so
> make sure we use __devexit_p when referencing pointers to them.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/video/s3c-fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index d3a568e..db71de1 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1018,7 +1018,7 @@ static int s3c_fb_resume(struct platform_device *pdev)
>
> static struct platform_driver s3c_fb_driver = {
> .probe = s3c_fb_probe,
> - .remove = s3c_fb_remove,
> + .remove = __devexit_p(s3c_fb_remove),
> .suspend = s3c_fb_suspend,
> .resume = s3c_fb_resume,
> .driver = {
> --
> 1.6.2
>
>
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-08 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-07 13:05 [PATCH] video: s3c_fb.c: fix build with CONFIG_HOTPLUG=n Peter Korsgaard
2009-06-08 14:39 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.