[PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Vikram Pandita]

IRQ for 8250 driver is not working on zoom2 as IRQ HIGH level
setting is requried

This setting was not possible in 8250 driver

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/mach-omap2/board-zoom-debugboard.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
index bac5c43..a8c45dc 100644
--- a/arch/arm/mach-omap2/board-zoom-debugboard.c
+++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
@@ -83,7 +83,8 @@ static struct plat_serial8250_port serial_platform_data[] = {
 	{
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
-		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ|
+					UPF_IRQ_TRIG_HIGH,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,
-- 
1.6.0.3.613.g9f8f13

[APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

RE: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Pandita, Vikram]

Tony

>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Tony
>Lindgren
>Sent: Wednesday, June 17, 2009 8:57 AM
>To: linux-omap@vger.kernel.org
>Subject: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
>
>This patch has been applied to the linux-omap
>by youw fwiendly patch wobot.
>
>Branch in linux-omap: omap-fixes
>
>Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>
>PatchWorks
>http://patchwork.kernel.org/patch/29668/

This patch breaks the zoom2 build.
...	
	arch/arm/mach-omap2/board-zoom-debugboard.c:87: error: 'UPF_IRQ_TRIG_HIGH' undeclared here (not 	in a function)
	make[1]: *** [arch/arm/mach-omap2/board-zoom-debugboard.o] Error 1
	make: *** [arch/arm/mach-omap2] Error 2
...

There is a dependency on 8250 patch:
http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach


how do you want to address this issue?


>
>Git (Likely to change, and takes a while to get mirrored)
>http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
>2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Kevin Hilman]

"Pandita, Vikram" <vikram.pandita@ti.com> writes:

>>This patch has been applied to the linux-omap
>>by youw fwiendly patch wobot.
>>
>>Branch in linux-omap: omap-fixes
>>
>>Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>>
>>PatchWorks
>>http://patchwork.kernel.org/patch/29668/
>
> This patch breaks the zoom2 build.
> ...	
> 	arch/arm/mach-omap2/board-zoom-debugboard.c:87: error: 'UPF_IRQ_TRIG_HIGH' undeclared here (not 	in a function)
> 	make[1]: *** [arch/arm/mach-omap2/board-zoom-debugboard.o] Error 1
> 	make: *** [arch/arm/mach-omap2] Error 2
> ...
>
> There is a dependency on 8250 patch:
> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach
>
>
> how do you want to address this issue?
>

Tony,

IMO, We should probably stage the 8250 UPF_* change in l-o as well
while we wait for the linux-serial lag.

Kevin

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Kevin Hilman]

Tony Lindgren <tony@atomide.com> writes:

> This patch has been applied to the linux-omap
> by youw fwiendly patch wobot.
>
> Branch in linux-omap: omap-fixes
>
> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>
> PatchWorks
> http://patchwork.kernel.org/patch/29668/
>
> Git (Likely to change, and takes a while to get mirrored)
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
patch is wrong and not terribly helpful.  It refers to the symptom, bu
tnot the root cause.

It should be something like: 

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Kevin

RE: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Pandita, Vikram]

>-----Original Message-----
>From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>Sent: Wednesday, June 17, 2009 10:55 AM
>To: Tony Lindgren; Pandita, Vikram
>Cc: linux-omap@vger.kernel.org
>Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
>
>Tony Lindgren <tony@atomide.com> writes:
>
>> This patch has been applied to the linux-omap
>> by youw fwiendly patch wobot.
>>
>> Branch in linux-omap: omap-fixes
>>
>> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>>
>> PatchWorks
>> http://patchwork.kernel.org/patch/29668/
>>
>> Git (Likely to change, and takes a while to get mirrored)
>> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
>2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
>
>Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
>patch is wrong and not terribly helpful.  It refers to the symptom, bu
>tnot the root cause.
>
>It should be something like:
>
>OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Yes that should have been the subject and 
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach

It's learning for next time.

>
>Kevin
>
>

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Tony Lindgren]

* Pandita, Vikram <vikram.pandita@ti.com> [090617 19:26]:
> 
> 
> >-----Original Message-----
> >From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> >Sent: Wednesday, June 17, 2009 10:55 AM
> >To: Tony Lindgren; Pandita, Vikram
> >Cc: linux-omap@vger.kernel.org
> >Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
> >
> >Tony Lindgren <tony@atomide.com> writes:
> >
> >> This patch has been applied to the linux-omap
> >> by youw fwiendly patch wobot.
> >>
> >> Branch in linux-omap: omap-fixes
> >>
> >> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
> >>
> >> PatchWorks
> >> http://patchwork.kernel.org/patch/29668/
> >>
> >> Git (Likely to change, and takes a while to get mirrored)
> >> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
> >2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
> >
> >Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
> >patch is wrong and not terribly helpful.  It refers to the symptom, bu
> >tnot the root cause.
> >
> >It should be something like:
> >
> >OMAP3: Zoom2: pass IRQ triggering flags for serial driver
> 
> Yes that should have been the subject and 
> is put that way for the 8250 driver:
> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach
> 
> It's learning for next time.

Will revert. I guess we now need two 8250 patches upstream? One for the
omap register define, and one for the interrupt flags?

Tony

RE: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Pandita, Vikram]

>-----Original Message-----
>From: Tony Lindgren [mailto:tony@atomide.com]
>Sent: Thursday, June 18, 2009 12:27 AM
>To: Pandita, Vikram
>Cc: Kevin Hilman; linux-omap@vger.kernel.org
>Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
>
>* Pandita, Vikram <vikram.pandita@ti.com> [090617 19:26]:
>>
>>
>> >-----Original Message-----
>> >From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> >Sent: Wednesday, June 17, 2009 10:55 AM
>> >To: Tony Lindgren; Pandita, Vikram
>> >Cc: linux-omap@vger.kernel.org
>> >Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
>> >
>> >Tony Lindgren <tony@atomide.com> writes:
>> >
>> >> This patch has been applied to the linux-omap
>> >> by youw fwiendly patch wobot.
>> >>
>> >> Branch in linux-omap: omap-fixes
>> >>
>> >> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>> >>
>> >> PatchWorks
>> >> http://patchwork.kernel.org/patch/29668/
>> >>
>> >> Git (Likely to change, and takes a while to get mirrored)
>> >> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
>> >2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
>> >
>> >Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
>> >patch is wrong and not terribly helpful.  It refers to the symptom, bu
>> >tnot the root cause.
>> >
>> >It should be something like:
>> >
>> >OMAP3: Zoom2: pass IRQ triggering flags for serial driver
>>
>> Yes that should have been the subject and
>> is put that way for the 8250 driver:
>> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach
>>
>> It's learning for next time.
>
>Will revert. I guess we now need two 8250 patches upstream? One for the
>omap register define, and one for the interrupt flags?

Would be very helpful if you could host these 8250 patches on l-o till we get someone to respond to these. This is a critical dependency.


>
>Tony

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Kevin Hilman]

Tony Lindgren <tony@atomide.com> writes:

> * Pandita, Vikram <vikram.pandita@ti.com> [090617 19:26]:
>> 
>> 
>> >-----Original Message-----
>> >From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> >Sent: Wednesday, June 17, 2009 10:55 AM
>> >To: Tony Lindgren; Pandita, Vikram
>> >Cc: linux-omap@vger.kernel.org
>> >Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
>> >
>> >Tony Lindgren <tony@atomide.com> writes:
>> >
>> >> This patch has been applied to the linux-omap
>> >> by youw fwiendly patch wobot.
>> >>
>> >> Branch in linux-omap: omap-fixes
>> >>
>> >> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
>> >>
>> >> PatchWorks
>> >> http://patchwork.kernel.org/patch/29668/
>> >>
>> >> Git (Likely to change, and takes a while to get mirrored)
>> >> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
>> >2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
>> >
>> >Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
>> >patch is wrong and not terribly helpful.  It refers to the symptom, bu
>> >tnot the root cause.
>> >
>> >It should be something like:
>> >
>> >OMAP3: Zoom2: pass IRQ triggering flags for serial driver
>> 
>> Yes that should have been the subject and 
>> is put that way for the 8250 driver:
>> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach
>> 
>> It's learning for next time.
>
> Will revert. I guess we now need two 8250 patches upstream? One for the
> omap register define, and one for the interrupt flags?

Yes, both of these are pending on LKML, and still no word from Alan.

To get it upstream, I defined wake-up register locally in
mach-omap2/serial.c until the patch gets merged, but for the interrupt
flags there isn't an easy solution.

Kevin

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Kevin Hilman]

"Pandita, Vikram" <vikram.pandita@ti.com> writes:

>>
>>Will revert. I guess we now need two 8250 patches upstream? One for the
>>omap register define, and one for the interrupt flags?
>
> Would be very helpful if you could host these 8250 patches on l-o
> till we get someone to respond to these. This is a critical
> dependency.

FYI... I have these staged in the 'pm-upstream/backports' branch of my
linux-omap-pm repo, since they are needed for PM testing on Zoom2.

Kevin

Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

[Tony Lindgren]

* Kevin Hilman <khilman@deeprootsystems.com> [090618 17:12]:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > * Pandita, Vikram <vikram.pandita@ti.com> [090617 19:26]:
> >> 
> >> 
> >> >-----Original Message-----
> >> >From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> >> >Sent: Wednesday, June 17, 2009 10:55 AM
> >> >To: Tony Lindgren; Pandita, Vikram
> >> >Cc: linux-omap@vger.kernel.org
> >> >Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue
> >> >
> >> >Tony Lindgren <tony@atomide.com> writes:
> >> >
> >> >> This patch has been applied to the linux-omap
> >> >> by youw fwiendly patch wobot.
> >> >>
> >> >> Branch in linux-omap: omap-fixes
> >> >>
> >> >> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954
> >> >>
> >> >> PatchWorks
> >> >> http://patchwork.kernel.org/patch/29668/
> >> >>
> >> >> Git (Likely to change, and takes a while to get mirrored)
> >> >> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
> >> >2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954
> >> >
> >> >Sorry, I didn't get to this beforethe merge, but $SUBJECT for this
> >> >patch is wrong and not terribly helpful.  It refers to the symptom, bu
> >> >tnot the root cause.
> >> >
> >> >It should be something like:
> >> >
> >> >OMAP3: Zoom2: pass IRQ triggering flags for serial driver
> >> 
> >> Yes that should have been the subject and 
> >> is put that way for the 8250 driver:
> >> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach
> >> 
> >> It's learning for next time.
> >
> > Will revert. I guess we now need two 8250 patches upstream? One for the
> > omap register define, and one for the interrupt flags?
> 
> Yes, both of these are pending on LKML, and still no word from Alan.
> 
> To get it upstream, I defined wake-up register locally in
> mach-omap2/serial.c until the patch gets merged, but for the interrupt
> flags there isn't an easy solution.

OK, so it's the irqflags that we still need. I took a look and commented that
we should rather have irqflags field in struct uart_port instead.. So let's
just wait and see until we have some ack from Alan.

Regards,

Tony