From: Hans de Goede <j.w.r.degoede@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Hans de Goede <hdegoede@redhat.com>
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister
Date: Thu, 19 Oct 2017 15:14:50 +0200 [thread overview]
Message-ID: <12453449-8928-9981-0909-dbb2a65664c1@gmail.com> (raw)
In-Reply-To: <f1c4b598-42ca-4873-2e6d-71cea967d765@gmail.com>
Hi,
On 19-10-17 15:04, Hans de Goede wrote:
> Hi,
>
> On 19-10-17 13:50, Patchwork wrote:
>> == Series Details ==
>>
>> Series: series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister
>> URL : https://patchwork.freedesktop.org/series/32288/
>> State : failure
>
> This seems to be a random failure getting assigned to this series, this series
> only affects systems which have a PUNIT mutex as detected by:
> drivers/i2c/busses/i2c-designware-baytrail.c
>
> Which I'm pretty sure this system does not have.
Looking closer, this series does slightly modify the timing of
intel_uncore_resume_early(), as that now takes and releases
the mutex behind iosf_mbi_punit_acquire(); twice rather then
just once. I could extend the first patch in the series
to also add an unlocked variant of iosf_mbi_register_pmic_bus_access_notifier
and only take the lock once, from a race pov this is not
necessary, but it would save having to take the lock
twice.
I still think there is another root cause to the problem
the CI caught though, the problem is the
GEM_BUG_ON in drivers/gpu/drm/i915/intel_lrc.c at
line 782, which has a big comment on top on why
calling intel_runtime_pm_get() is not necessary there
maybe there is a path where it is actually necessary
and we are hitting a race here ?
Regards,
Hans
> Regards,
>
> Hans
>
>
>
>
>>
>> == Summary ==
>>
>> Series 32288v1 series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister
>> https://patchwork.freedesktop.org/api/1.0/series/32288/revisions/1/mbox/
>>
>> Test kms_pipe_crc_basic:
>> Subgroup suspend-read-crc-pipe-a:
>> pass -> INCOMPLETE (fi-skl-6700hq)
>>
>> fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s
>> fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:448s
>> fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:371s
>> fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:540s
>> fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:262s
>> fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:508s
>> fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:503s
>> fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:493s
>> fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:478s
>> fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:557s
>> fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:416s
>> fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:251s
>> fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:582s
>> fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:444s
>> fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:429s
>> fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:429s
>> fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s
>> fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:457s
>> fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:486s
>> fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:575s
>> fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
>> fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:579s
>> fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:543s
>> fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s
>> fi-skl-6700hq total:245 pass:220 dwarn:0 dfail:0 fail:0 skip:24
>> fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:518s
>> fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:500s
>> fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:456s
>> fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:564s
>> fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:419s
>>
>> 93f001963c9915c52b5ad84500075d231e008ced drm-tip: 2017y-10m-19d-10h-52m-17s UTC integration manifest
>> 2e0038ee0daa drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()
>> ef37838a00fd x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister
>>
>> == Logs ==
>>
>> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6101/
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-19 13:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 11:16 [PATCH v5 1/2] x86 / i915 iosf_mbi / PMIC bus access fixes Hans de Goede
2017-10-19 11:16 ` Hans de Goede
2017-10-19 11:16 ` [PATCH v5 1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister Hans de Goede
2017-10-19 11:16 ` Hans de Goede
2017-10-19 11:16 ` [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset() Hans de Goede
2017-10-19 11:16 ` Hans de Goede
2017-10-31 9:50 ` Ingo Molnar
2017-10-31 9:50 ` Ingo Molnar
2017-10-31 10:04 ` [Intel-gfx] " Daniel Vetter
2017-10-31 10:04 ` Daniel Vetter
2017-10-31 11:54 ` Ingo Molnar
2017-10-31 10:10 ` Hans de Goede
2017-10-31 10:10 ` Hans de Goede
2017-10-19 11:50 ` ✗ Fi.CI.BAT: failure for series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister Patchwork
2017-10-19 13:04 ` Hans de Goede
2017-10-19 13:14 ` Hans de Goede [this message]
2017-10-30 13:11 ` [PATCH v5 1/2] x86 / i915 iosf_mbi / PMIC bus access fixes Hans de Goede
2017-10-30 13:11 ` Hans de Goede
2017-11-03 18:03 ` ✓ Fi.CI.BAT: success for series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked PMIC bus access notifier unregister Patchwork
2017-11-03 19:06 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-08 12:37 ` ✓ Fi.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12453449-8928-9981-0909-dbb2a65664c1@gmail.com \
--to=j.w.r.degoede@gmail.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.