* [PATCH -tip] x86: mm/init.c declare check_efer() before it get used
@ 2009-06-20 10:35 Jaswinder Singh Rajput
0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 10:35 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar, x86 maintainers, LKML
check_efer() is already declared in asm/proto.h, so include it before using it.
Also fix sparse warning :
CHECK arch/x86/mm/init.c
arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 1043590..d31f9e7 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>
DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -tip] x86: mm/init.c declare check_efer() before it get used
@ 2009-07-01 14:24 Jaswinder Singh Rajput
0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-01 14:24 UTC (permalink / raw)
To: Ingo Molnar, Andrew Morton, x86 maintainers, LKML
This sparse warning:
arch/x86/mm/init.c:83:16: warning: symbol 'check_efer' was not declared. Should it be static?
triggers because check_efer() is not decalared before using it.
asm/proto.h includes the declaration of check_efer(),
so including asm/proto.h to fix that - this also address the sparse warning.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 47ce9a2..0607119 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>
DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -tip] x86: mm/init.c declare check_efer() before it get used
@ 2009-05-13 22:33 Jaswinder Singh Rajput
0 siblings, 0 replies; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-05-13 22:33 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, Andrew Morton, LKML
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index 1043590..d31f9e7 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -12,6 +12,7 @@
#include <asm/system.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
+#include <asm/proto.h>
DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-01 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-20 10:35 [PATCH -tip] x86: mm/init.c declare check_efer() before it get used Jaswinder Singh Rajput
-- strict thread matches above, loose matches on Subject: below --
2009-07-01 14:24 Jaswinder Singh Rajput
2009-05-13 22:33 Jaswinder Singh Rajput
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.