sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Guennadi Liakhovetski]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 772 bytes --]

Ok, first attempt to forward this to scsi was wrong, as pointed out by 
Matthew Wilcox this does indeed look like an interrupt problem - no 
interrupts drom SCSI, IDE, keyboar. Might be a known problem, I guess. In 
any case, I think, the OP would be grateful for any hints.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

---------- Forwarded message ----------
Date: Sat, 13 Jun 2009 16:22:07 +0200
From: Laszlo Fekete <blackluck@ktk.bme.hu>
To: debian-powerpc@lists.debian.org
Subject: sym scsi driver problem with 2.6.26 or newer debian kernel on p610
Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
Resent-From: debian-powerpc@lists.debian.org

This is a multi-part message in MIME format.

[-- Attachment #2: Type: TEXT/PLAIN, Size: 468 bytes --]

Hello!





Pls help me with sym scsi driver problem.



I have Ibm P610 (and tested it on P630 and P640 too), installed debian

etch and upgraded to lenny.



But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi

bus scan.





Whats the problem with it, or how can I fix this?





I attach the output from minicom with 2.6.29, 2.6.26, and the working

2.6.24 kernel booting.





Thank you very much!




[-- Attachment #3: Type: APPLICATION/CAP, Size: 69688 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Laszlo Fekete]

Hello!

I'm sorry about the annoyances, but I'd welcome all ideas, suggestions 
to see what needs to be done or should be tested for the solution.

Thank you very much!

Guennadi Liakhovetski wrote:
> Ok, first attempt to forward this to scsi was wrong, as pointed out by 
> Matthew Wilcox this does indeed look like an interrupt problem - no 
> interrupts drom SCSI, IDE, keyboar. Might be a known problem, I guess. In 
> any case, I think, the OP would be grateful for any hints.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
> ---------- Forwarded message ----------
> Date: Sat, 13 Jun 2009 16:22:07 +0200
> From: Laszlo Fekete <blackluck@ktk.bme.hu>
> To: debian-powerpc@lists.debian.org
> Subject: sym scsi driver problem with 2.6.26 or newer debian kernel on p610
> Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
> Resent-From: debian-powerpc@lists.debian.org
>
> This is a multi-part message in MIME format.
> ------------------------------------------------------------------------
>
> Hello!
>
>
>
>
>
> Pls help me with sym scsi driver problem.
>
>
>
> I have Ibm P610 (and tested it on P630 and P640 too), installed debian
>
> etch and upgraded to lenny.
>
>
>
> But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
>
> bus scan.
>
>
>
>
>
> Whats the problem with it, or how can I fix this?
>
>
>
>
>
> I attach the output from minicom with 2.6.29, 2.6.26, and the working
>
> 2.6.24 kernel booting.
>
>
>
>
>
> Thank you very much!
>
>
>   

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Laszlo Fekete]

Hello!

Is there any idea for the solution?

Thanks: blackluck

Laszlo Fekete wrote:
> Hello!
>
> I'm sorry about the annoyances, but I'd welcome all ideas, suggestions 
> to see what needs to be done or should be tested for the solution.
>
> Thank you very much!
>
> Guennadi Liakhovetski wrote:
>> Ok, first attempt to forward this to scsi was wrong, as pointed out 
>> by Matthew Wilcox this does indeed look like an interrupt problem - 
>> no interrupts drom SCSI, IDE, keyboar. Might be a known problem, I 
>> guess. In any case, I think, the OP would be grateful for any hints.
>>
>> Thanks
>> Guennadi
>> ---
>> Guennadi Liakhovetski, Ph.D.
>> Freelance Open-Source Software Developer
>> http://www.open-technology.de/
>>
>> ---------- Forwarded message ----------
>> Date: Sat, 13 Jun 2009 16:22:07 +0200
>> From: Laszlo Fekete <blackluck@ktk.bme.hu>
>> To: debian-powerpc@lists.debian.org
>> Subject: sym scsi driver problem with 2.6.26 or newer debian kernel 
>> on p610
>> Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
>> Resent-From: debian-powerpc@lists.debian.org
>>
>> This is a multi-part message in MIME format.
>> ------------------------------------------------------------------------
>>
>> Hello!
>>
>>
>>
>>
>>
>> Pls help me with sym scsi driver problem.
>>
>>
>>
>> I have Ibm P610 (and tested it on P630 and P640 too), installed debian
>>
>> etch and upgraded to lenny.
>>
>>
>>
>> But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
>>
>> bus scan.
>>
>>
>>
>>
>>
>> Whats the problem with it, or how can I fix this?
>>
>>
>>
>>
>>
>> I attach the output from minicom with 2.6.29, 2.6.26, and the working
>>
>> 2.6.24 kernel booting.
>>
>>
>>
>>
>>
>> Thank you very much!
>>
>>
>>   
>
>

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Mon, 2009-06-22 at 11:10 +0200, Laszlo Fekete wrote:
> Hello!
> 
> Is there any idea for the solution?

Hard to tell yet. Looks indeed like something is wrong with the
interrupt controller.

Any chance you can bisect that ? I'll also have a look on my side,
it's definitely not something obvious.

Cheers,
Ben.

> Thanks: blackluck
> 
> Laszlo Fekete wrote:
> > Hello!
> >
> > I'm sorry about the annoyances, but I'd welcome all ideas, suggestions 
> > to see what needs to be done or should be tested for the solution.
> >
> > Thank you very much!
> >
> > Guennadi Liakhovetski wrote:
> >> Ok, first attempt to forward this to scsi was wrong, as pointed out 
> >> by Matthew Wilcox this does indeed look like an interrupt problem - 
> >> no interrupts drom SCSI, IDE, keyboar. Might be a known problem, I 
> >> guess. In any case, I think, the OP would be grateful for any hints.
> >>
> >> Thanks
> >> Guennadi
> >> ---
> >> Guennadi Liakhovetski, Ph.D.
> >> Freelance Open-Source Software Developer
> >> http://www.open-technology.de/
> >>
> >> ---------- Forwarded message ----------
> >> Date: Sat, 13 Jun 2009 16:22:07 +0200
> >> From: Laszlo Fekete <blackluck@ktk.bme.hu>
> >> To: debian-powerpc@lists.debian.org
> >> Subject: sym scsi driver problem with 2.6.26 or newer debian kernel 
> >> on p610
> >> Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
> >> Resent-From: debian-powerpc@lists.debian.org
> >>
> >> This is a multi-part message in MIME format.
> >> ------------------------------------------------------------------------
> >>
> >> Hello!
> >>
> >>
> >>
> >>
> >>
> >> Pls help me with sym scsi driver problem.
> >>
> >>
> >>
> >> I have Ibm P610 (and tested it on P630 and P640 too), installed debian
> >>
> >> etch and upgraded to lenny.
> >>
> >>
> >>
> >> But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
> >>
> >> bus scan.
> >>
> >>
> >>
> >>
> >>
> >> Whats the problem with it, or how can I fix this?
> >>
> >>
> >>
> >>
> >>
> >> I attach the output from minicom with 2.6.29, 2.6.26, and the working
> >>
> >> 2.6.24 kernel booting.
> >>
> >>
> >>
> >>
> >>
> >> Thank you very much!
> >>
> >>
> >>   
> >
> >
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Tue, 2009-06-23 at 11:18 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2009-06-22 at 11:10 +0200, Laszlo Fekete wrote:
> > Hello!
> > 
> > Is there any idea for the solution?
> 
> Hard to tell yet. Looks indeed like something is wrong with the
> interrupt controller.
> 
> Any chance you can bisect that ? I'll also have a look on my side,
> it's definitely not something obvious.

I tried on a POWER3 box I have here "IBM,7044-170" and things work fine
here with current upstream. (I suspect a much smaller machine).

I will really need an actual bisection here... In the meantime, I'll see
if I can get my hand on one of these machines here.

Cheers,
Ben.

> Cheers,
> Ben.
> 
> > Thanks: blackluck
> > 
> > Laszlo Fekete wrote:
> > > Hello!
> > >
> > > I'm sorry about the annoyances, but I'd welcome all ideas, suggestions 
> > > to see what needs to be done or should be tested for the solution.
> > >
> > > Thank you very much!
> > >
> > > Guennadi Liakhovetski wrote:
> > >> Ok, first attempt to forward this to scsi was wrong, as pointed out 
> > >> by Matthew Wilcox this does indeed look like an interrupt problem - 
> > >> no interrupts drom SCSI, IDE, keyboar. Might be a known problem, I 
> > >> guess. In any case, I think, the OP would be grateful for any hints.
> > >>
> > >> Thanks
> > >> Guennadi
> > >> ---
> > >> Guennadi Liakhovetski, Ph.D.
> > >> Freelance Open-Source Software Developer
> > >> http://www.open-technology.de/
> > >>
> > >> ---------- Forwarded message ----------
> > >> Date: Sat, 13 Jun 2009 16:22:07 +0200
> > >> From: Laszlo Fekete <blackluck@ktk.bme.hu>
> > >> To: debian-powerpc@lists.debian.org
> > >> Subject: sym scsi driver problem with 2.6.26 or newer debian kernel 
> > >> on p610
> > >> Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
> > >> Resent-From: debian-powerpc@lists.debian.org
> > >>
> > >> This is a multi-part message in MIME format.
> > >> ------------------------------------------------------------------------
> > >>
> > >> Hello!
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> Pls help me with sym scsi driver problem.
> > >>
> > >>
> > >>
> > >> I have Ibm P610 (and tested it on P630 and P640 too), installed debian
> > >>
> > >> etch and upgraded to lenny.
> > >>
> > >>
> > >>
> > >> But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
> > >>
> > >> bus scan.
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> Whats the problem with it, or how can I fix this?
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> I attach the output from minicom with 2.6.29, 2.6.26, and the working
> > >>
> > >> 2.6.24 kernel booting.
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> Thank you very much!
> > >>
> > >>
> > >>   
> > >
> > >
> > 
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

> I tried on a POWER3 box I have here "IBM,7044-170" and things work fine
> here with current upstream. (I suspect a much smaller machine).
> 
> I will really need an actual bisection here... In the meantime, I'll see
> if I can get my hand on one of these machines here.

Ok so I think we may have found it... looks like
CONFIG_MPIC_BROKEN_REGREAD is what breaks it which is enabled by PA-Semi
support in the .config.

Can you verify that disabling PA-Semi support removes that option from
your .config and that once removed, it works again ?

We don't know yet -why- it breaks it, still investigating.

Cheers,
Ben.

> Cheers,
> Ben.
> 
> > Cheers,
> > Ben.
> > 
> > > Thanks: blackluck
> > > 
> > > Laszlo Fekete wrote:
> > > > Hello!
> > > >
> > > > I'm sorry about the annoyances, but I'd welcome all ideas, suggestions 
> > > > to see what needs to be done or should be tested for the solution.
> > > >
> > > > Thank you very much!
> > > >
> > > > Guennadi Liakhovetski wrote:
> > > >> Ok, first attempt to forward this to scsi was wrong, as pointed out 
> > > >> by Matthew Wilcox this does indeed look like an interrupt problem - 
> > > >> no interrupts drom SCSI, IDE, keyboar. Might be a known problem, I 
> > > >> guess. In any case, I think, the OP would be grateful for any hints.
> > > >>
> > > >> Thanks
> > > >> Guennadi
> > > >> ---
> > > >> Guennadi Liakhovetski, Ph.D.
> > > >> Freelance Open-Source Software Developer
> > > >> http://www.open-technology.de/
> > > >>
> > > >> ---------- Forwarded message ----------
> > > >> Date: Sat, 13 Jun 2009 16:22:07 +0200
> > > >> From: Laszlo Fekete <blackluck@ktk.bme.hu>
> > > >> To: debian-powerpc@lists.debian.org
> > > >> Subject: sym scsi driver problem with 2.6.26 or newer debian kernel 
> > > >> on p610
> > > >> Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
> > > >> Resent-From: debian-powerpc@lists.debian.org
> > > >>
> > > >> This is a multi-part message in MIME format.
> > > >> ------------------------------------------------------------------------
> > > >>
> > > >> Hello!
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> Pls help me with sym scsi driver problem.
> > > >>
> > > >>
> > > >>
> > > >> I have Ibm P610 (and tested it on P630 and P640 too), installed debian
> > > >>
> > > >> etch and upgraded to lenny.
> > > >>
> > > >>
> > > >>
> > > >> But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
> > > >>
> > > >> bus scan.
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> Whats the problem with it, or how can I fix this?
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> I attach the output from minicom with 2.6.29, 2.6.26, and the working
> > > >>
> > > >> 2.6.24 kernel booting.
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> Thank you very much!
> > > >>
> > > >>
> > > >>   
> > > >
> > > >
> > > 
> > > _______________________________________________
> > > Linuxppc-dev mailing list
> > > Linuxppc-dev@lists.ozlabs.org
> > > https://lists.ozlabs.org/listinfo/linuxppc-dev
> > 
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Wed, 2009-06-24 at 07:57 +1000, Benjamin Herrenschmidt wrote:
> > I tried on a POWER3 box I have here "IBM,7044-170" and things work fine
> > here with current upstream. (I suspect a much smaller machine).
> > 
> > I will really need an actual bisection here... In the meantime, I'll see
> > if I can get my hand on one of these machines here.
> 
> Ok so I think we may have found it... looks like
> CONFIG_MPIC_BROKEN_REGREAD is what breaks it which is enabled by PA-Semi
> support in the .config.
> 
> Can you verify that disabling PA-Semi support removes that option from
> your .config and that once removed, it works again ?
> 
> We don't know yet -why- it breaks it, still investigating.

Do the following patch also fix it ?

Index: linux-work/arch/powerpc/sysdev/mpic.c
===================================================================
--- linux-work.orig/arch/powerpc/sysdev/mpic.c	2009-06-24 09:24:51.000000000 +1000
+++ linux-work/arch/powerpc/sysdev/mpic.c	2009-06-24 09:26:45.000000000 +1000
@@ -230,14 +230,16 @@ static inline u32 _mpic_irq_read(struct 
 {
 	unsigned int	isu = src_no >> mpic->isu_shift;
 	unsigned int	idx = src_no & mpic->isu_mask;
+	unsigned int	val;
 
+	val = _mpic_read(mpic->reg_type, &mpic->isus[isu],
+			 reg + (idx * MPIC_INFO(IRQ_STRIDE)));	
 #ifdef CONFIG_MPIC_BROKEN_REGREAD
 	if (reg == 0)
-		return mpic->isu_reg0_shadow[idx];
-	else
+		val = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
+			mpic->isu_reg0_shadow[idx];
 #endif
-		return _mpic_read(mpic->reg_type, &mpic->isus[isu],
-				  reg + (idx * MPIC_INFO(IRQ_STRIDE)));
+	return val;
 }
 
 static inline void _mpic_irq_write(struct mpic *mpic, unsigned int src_no,
@@ -251,7 +253,8 @@ static inline void _mpic_irq_write(struc
 
 #ifdef CONFIG_MPIC_BROKEN_REGREAD
 	if (reg == 0)
-		mpic->isu_reg0_shadow[idx] = value;
+		mpic->isu_reg0_shadow[idx] =
+			value & ~(MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY);
 #endif
 }
 

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On Wed, 2009-06-24 at 09:29 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2009-06-24 at 07:57 +1000, Benjamin Herrenschmidt wrote:
> > > I tried on a POWER3 box I have here "IBM,7044-170" and things work fine
> > > here with current upstream. (I suspect a much smaller machine).
> > > 
> > > I will really need an actual bisection here... In the meantime, I'll see
> > > if I can get my hand on one of these machines here.
> > 
> > Ok so I think we may have found it... looks like
> > CONFIG_MPIC_BROKEN_REGREAD is what breaks it which is enabled by PA-Semi
> > support in the .config.
> > 
> > Can you verify that disabling PA-Semi support removes that option from
> > your .config and that once removed, it works again ?
> > 
> > We don't know yet -why- it breaks it, still investigating.
> 
> Do the following patch also fix it ?

Doesn't fix my machine :/

cheers


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Wed, 2009-06-24 at 15:53 +1000, Michael Ellerman wrote:
> Doesn't fix my machine :/
> 
That doesn't make sense ... What if you remove the bit inside the ifdef
CONFIG_MPIC_BROKEN_REGREAD in _mpic_read() ?

If that makes a difference, then it would be interesting to add a printk
in there that prints what the original value "val" is and what we have
in the shadow...

Cheers,
Ben.

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]

On Wed, 2009-06-24 at 15:56 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2009-06-24 at 15:53 +1000, Michael Ellerman wrote:
> > Doesn't fix my machine :/
> > 
> That doesn't make sense ... What if you remove the bit inside the ifdef
> CONFIG_MPIC_BROKEN_REGREAD in _mpic_read() ?
> 
> If that makes a difference, then it would be interesting to add a printk
> in there that prints what the original value "val" is and what we have
> in the shadow...

With this patch it boots:

diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index 2353adc..fc17289 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -231,13 +231,16 @@ static inline u32 _mpic_irq_read(struct mpic *mpic, unsign
        unsigned int    isu = src_no >> mpic->isu_shift;
        unsigned int    idx = src_no & mpic->isu_mask;
        unsigned int    val;
+       unsigned int    shadow;
 
        val = _mpic_read(mpic->reg_type, &mpic->isus[isu],
                         reg + (idx * MPIC_INFO(IRQ_STRIDE)));  
 #ifdef CONFIG_MPIC_BROKEN_REGREAD
-       if (reg == 0)
-               val = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
+       if (reg == 0) {
+               shadow = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
                        mpic->isu_reg0_shadow[idx];
+               printk("%s: val 0x%x shadow 0x%x\n", __func__, val, shadow);
+       }
 #endif
        return val;
 }


And I see:

sym53c8xx 0000:00:0c.0: enabling device (0140 -> 0143)
sym0: <896> rev 0x7 at pci 0000:00:0c.0 irq 17
sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
_mpic_irq_read: val 0x80480004 shadow 0x80080014
_mpic_irq_read: val 0x480004 shadow 0x480004



cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Wed, 2009-06-24 at 16:19 +1000, Michael Ellerman wrote:

> sym53c8xx 0000:00:0c.0: enabling device (0140 -> 0143)
> sym0: <896> rev 0x7 at pci 0000:00:0c.0 irq 17
> sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
> _mpic_irq_read: val 0x80480004 shadow 0x80080014
> _mpic_irq_read: val 0x480004 shadow 0x480004

Strange.. it's like we read a different vector and polarity than
what is in the cache. Oh well, I'll have a closer look tomorrow
in the office.

Ben.

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Laszlo Fekete]

[-- Attachment #1.1: Type: text/plain, Size: 2032 bytes --]

Hello!

Thank you very much, this patch works me too.

Maybe this patch will be in the debian kernel someday?

Thank you: blackluck

Michael Ellerman wrote:
> On Wed, 2009-06-24 at 15:56 +1000, Benjamin Herrenschmidt wrote:
>   
>> On Wed, 2009-06-24 at 15:53 +1000, Michael Ellerman wrote:
>>     
>>> Doesn't fix my machine :/
>>>
>>>       
>> That doesn't make sense ... What if you remove the bit inside the ifdef
>> CONFIG_MPIC_BROKEN_REGREAD in _mpic_read() ?
>>
>> If that makes a difference, then it would be interesting to add a printk
>> in there that prints what the original value "val" is and what we have
>> in the shadow...
>>     
>
> With this patch it boots:
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index 2353adc..fc17289 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -231,13 +231,16 @@ static inline u32 _mpic_irq_read(struct mpic *mpic, unsign
>         unsigned int    isu = src_no >> mpic->isu_shift;
>         unsigned int    idx = src_no & mpic->isu_mask;
>         unsigned int    val;
> +       unsigned int    shadow;
>  
>         val = _mpic_read(mpic->reg_type, &mpic->isus[isu],
>                          reg + (idx * MPIC_INFO(IRQ_STRIDE)));  
>  #ifdef CONFIG_MPIC_BROKEN_REGREAD
> -       if (reg == 0)
> -               val = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
> +       if (reg == 0) {
> +               shadow = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
>                         mpic->isu_reg0_shadow[idx];
> +               printk("%s: val 0x%x shadow 0x%x\n", __func__, val, shadow);
> +       }
>  #endif
>         return val;
>  }
>
>
> And I see:
>
> sym53c8xx 0000:00:0c.0: enabling device (0140 -> 0143)
> sym0: <896> rev 0x7 at pci 0000:00:0c.0 irq 17
> sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
> _mpic_irq_read: val 0x80480004 shadow 0x80080014
> _mpic_irq_read: val 0x480004 shadow 0x480004
>
>
>
> cheers
>   

[-- Attachment #1.2: Type: text/html, Size: 2541 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Sat, 2009-06-27 at 19:46 +0200, Laszlo Fekete wrote:
> Hello!
> 
> Thank you very much, this patch works me too.
> 
> Maybe this patch will be in the debian kernel someday?

The patch isn't actually correct just yet :-) Michael will
be posting a proper one next week. It should be possible to
request its inclusion into debian separately, we'll probably
send it to stable@kernel.org as well.

Cheers,
Ben.

> Thank you: blackluck
> 
> Michael Ellerman wrote: 
> > On Wed, 2009-06-24 at 15:56 +1000, Benjamin Herrenschmidt wrote:
> >   
> > > On Wed, 2009-06-24 at 15:53 +1000, Michael Ellerman wrote:
> > >     
> > > > Doesn't fix my machine :/
> > > > 
> > > >       
> > > That doesn't make sense ... What if you remove the bit inside the ifdef
> > > CONFIG_MPIC_BROKEN_REGREAD in _mpic_read() ?
> > > 
> > > If that makes a difference, then it would be interesting to add a printk
> > > in there that prints what the original value "val" is and what we have
> > > in the shadow...
> > >     
> > 
> > With this patch it boots:
> > 
> > diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> > index 2353adc..fc17289 100644
> > --- a/arch/powerpc/sysdev/mpic.c
> > +++ b/arch/powerpc/sysdev/mpic.c
> > @@ -231,13 +231,16 @@ static inline u32 _mpic_irq_read(struct mpic *mpic, unsign
> >         unsigned int    isu = src_no >> mpic->isu_shift;
> >         unsigned int    idx = src_no & mpic->isu_mask;
> >         unsigned int    val;
> > +       unsigned int    shadow;
> >  
> >         val = _mpic_read(mpic->reg_type, &mpic->isus[isu],
> >                          reg + (idx * MPIC_INFO(IRQ_STRIDE)));  
> >  #ifdef CONFIG_MPIC_BROKEN_REGREAD
> > -       if (reg == 0)
> > -               val = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
> > +       if (reg == 0) {
> > +               shadow = (val & (MPIC_VECPRI_MASK | MPIC_VECPRI_ACTIVITY)) |
> >                         mpic->isu_reg0_shadow[idx];
> > +               printk("%s: val 0x%x shadow 0x%x\n", __func__, val, shadow);
> > +       }
> >  #endif
> >         return val;
> >  }
> > 
> > 
> > And I see:
> > 
> > sym53c8xx 0000:00:0c.0: enabling device (0140 -> 0143)
> > sym0: <896> rev 0x7 at pci 0000:00:0c.0 irq 17
> > sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
> > _mpic_irq_read: val 0x80480004 shadow 0x80080014
> > _mpic_irq_read: val 0x480004 shadow 0x480004
> > 
> > 
> > 
> > cheers
> >   

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

On Sun, 2009-06-28 at 08:54 +1000, Benjamin Herrenschmidt wrote:
> On Sat, 2009-06-27 at 19:46 +0200, Laszlo Fekete wrote:
> > Hello!
> > 
> > Thank you very much, this patch works me too.
> > 
> > Maybe this patch will be in the debian kernel someday?
> 
> The patch isn't actually correct just yet :-) Michael will
> be posting a proper one next week.

.. or the week after:

http://patchwork.ozlabs.org/patch/29475/

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Benjamin Herrenschmidt]

On Sun, 2009-06-14 at 11:10 +0200, Guennadi Liakhovetski wrote:
> P610 (and tested it on P630 and P640 too)

Also, send me a tarball of /proc/device-tree please.

Cheers,
Ben.

sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Guennadi Liakhovetski]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 556 bytes --]

Forwarding to the scsi mailing list and driver maintainer.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

---------- Forwarded message ----------
Date: Sat, 13 Jun 2009 16:22:07 +0200
From: Laszlo Fekete <blackluck@ktk.bme.hu>
To: debian-powerpc@lists.debian.org
Subject: sym scsi driver problem with 2.6.26 or newer debian kernel on p610
Resent-Date: Sat, 13 Jun 2009 14:29:55 +0000 (UTC)
Resent-From: debian-powerpc@lists.debian.org

This is a multi-part message in MIME format.

[-- Attachment #2: Type: text/plain, Size: 426 bytes --]

Hello!


Pls help me with sym scsi driver problem.

I have Ibm P610 (and tested it on P630 and P640 too), installed debian
etch and upgraded to lenny.

But with 2.6.26 or newer kernel it's not booting, it's hang on sym scsi
bus scan.


Whats the problem with it, or how can I fix this?


I attach the output from minicom with 2.6.29, 2.6.26, and the working
2.6.24 kernel booting.


Thank you very much!


[-- Attachment #3: minicom.cap --]
[-- Type: application/cap, Size: 69688 bytes --]

Re: sym scsi driver problem with 2.6.26 or newer debian kernel on p610 (fwd)

[Matthew Wilcox]

On Sat, Jun 13, 2009 at 09:49:31PM +0200, Guennadi Liakhovetski wrote:
> Forwarding to the scsi mailing list and driver maintainer.

It's an interrupt problem.  Talk to the powerpc people, not me.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."