All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/7] MAINTAINERS: cleanups
@ 2009-07-08  5:55 Joe Perches
  2009-07-08  5:55 ` [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly Joe Perches
                   ` (6 more replies)
  0 siblings, 7 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

A few more cleanups to MAINTAINERS

Joe Perches (7):
  MAINTAINERS: IA64 - pair P:/M: entries properly
  MAINTAINERS: Remove ivtv-user lists, add CX18 url
  MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly
  MAINTAINERS: Use tabs in ACER ASPIRE ONE
  MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  MAINTAINERS: Move ARPD to CREDITS
  MAINTAINERS: Update KERNEL JANITORS

 CREDITS     |    3 +++
 MAINTAINERS |   33 ++++++++++-----------------------
 2 files changed, 13 insertions(+), 23 deletions(-)


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  5:55 ` [PATCH 2/7] MAINTAINERS: Remove ivtv-user lists, add CX18 url Joe Perches
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 381190c..3fff20f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2851,8 +2851,8 @@ S:	Maintained
 
 IA64 (Itanium) PLATFORM
 P:	Tony Luck
-P:	Fenghua Yu
 M:	tony.luck@intel.com
+P:	Fenghua Yu
 M:	fenghua.yu@intel.com
 L:	linux-ia64@vger.kernel.org
 W:	http://www.ia64-linux.org/
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/7] MAINTAINERS: Remove ivtv-user lists, add CX18 url
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
  2009-07-08  5:55 ` [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  5:55 ` [PATCH 3/7] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly Joe Perches
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3fff20f..bfb4c43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1721,10 +1721,10 @@ M:	hverkuil@xs4all.nl
 P:	Andy Walls
 M:	awalls@radix.net
 L:	ivtv-devel@ivtvdriver.org
-L:	ivtv-users@ivtvdriver.org
 L:	linux-media@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
 W:	http://linuxtv.org
+W:	http://www.ivtvdriver.org/index.php/Cx18
 S:	Maintained
 F:	Documentation/video4linux/cx18.txt
 F:	drivers/media/video/cx18/
@@ -3276,7 +3276,6 @@ IVTV VIDEO4LINUX DRIVER
 P:	Hans Verkuil
 M:	hverkuil@xs4all.nl
 L:	ivtv-devel@ivtvdriver.org
-L:	ivtv-users@ivtvdriver.org
 L:	linux-media@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
 W:	http://www.ivtvdriver.org
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/7] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
  2009-07-08  5:55 ` [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly Joe Perches
  2009-07-08  5:55 ` [PATCH 2/7] MAINTAINERS: Remove ivtv-user lists, add CX18 url Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  5:55 ` [PATCH 4/7] MAINTAINERS: Use tabs in ACER ASPIRE ONE Joe Perches
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index bfb4c43..888996d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4810,8 +4810,8 @@ F:	drivers/net/qla3xxx.*
 
 QLOGIC QLGE 10Gb ETHERNET DRIVER
 P:	Ron Mercer
-M:	linux-driver@qlogic.com
 M:	ron.mercer@qlogic.com
+M:	linux-driver@qlogic.com
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	drivers/net/qlge/
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/7] MAINTAINERS: Use tabs in ACER ASPIRE ONE
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
                   ` (2 preceding siblings ...)
  2009-07-08  5:55 ` [PATCH 3/7] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  5:55 ` [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org Joe Perches
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 888996d..4da8c4d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -231,11 +231,11 @@ S:	Maintained
 F:	drivers/net/acenic*
 
 ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER
-P: Peter Feuerer
-M: peter@piie.net
-W: http://piie.net/?section=acerhdf
-S: Maintained
-F: drivers/platform/x86/acerhdf.c
+P:	Peter Feuerer
+M:	peter@piie.net
+W:	http://piie.net/?section=acerhdf
+S:	Maintained
+F:	drivers/platform/x86/acerhdf.c
 
 ACER WMI LAPTOP EXTRAS
 P:	Carlos Corbacho
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
                   ` (3 preceding siblings ...)
  2009-07-08  5:55 ` [PATCH 4/7] MAINTAINERS: Use tabs in ACER ASPIRE ONE Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  6:32   ` Pekka Enberg
  2009-07-08  5:55 ` [PATCH 6/7] MAINTAINERS: Move ARPD to CREDITS Joe Perches
  2009-07-08  5:55 ` [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS Joe Perches
  6 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

from sections that should not have them.

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4da8c4d..5628b0a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2197,7 +2197,6 @@ F:	drivers/scsi/lpfc/
 ENE CB710 FLASH CARD READER DRIVER
 P:	Michał Mirosław
 M:	mirq-linux@rere.qmqm.pl
-L:	linux-kernel@vger.kernel.org
 S:	Maintained
 F:	drivers/misc/cb710/
 F:	drivers/mmc/host/cb710-mmc.*
@@ -3473,13 +3472,11 @@ P:	Vegard Nossum
 M:	vegardno@ifi.uio.no
 P	Pekka Enberg
 M:	penberg@cs.helsinki.fi
-L:	linux-kernel@vger.kernel.org
 S:	Maintained
 
 KMEMLEAK
 P:	Catalin Marinas
 M:	catalin.marinas@arm.com
-L:	linux-kernel@vger.kernel.org
 S:	Maintained
 F:	Documentation/kmemleak.txt
 F:	include/linux/kmemleak.h
@@ -4298,7 +4295,6 @@ F:	drivers/video/omap/
 OMAP MMC SUPPORT
 P:	Jarkko Lavinen
 M:	jarkko.lavinen@nokia.com
-L:	linux-kernel@vger.kernel.org
 L:	linux-omap@vger.kernel.org
 S:	Maintained
 F:	drivers/mmc/host/*omap*
@@ -4577,7 +4573,6 @@ P:	Paul Mackerras
 M:	paulus@samba.org
 P:	Ingo Molnar
 M:	mingo@elte.hu
-L:	linux-kernel@vger.kernel.org
 S:	Supported
 
 PERSONALITY HANDLING
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 6/7] MAINTAINERS: Move ARPD to CREDITS
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
                   ` (4 preceding siblings ...)
  2009-07-08  5:55 ` [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-08  5:55 ` [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS Joe Perches
  6 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Jonathan Layes is hard to find.

Signed-off-by: Joe Perches <joe@perches.com>
---
 CREDITS     |    3 +++
 MAINTAINERS |    6 ------
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/CREDITS b/CREDITS
index 2b88fb3..af93191 100644
--- a/CREDITS
+++ b/CREDITS
@@ -2006,6 +2006,9 @@ E: paul@laufernet.com
 D: Soundblaster driver fixes, ISAPnP quirk
 S: California, USA
 
+N: Jonathan Layes
+D: ARPD support
+
 N: Tom Lees
 E: tom@lpsg.demon.co.uk
 W: http://www.lpsg.demon.co.uk/
diff --git a/MAINTAINERS b/MAINTAINERS
index 5628b0a..ef07f59 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -951,12 +951,6 @@ W:	http://www.arm.linux.org.uk/
 S:	Maintained
 F:	arch/arm/vfp/
 
-ARPD SUPPORT
-P:	Jonathan Layes
-L:	netdev@vger.kernel.org
-S:	Maintained
-F:	net/ipv4/arp.c
-
 ASUS ACPI EXTRAS DRIVER
 P:	Corentin Chary
 M:	corentincj@iksaif.net
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS
  2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
                   ` (5 preceding siblings ...)
  2009-07-08  5:55 ` [PATCH 6/7] MAINTAINERS: Move ARPD to CREDITS Joe Perches
@ 2009-07-08  5:55 ` Joe Perches
  2009-07-09  2:25   ` Randy Dunlap
  6 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-08  5:55 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ef07f59..73b4b02 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3366,10 +3366,9 @@ F:	Makefile
 F:	scripts/Makefile.*
 
 KERNEL JANITORS
-P:	Several
 L:	kernel-janitors@vger.kernel.org
-W:	http://www.kerneljanitors.org/
-S:	Maintained
+W:	http://janitor.kernelnewbies.org/
+S:	Odd fixes
 
 KERNEL NFSD, SUNRPC, AND LOCKD SERVERS
 P:	J. Bruce Fields
-- 
1.6.3.1.10.g659a0.dirty


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  5:55 ` [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org Joe Perches
@ 2009-07-08  6:32   ` Pekka Enberg
  2009-07-08  6:39     ` Joe Perches
  0 siblings, 1 reply; 23+ messages in thread
From: Pekka Enberg @ 2009-07-08  6:32 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Andrew Morton, Vegard Nossum

Hi Joe,

On Wed, Jul 8, 2009 at 8:55 AM, Joe Perches<joe@perches.com> wrote:
> from sections that should not have them.

What is that supposed to mean?

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  MAINTAINERS |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4da8c4d..5628b0a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3473,13 +3472,11 @@ P:      Vegard Nossum
>  M:     vegardno@ifi.uio.no
>  P      Pekka Enberg
>  M:     penberg@cs.helsinki.fi
> -L:     linux-kernel@vger.kernel.org
>  S:     Maintained

Why do you want to remove that? It's there to tell people that you're
_supposed_ to cc LKML for kmemcheck patches in contrast to subsystems
(e.g. networking) that want people to cc _their_ mailing list (keeping
LKML is optional). Hmmm?

                        Pekka

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:32   ` Pekka Enberg
@ 2009-07-08  6:39     ` Joe Perches
  2009-07-08  6:44       ` Pekka Enberg
  0 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-08  6:39 UTC (permalink / raw)
  To: Pekka Enberg; +Cc: linux-kernel, Andrew Morton, Vegard Nossum

On Wed, 2009-07-08 at 09:32 +0300, Pekka Enberg wrote:
> Hi Joe,

Hi Pekka.

> On Wed, Jul 8, 2009 at 8:55 AM, Joe Perches<joe@perches.com> wrote:
> > from sections that should not have them.
> What is that supposed to mean?

That there should be no sections that have LKML as a
list entry other than "everything".

A earlier commit, b5472cddbe2c41fd434592ecf3c5b81a551d5bea,
removed all the entries for LKML but "THE REST".
These removed entries have been added since that commit.

Having just a few sections show LKML as an entry
may lead people to think that LKML should not be
used as a CC entry unless it is specifically listed.

Documentation/SubmittingPatches already states that
LKML should be CC'd on all patches.

cheers, Joe


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:39     ` Joe Perches
@ 2009-07-08  6:44       ` Pekka Enberg
  2009-07-08  6:47         ` Joe Perches
  0 siblings, 1 reply; 23+ messages in thread
From: Pekka Enberg @ 2009-07-08  6:44 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Andrew Morton, Vegard Nossum

Hi Joe,

On Tue, 2009-07-07 at 23:39 -0700, Joe Perches wrote:
> > On Wed, Jul 8, 2009 at 8:55 AM, Joe Perches<joe@perches.com> wrote:
> > > from sections that should not have them.
> > What is that supposed to mean?
> 
> That there should be no sections that have LKML as a
> list entry other than "everything".
> 
> A earlier commit, b5472cddbe2c41fd434592ecf3c5b81a551d5bea,
> removed all the entries for LKML but "THE REST".
> These removed entries have been added since that commit.

OK, I don't agree, but as Andrew apparently thinks it's a good idea
because he merged the previous patch, there's no reason not to merge the
new one.

On Tue, 2009-07-07 at 23:39 -0700, Joe Perches wrote:
> Documentation/SubmittingPatches already states that
> LKML should be CC'd on all patches.

Maybe it does, but real world doesn't seem to agree with you here.

			Pekka


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:44       ` Pekka Enberg
@ 2009-07-08  6:47         ` Joe Perches
  2009-07-08  6:55           ` Pekka Enberg
  2009-07-09  9:30           ` Mark Brown
  0 siblings, 2 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-08  6:47 UTC (permalink / raw)
  To: Pekka Enberg; +Cc: linux-kernel, Andrew Morton, Vegard Nossum

On Wed, 2009-07-08 at 09:44 +0300, Pekka Enberg wrote:
> On Tue, 2009-07-07 at 23:39 -0700, Joe Perches wrote:
> > Documentation/SubmittingPatches already states that
> > LKML should be CC'd on all patches.
> 
> Maybe it does, but real world doesn't seem to agree with you here.

Well, if scripts/get_maintainer.pl gets used more often,
it would.

cheers, Joe


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:47         ` Joe Perches
@ 2009-07-08  6:55           ` Pekka Enberg
  2009-07-08 16:37             ` Maciej W. Rozycki
  2009-07-09  9:30           ` Mark Brown
  1 sibling, 1 reply; 23+ messages in thread
From: Pekka Enberg @ 2009-07-08  6:55 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Andrew Morton, Vegard Nossum

Hi Joe,

On Tue, 2009-07-07 at 23:39 -0700, Joe Perches wrote:
> > > Documentation/SubmittingPatches already states that
> > > LKML should be CC'd on all patches.

On Wed, 2009-07-08 at 09:44 +0300, Pekka Enberg wrote:
> > Maybe it does, but real world doesn't seem to agree with you here.

On Tue, 2009-07-07 at 23:47 -0700, Joe Perches wrote:
> Well, if scripts/get_maintainer.pl gets used more often,
> it would.

And kernel hackers could fly if they had wings.

Look, all I care is that people who send patches to subsystems I
maintain know what to CC. The get_maintainer.pl script is obviously
really helpful here but the fact is, it's _not_ mandatory to CC LKML for
all patches. So I worry that people will be confused and no list is CC'd
because other subsystems that have a separate mailing list have that in
MAINTAINERS.

But anyway, no need to argue about this, Andrew merged your first patch
so the second patch makes sense as well.

			Pekka


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:55           ` Pekka Enberg
@ 2009-07-08 16:37             ` Maciej W. Rozycki
  0 siblings, 0 replies; 23+ messages in thread
From: Maciej W. Rozycki @ 2009-07-08 16:37 UTC (permalink / raw)
  To: Pekka Enberg; +Cc: Joe Perches, linux-kernel, Andrew Morton, Vegard Nossum

On Wed, 8 Jul 2009, Pekka Enberg wrote:

> And kernel hackers could fly if they had wings.

 No need for wings -- enough thrust would suffice. ;)

  Maciej

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS
  2009-07-08  5:55 ` [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS Joe Perches
@ 2009-07-09  2:25   ` Randy Dunlap
  0 siblings, 0 replies; 23+ messages in thread
From: Randy Dunlap @ 2009-07-09  2:25 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Andrew Morton

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  MAINTAINERS |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef07f59..73b4b02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3366,10 +3366,9 @@ F:	Makefile
>  F:	scripts/Makefile.*
>  
>  KERNEL JANITORS
> -P:	Several
>  L:	kernel-janitors@vger.kernel.org
> -W:	http://www.kerneljanitors.org/
> -S:	Maintained
> +W:	http://janitor.kernelnewbies.org/
> +S:	Odd fixes
>  
>  KERNEL NFSD, SUNRPC, AND LOCKD SERVERS
>  P:	J. Bruce Fields

Alexey could comment on that, but I agree with it.

Acked-by: Randy Dunlap <rdunlap@xenotime.net>


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-08  6:47         ` Joe Perches
  2009-07-08  6:55           ` Pekka Enberg
@ 2009-07-09  9:30           ` Mark Brown
  2009-07-09 14:58             ` Joe Perches
  1 sibling, 1 reply; 23+ messages in thread
From: Mark Brown @ 2009-07-09  9:30 UTC (permalink / raw)
  To: Joe Perches; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Tue, Jul 07, 2009 at 11:47:08PM -0700, Joe Perches wrote:

> Well, if scripts/get_maintainer.pl gets used more often,
> it would.

FWIW I've noticed that get_maintainer.pl has a tendency to pick up
people it probably shouldn't when run on areas that have had few people
committing to them since it tends to pick up people who've done generic
cleanups but have no specific interest in that area of code.  I think a
heuristic based on filtering the git log based on the proportion of
commits that were done by each committer would help with many of these
cases.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-09  9:30           ` Mark Brown
@ 2009-07-09 14:58             ` Joe Perches
  2009-07-09 15:08               ` Mark Brown
  0 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-09 14:58 UTC (permalink / raw)
  To: Mark Brown; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Thu, 2009-07-09 at 10:30 +0100, Mark Brown wrote:
> FWIW I've noticed that get_maintainer.pl has a tendency to pick up
> people it probably shouldn't when run on areas that have had few people
> committing to them since it tends to pick up people who've done generic
> cleanups but have no specific interest in that area of code.  I think a
> heuristic based on filtering the git log based on the proportion of
> commits that were done by each committer would help with many of these
> cases.

Hi Mark.

git log "-by:" lines are already sorted by number of commits
before selecting maintainers.  It doesn't matter if the
line is acked-by:, Signed-off-by:, tested-by:, or
brown-paper-bagged-by:, any "by:" signature is used.

get_maintainers does:

    git log --since=${email_git_since} -- ${file} \
    	 | grep -Ei "^[-_ 	a-z]+by:.*\@.*$" \
         | cut -f2- -d":" | sort | uniq -c | sort -rn

There are a few existing options that could be used
to minimize cleanup style committers.

    --git => include recent git *-by: signers
    --git-min-signatures => number of signatures required (default: 1)
    --git-max-maintainers => maximum maintainers to add (default: 5)
    --git-since => git history to use (default: 1-year-ago)

Using --nogit lists just the entries in MAINTAINERS

Using --git-min-signatures=3 or so seems to minimize
the generic cleanups committers.

Using --git-max-maintainers=3 or so, for files with more
changes, seems also to minimize the generic cleanup committers

Using --git-since=6-months-ago reduces the history period

Using --stat on the commit log and weighting for things
for lines changed would probably not be good because generic
cleanups often change more of the code than real logic
changes.

I suppose when the number of committers returned by
the "git log | grep" is low, returning just the 
most frequent committers might be good.

Any suggestions on better heuristics?



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-09 14:58             ` Joe Perches
@ 2009-07-09 15:08               ` Mark Brown
  2009-07-09 19:35                 ` Joe Perches
  0 siblings, 1 reply; 23+ messages in thread
From: Mark Brown @ 2009-07-09 15:08 UTC (permalink / raw)
  To: Joe Perches; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Thu, Jul 09, 2009 at 07:58:56AM -0700, Joe Perches wrote:
> On Thu, 2009-07-09 at 10:30 +0100, Mark Brown wrote:

> > cleanups but have no specific interest in that area of code.  I think a
> > heuristic based on filtering the git log based on the proportion of
> > commits that were done by each committer would help with many of these
> > cases.

> git log "-by:" lines are already sorted by number of commits
> before selecting maintainers.  It doesn't matter if the
> line is acked-by:, Signed-off-by:, tested-by:, or
> brown-paper-bagged-by:, any "by:" signature is used.

Yup, I'm aware of that.

> I suppose when the number of committers returned by
> the "git log | grep" is low, returning just the 
> most frequent committers might be good.

> Any suggestions on better heuristics?

That's pretty much what I was thinking of too - tweaking the values for
the log queries based on the total number of hits so people only turn up
if they did a certain proportion of the commits.  It'd take some
experimentation to work out what the values to use should be, I guess.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-09 15:08               ` Mark Brown
@ 2009-07-09 19:35                 ` Joe Perches
  2009-07-10 13:17                   ` Mark Brown
  0 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-09 19:35 UTC (permalink / raw)
  To: Mark Brown; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Thu, 2009-07-09 at 16:08 +0100, Mark Brown wrote:
> That's pretty much what I was thinking of too - tweaking the values for
> the log queries based on the total number of hits so people only turn up
> if they did a certain proportion of the commits.  It'd take some
> experimentation to work out what the values to use should be, I guess.

Perhaps something like this:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7fc09fc..a97f248 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -27,6 +27,7 @@ my $email_git = 1;
 my $email_git_penguin_chiefs = 0;
 my $email_git_min_signatures = 1;
 my $email_git_max_maintainers = 5;
+my $email_git_min_percent = 0;
 my $email_git_since = "1-year-ago";
 my $output_multiline = 1;
 my $output_separator = ", ";
@@ -65,6 +66,7 @@ if (!GetOptions(
 		'git-chief-penguins!' => \$email_git_penguin_chiefs,
 		'git-min-signatures=i' => \$email_git_min_signatures,
 		'git-max-maintainers=i' => \$email_git_max_maintainers,
+		'git-min-percent=i' => \$email_git_min_percent,
 		'git-since=s' => \$email_git_since,
 		'm!' => \$email_maintainer,
 		'n!' => \$email_usename,
@@ -307,6 +309,7 @@ MAINTAINER field selection options:
     --git-chief-penguins => include ${penguin_chiefs}
     --git-min-signatures => number of signatures required (default: 1)
     --git-max-maintainers => maximum maintainers to add (default: 5)
+    --git-min-percent => minimum percentage of commits required (default: 0)
     --git-since => git history to use (default: 1-year-ago)
     --m => include maintainer(s) if any
     --n => include name 'Full Name <addr\@domain.tld>'
@@ -497,6 +500,7 @@ sub recent_git_signoffs {
     my $output = "";
     my $count = 0;
     my @lines = ();
+    my $total_sign_offs;
 
     if (which("git") eq "") {
 	warn("$P: git not found.  Add --nogit to options?\n");
@@ -520,6 +524,14 @@ sub recent_git_signoffs {
     $output =~ s/^\s*//gm;
 
     @lines = split("\n", $output);
+
+    $total_sign_offs = 0;
+    foreach my $line (@lines) {
+	if ($line =~ m/([0-9]+)\s+(.*)/) {
+	    $total_sign_offs += $1;
+	}
+    }
+
     foreach my $line (@lines) {
 	if ($line =~ m/([0-9]+)\s+(.*)/) {
 	    my $sign_offs = $1;
@@ -529,6 +541,11 @@ sub recent_git_signoffs {
 	        $count > $email_git_max_maintainers) {
 		last;
 	    }
+	    if ($email_git_min_percent > 0 &&
+		(($sign_offs * 100 / $total_sign_offs) < $email_git_min_percent)
+		) {
+		last;
+	    }
 	} else {
 	    die("$P: Unexpected git output: ${line}\n");
 	}



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-09 19:35                 ` Joe Perches
@ 2009-07-10 13:17                   ` Mark Brown
  2009-07-10 16:25                     ` Joe Perches
  0 siblings, 1 reply; 23+ messages in thread
From: Mark Brown @ 2009-07-10 13:17 UTC (permalink / raw)
  To: Joe Perches; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Thu, Jul 09, 2009 at 12:35:39PM -0700, Joe Perches wrote:
> On Thu, 2009-07-09 at 16:08 +0100, Mark Brown wrote:

> > That's pretty much what I was thinking of too - tweaking the values for
> > the log queries based on the total number of hits so people only turn up
> > if they did a certain proportion of the commits.  It'd take some
> > experimentation to work out what the values to use should be, I guess.

> Perhaps something like this:

> +    --git-min-percent => minimum percentage of commits required (default: 0)

That seems reasonably effective with 5% or so as the default.  I do
think the default should be non-zero if we're going to be encouraging
people to use this as standard, though.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-10 13:17                   ` Mark Brown
@ 2009-07-10 16:25                     ` Joe Perches
  2009-07-10 18:44                       ` Mark Brown
  0 siblings, 1 reply; 23+ messages in thread
From: Joe Perches @ 2009-07-10 16:25 UTC (permalink / raw)
  To: Mark Brown; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Fri, 2009-07-10 at 14:17 +0100, Mark Brown wrote:
> On Thu, Jul 09, 2009 at 12:35:39PM -0700, Joe Perches wrote:
> > On Thu, 2009-07-09 at 16:08 +0100, Mark Brown wrote:
> > > That's pretty much what I was thinking of too - tweaking the values for
> > > the log queries based on the total number of hits so people only turn up
> > > if they did a certain proportion of the commits.  It'd take some
> > > experimentation to work out what the values to use should be, I guess.
> > Perhaps something like this:
> > +    --git-min-percent => minimum percentage of commits required (default: 0)
> 
> That seems reasonably effective with 5% or so as the default.  I do
> think the default should be non-zero if we're going to be encouraging
> people to use this as standard, though.

I'm not sure minimization of maintainers in
the result is that desirable but I am for
figuring out what works best.

I set it at 0 for now just to play with it.

What have you experimented with and how have the
results changed?

If minimization is what's desired, what I've
tried seems to work best at around 10.

Here's the little script I used.

#!/bin/bash
#

ShowMaintainers() {
    file=$1
    percent=$2
    extraargs=$3

    echo
    echo "Maintainers for: $file @ $percent % $extraargs"
    echo
 
   ./scripts/get_maintainer.pl $extraargs --git-min-percent=$percent -f $file 
}

for dir in $(find drivers -type d) ; do
    dir=$(echo $dir | sed -e 's/\.\///g')
    ShowMaintainers $dir 0
    ShowMaintainers $dir 5
    ShowMaintainers $dir 10
    ShowMaintainers $dir 0 "--nogit"
done



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-10 16:25                     ` Joe Perches
@ 2009-07-10 18:44                       ` Mark Brown
  2009-07-10 19:16                         ` Joe Perches
  0 siblings, 1 reply; 23+ messages in thread
From: Mark Brown @ 2009-07-10 18:44 UTC (permalink / raw)
  To: Joe Perches; +Cc: Pekka Enberg, linux-kernel, Andrew Morton, Vegard Nossum

On Fri, Jul 10, 2009 at 09:25:00AM -0700, Joe Perches wrote:
> On Fri, 2009-07-10 at 14:17 +0100, Mark Brown wrote:

> > That seems reasonably effective with 5% or so as the default.  I do
> > think the default should be non-zero if we're going to be encouraging
> > people to use this as standard, though.

> I'm not sure minimization of maintainers in
> the result is that desirable but I am for
> figuring out what works best.

It's not so much minimising maintainers per se that I'm concerned about
as ensuring that people doing general cleanup work don't end up getting
CCed on lots of random stuff, partly for their benefit and partly to
make get_maintainers easier to use.

> What have you experimented with and how have the
> results changed?

A combination of patches I'm working on and source files in subsystems I
maintain (basically, stuff where I know off the top of my head who
should turn up).  The noticable issues are things like Jean Delvare
turning up for sound/soc/codecs/tlv320aic3x.c as a result of kernel wide
API update work he was doing - by tweaking the percentage I was able to
get the output to exclude people who I know have done non-specific
cleanup work.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org
  2009-07-10 18:44                       ` Mark Brown
@ 2009-07-10 19:16                         ` Joe Perches
  0 siblings, 0 replies; 23+ messages in thread
From: Joe Perches @ 2009-07-10 19:16 UTC (permalink / raw)
  To: Andrew Morton, Mark Brown; +Cc: Pekka Enberg, linux-kernel, Vegard Nossum

On Fri, 2009-07-10 at 19:44 +0100, Mark Brown wrote:
> On Fri, Jul 10, 2009 at 09:25:00AM -0700, Joe Perches wrote:
> > On Fri, 2009-07-10 at 14:17 +0100, Mark Brown wrote:
> > > That seems reasonably effective with 5% or so as the default.  I do
> > > think the default should be non-zero if we're going to be encouraging
> > > people to use this as standard, though.

Andrew, do you have an opinion here?
You show up in these lists rather less often at 10% than 5.



^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2009-07-10 19:16 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-08  5:55 [PATCH 0/7] MAINTAINERS: cleanups Joe Perches
2009-07-08  5:55 ` [PATCH 1/7] MAINTAINERS: IA64 - pair P:/M: entries properly Joe Perches
2009-07-08  5:55 ` [PATCH 2/7] MAINTAINERS: Remove ivtv-user lists, add CX18 url Joe Perches
2009-07-08  5:55 ` [PATCH 3/7] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly Joe Perches
2009-07-08  5:55 ` [PATCH 4/7] MAINTAINERS: Use tabs in ACER ASPIRE ONE Joe Perches
2009-07-08  5:55 ` [PATCH 5/7] MAINTAINERS: Remove L: linux-kernel@vger.kernel.org Joe Perches
2009-07-08  6:32   ` Pekka Enberg
2009-07-08  6:39     ` Joe Perches
2009-07-08  6:44       ` Pekka Enberg
2009-07-08  6:47         ` Joe Perches
2009-07-08  6:55           ` Pekka Enberg
2009-07-08 16:37             ` Maciej W. Rozycki
2009-07-09  9:30           ` Mark Brown
2009-07-09 14:58             ` Joe Perches
2009-07-09 15:08               ` Mark Brown
2009-07-09 19:35                 ` Joe Perches
2009-07-10 13:17                   ` Mark Brown
2009-07-10 16:25                     ` Joe Perches
2009-07-10 18:44                       ` Mark Brown
2009-07-10 19:16                         ` Joe Perches
2009-07-08  5:55 ` [PATCH 6/7] MAINTAINERS: Move ARPD to CREDITS Joe Perches
2009-07-08  5:55 ` [PATCH 7/7] MAINTAINERS: Update KERNEL JANITORS Joe Perches
2009-07-09  2:25   ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.