* [PATCH] powerpc: Fix another bug in move of altivec code to vector.S
@ 2009-07-10 21:17 Andreas Schwab
2009-07-10 23:49 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2009-07-10 21:17 UTC (permalink / raw)
To: linuxppc-dev
When moving load_up_altivec to vector.S a typo in a comment caused a
thinko setting the wrong variable.
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
diff --git a/arch/powerpc/kernel/vector.S b/arch/powerpc/kernel/vector.S
index ef36cbb..ea4d646 100644
--- a/arch/powerpc/kernel/vector.S
+++ b/arch/powerpc/kernel/vector.S
@@ -80,10 +80,10 @@ _GLOBAL(load_up_altivec)
mtvscr vr0
REST_32VRS(0,r4,r5)
#ifndef CONFIG_SMP
- /* Update last_task_used_math to 'current' */
+ /* Update last_task_used_altivec to 'current' */
subi r4,r5,THREAD /* Back to 'current' */
fromreal(r4)
- PPC_STL r4,ADDROFF(last_task_used_math)(r3)
+ PPC_STL r4,ADDROFF(last_task_used_altivec)(r3)
#endif /* CONFIG_SMP */
/* restore registers and return */
blr
@@ -172,7 +172,7 @@ _GLOBAL(load_up_vsx)
oris r12,r12,MSR_VSX@h
std r12,_MSR(r1)
#ifndef CONFIG_SMP
- /* Update last_task_used_math to 'current' */
+ /* Update last_task_used_vsx to 'current' */
ld r4,PACACURRENT(r13)
std r4,0(r3)
#endif /* CONFIG_SMP */
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Fix another bug in move of altivec code to vector.S
2009-07-10 21:17 [PATCH] powerpc: Fix another bug in move of altivec code to vector.S Andreas Schwab
@ 2009-07-10 23:49 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-07-10 23:49 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linuxppc-dev
On Fri, 2009-07-10 at 23:17 +0200, Andreas Schwab wrote:
> When moving load_up_altivec to vector.S a typo in a comment caused a
> thinko setting the wrong variable.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Good catch, thanks.
Cheers,
Ben.
> ---
> diff --git a/arch/powerpc/kernel/vector.S b/arch/powerpc/kernel/vector.S
> index ef36cbb..ea4d646 100644
> --- a/arch/powerpc/kernel/vector.S
> +++ b/arch/powerpc/kernel/vector.S
> @@ -80,10 +80,10 @@ _GLOBAL(load_up_altivec)
> mtvscr vr0
> REST_32VRS(0,r4,r5)
> #ifndef CONFIG_SMP
> - /* Update last_task_used_math to 'current' */
> + /* Update last_task_used_altivec to 'current' */
> subi r4,r5,THREAD /* Back to 'current' */
> fromreal(r4)
> - PPC_STL r4,ADDROFF(last_task_used_math)(r3)
> + PPC_STL r4,ADDROFF(last_task_used_altivec)(r3)
> #endif /* CONFIG_SMP */
> /* restore registers and return */
> blr
> @@ -172,7 +172,7 @@ _GLOBAL(load_up_vsx)
> oris r12,r12,MSR_VSX@h
> std r12,_MSR(r1)
> #ifndef CONFIG_SMP
> - /* Update last_task_used_math to 'current' */
> + /* Update last_task_used_vsx to 'current' */
> ld r4,PACACURRENT(r13)
> std r4,0(r3)
> #endif /* CONFIG_SMP */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-10 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-10 21:17 [PATCH] powerpc: Fix another bug in move of altivec code to vector.S Andreas Schwab
2009-07-10 23:49 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.