[isar-cip-core][PATCH] Fix mount options passed to systemd unit

[isar-cip-core][PATCH] Fix mount options passed to systemd unit

[Uladzimir Bely]

Mount unit template used wrong variable name for mount options.
This resulted in empty `Options` value used for /tmp mounting.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl
index fcb2f3e..be5e663 100644
--- a/recipes-core/tmp-fs/files/tmp.mount.tmpl
+++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl
@@ -5,7 +5,7 @@ Description=Create /tmp
 What=tmpfs
 Where=/tmp
 Type=tmpfs
-Options=${TMP_OPTIONS}
+Options=${TMP_FS_OPTIONS}
 
 [Install]
 WantedBy=local-fs.target
-- 
2.20.1

Re: [isar-cip-core][PATCH] Fix mount options passed to systemd unit

[Jan Kiszka]

On 12.10.22 13:19, Uladzimir Bely wrote:
> Mount unit template used wrong variable name for mount options.
> This resulted in empty `Options` value used for /tmp mounting.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl
> index fcb2f3e..be5e663 100644
> --- a/recipes-core/tmp-fs/files/tmp.mount.tmpl
> +++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl
> @@ -5,7 +5,7 @@ Description=Create /tmp
>  What=tmpfs
>  Where=/tmp
>  Type=tmpfs
> -Options=${TMP_OPTIONS}
> +Options=${TMP_FS_OPTIONS}
>  
>  [Install]
>  WantedBy=local-fs.target

Thanks, applied.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [isar-cip-core][PATCH] Fix mount options passed to systemd unit

[Jan Kiszka]

On 12.10.22 13:34, Jan Kiszka wrote:
> On 12.10.22 13:19, Uladzimir Bely wrote:
>> Mount unit template used wrong variable name for mount options.
>> This resulted in empty `Options` value used for /tmp mounting.
>>
>> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
>> ---
>>  recipes-core/tmp-fs/files/tmp.mount.tmpl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-core/tmp-fs/files/tmp.mount.tmpl b/recipes-core/tmp-fs/files/tmp.mount.tmpl
>> index fcb2f3e..be5e663 100644
>> --- a/recipes-core/tmp-fs/files/tmp.mount.tmpl
>> +++ b/recipes-core/tmp-fs/files/tmp.mount.tmpl
>> @@ -5,7 +5,7 @@ Description=Create /tmp
>>  What=tmpfs
>>  Where=/tmp
>>  Type=tmpfs
>> -Options=${TMP_OPTIONS}
>> +Options=${TMP_FS_OPTIONS}
>>  
>>  [Install]
>>  WantedBy=local-fs.target
> 
> Thanks, applied.
> 
> Jan
> 

Need to drop it again for now as the current value of TMP_FS_OPTIONS in
the recipe is not ready for use. See also
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/44. We
need a working default. And likely also a weak assigning of that.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

[cip-dev][isar-cip-core][PATCH] tmp_fs: Correct option generation

[Quirin Gylstorff]

From: Quirin Gylstorff <quirin.gylstorff@siemens.com>

This fixes issues https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/44.

Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
 recipes-core/tmp-fs/tmp-fs_0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-core/tmp-fs/tmp-fs_0.1.bb b/recipes-core/tmp-fs/tmp-fs_0.1.bb
index 3ec20c7..b86b0fb 100644
--- a/recipes-core/tmp-fs/tmp-fs_0.1.bb
+++ b/recipes-core/tmp-fs/tmp-fs_0.1.bb
@@ -15,7 +15,7 @@ SRC_URI = "file://postinst \
 
 TMP_FS_SIZE ?= "500M"
 TMP_FS_MODE ?= "755"
-TMP_FS_OPTIONS = "nodev,nosuid,size=${TMP_SIZE},mode=${TMP_MODE}"
+TMP_FS_OPTIONS = "nodev,nosuid,size=${TMP_FS_SIZE},mode=${TMP_FS_MODE}"
 
 TEMPLATE_FILES = "tmp.mount.tmpl"
 TEMPLATE_VARS += "TMP_FS_OPTIONS"
-- 
2.35.1

Re: [cip-dev][isar-cip-core][PATCH] tmp_fs: Correct option generation

[Jan Kiszka]

On 18.10.22 09:26, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> 
> This fixes issues https://gitlab.com/cip-project/cip-core/isar-cip-core/-/issues/44.
> 
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
>  recipes-core/tmp-fs/tmp-fs_0.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-core/tmp-fs/tmp-fs_0.1.bb b/recipes-core/tmp-fs/tmp-fs_0.1.bb
> index 3ec20c7..b86b0fb 100644
> --- a/recipes-core/tmp-fs/tmp-fs_0.1.bb
> +++ b/recipes-core/tmp-fs/tmp-fs_0.1.bb
> @@ -15,7 +15,7 @@ SRC_URI = "file://postinst \
>  
>  TMP_FS_SIZE ?= "500M"
>  TMP_FS_MODE ?= "755"
> -TMP_FS_OPTIONS = "nodev,nosuid,size=${TMP_SIZE},mode=${TMP_MODE}"
> +TMP_FS_OPTIONS = "nodev,nosuid,size=${TMP_FS_SIZE},mode=${TMP_FS_MODE}"
>  
>  TEMPLATE_FILES = "tmp.mount.tmpl"
>  TEMPLATE_VARS += "TMP_FS_OPTIONS"

Thanks, applied. And then I applied Uladzimir's patch on top again.
Result now in next.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux