* [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info
@ 2009-08-28 14:18 Moger, Babu
2009-08-28 17:50 ` Chandra Seetharaman
0 siblings, 1 reply; 3+ messages in thread
From: Moger, Babu @ 2009-08-28 14:18 UTC (permalink / raw)
To: 'linux-scsi@vger.kernel.org'
Cc: Dachepalli, Sudhir, 'dm-devel@redhat.com',
Chauhan, Vijay, Stankey, Robert
The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.
Signed-off-by: Babu Moger <babu.moger@lsi.com>
Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
---
--- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-08-22 06:20:45.000000000 -0500
+++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-08-22 06:18:36.000000000 -0500
@@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
if (!ret)
goto done;
- err = SCSI_DH_OK;
-
switch (sense_hdr.sense_key) {
case NO_SENSE:
case ABORTED_COMMAND:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info
2009-08-28 14:18 [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info Moger, Babu
@ 2009-08-28 17:50 ` Chandra Seetharaman
2009-09-10 21:54 ` Moger, Babu
0 siblings, 1 reply; 3+ messages in thread
From: Chandra Seetharaman @ 2009-08-28 17:50 UTC (permalink / raw)
To: Moger, Babu
Cc: 'linux-scsi@vger.kernel.org',
'dm-devel@redhat.com',
Chauhan, Vijay, Stankey, Robert, Dachepalli, Sudhir
On Fri, 2009-08-28 at 08:18 -0600, Moger, Babu wrote:
> The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.
>
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
>
> ---
> --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-08-22 06:20:45.000000000 -0500
> +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-08-22 06:18:36.000000000 -0500
> @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
> if (!ret)
> goto done;
>
> - err = SCSI_DH_OK;
> -
> switch (sense_hdr.sense_key) {
> case NO_SENSE:
> case ABORTED_COMMAND:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info
2009-08-28 17:50 ` Chandra Seetharaman
@ 2009-09-10 21:54 ` Moger, Babu
0 siblings, 0 replies; 3+ messages in thread
From: Moger, Babu @ 2009-09-10 21:54 UTC (permalink / raw)
To: James.Bottomley
Cc: 'linux-scsi@vger.kernel.org',
'dm-devel@redhat.com',
Chandra Seetharaman
James,
Can you please pick this up for next scsi update.. I have made sure that checkpatch.pl runs fine on this . ):
Thanks
Babu Moger
> -----Original Message-----
> From: Chandra Seetharaman [mailto:sekharan@us.ibm.com]
> Sent: Friday, August 28, 2009 12:51 PM
> To: Moger, Babu
> Cc: 'linux-scsi@vger.kernel.org'; 'dm-devel@redhat.com'; Chauhan,
> Vijay; Stankey, Robert; Dachepalli, Sudhir
> Subject: Re: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct
> mode select cmd return info
>
>
> On Fri, 2009-08-28 at 08:18 -0600, Moger, Babu wrote:
> > The function mode_select_handle_sense returns SCSI_DH_OK even when
> there is a sense code which is incorrect. Removing it so that it
> returns SCSI_DH_IO when there is sense that is not handled by this
> function.
> >
> > Signed-off-by: Babu Moger <babu.moger@lsi.com>
> > Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> > Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
>
> Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
>
> >
> > ---
> > --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig
> 2009-08-22 06:20:45.000000000 -0500
> > +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-
> 08-22 06:18:36.000000000 -0500
> > @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru
> > if (!ret)
> > goto done;
> >
> > - err = SCSI_DH_OK;
> > -
> > switch (sense_hdr.sense_key) {
> > case NO_SENSE:
> > case ABORTED_COMMAND:
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-10 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-28 14:18 [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info Moger, Babu
2009-08-28 17:50 ` Chandra Seetharaman
2009-09-10 21:54 ` Moger, Babu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.