From: Jan Kara <jack@suse.cz> To: linux-fsdevel@vger.kernel.org Cc: LKML <linux-kernel@vger.kernel.org>, hch@lst.de, Jan Kara <jack@suse.cz>, Felix Blyakher <felixb@sgi.com>, xfs@oss.sgi.com Subject: [PATCH 13/16] xfs: Convert sync_page_range() to simple filemap_write_and_wait_range() Date: Wed, 2 Sep 2009 15:59:23 +0200 [thread overview] Message-ID: <1251899966-7316-14-git-send-email-jack@suse.cz> (raw) In-Reply-To: <1251899966-7316-1-git-send-email-jack@suse.cz> Christoph Hellwig says that it is enough for XFS to call filemap_write_and_wait_range() instead of sync_page_range() because we do all the metadata syncing when forcing the log. CC: Felix Blyakher <felixb@sgi.com> CC: xfs@oss.sgi.com CC: Christoph Hellwig <hch@lst.de> Signed-off-by: Jan Kara <jack@suse.cz> --- fs/xfs/linux-2.6/xfs_lrw.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c index 7078974..fde63a3 100644 --- a/fs/xfs/linux-2.6/xfs_lrw.c +++ b/fs/xfs/linux-2.6/xfs_lrw.c @@ -817,7 +817,8 @@ write_retry: xfs_iunlock(xip, iolock); if (need_i_mutex) mutex_unlock(&inode->i_mutex); - error2 = sync_page_range(inode, mapping, pos, ret); + error2 = filemap_write_and_wait_range(mapping, pos, + pos + ret - 1); if (!error) error = error2; if (need_i_mutex) -- 1.6.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: linux-fsdevel@vger.kernel.org Cc: xfs@oss.sgi.com, Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>, hch@lst.de Subject: [PATCH 13/16] xfs: Convert sync_page_range() to simple filemap_write_and_wait_range() Date: Wed, 2 Sep 2009 15:59:23 +0200 [thread overview] Message-ID: <1251899966-7316-14-git-send-email-jack@suse.cz> (raw) In-Reply-To: <1251899966-7316-1-git-send-email-jack@suse.cz> Christoph Hellwig says that it is enough for XFS to call filemap_write_and_wait_range() instead of sync_page_range() because we do all the metadata syncing when forcing the log. CC: Felix Blyakher <felixb@sgi.com> CC: xfs@oss.sgi.com CC: Christoph Hellwig <hch@lst.de> Signed-off-by: Jan Kara <jack@suse.cz> --- fs/xfs/linux-2.6/xfs_lrw.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c index 7078974..fde63a3 100644 --- a/fs/xfs/linux-2.6/xfs_lrw.c +++ b/fs/xfs/linux-2.6/xfs_lrw.c @@ -817,7 +817,8 @@ write_retry: xfs_iunlock(xip, iolock); if (need_i_mutex) mutex_unlock(&inode->i_mutex); - error2 = sync_page_range(inode, mapping, pos, ret); + error2 = filemap_write_and_wait_range(mapping, pos, + pos + ret - 1); if (!error) error = error2; if (need_i_mutex) -- 1.6.0.2 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-09-02 14:03 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-09-02 13:59 [PATCH 0/16] Make O_SYNC handling use standard syncing path (version 4) Jan Kara 2009-09-02 13:59 ` [PATCH 01/16] vfs: Introduce filemap_fdatawait_range Jan Kara 2009-09-02 13:59 ` [PATCH 02/16] vfs: Export __generic_file_aio_write() and add some comments Jan Kara 2009-09-02 13:59 ` [Ocfs2-devel] " Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` [PATCH 03/16] vfs: Remove syncing from generic_file_direct_write() and generic_file_buffered_write() Jan Kara 2009-09-02 13:59 ` [Ocfs2-devel] " Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` [PATCH 04/16] pohmelfs: Use __generic_file_aio_write instead of generic_file_aio_write_nolock Jan Kara 2009-09-02 13:59 ` [PATCH 05/16] ocfs2: " Jan Kara 2009-09-02 13:59 ` [Ocfs2-devel] " Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` [PATCH 06/16] vfs: Rename generic_file_aio_write_nolock Jan Kara 2009-09-02 21:47 ` Christoph Hellwig 2009-09-03 10:24 ` Jan Kara 2009-09-03 15:37 ` Christoph Hellwig 2009-09-02 13:59 ` [PATCH 07/16] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode Jan Kara 2009-09-02 13:59 ` [Ocfs2-devel] " Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` [PATCH 08/16] ext2: Update comment about generic_osync_inode Jan Kara 2009-09-02 13:59 ` [PATCH 09/16] ext3: Remove syncing logic from ext3_file_write Jan Kara 2009-09-02 13:59 ` [PATCH 10/16] ext4: Remove syncing logic from ext4_file_write Jan Kara 2009-09-02 13:59 ` [PATCH 11/16] ntfs: Use new syncing helpers and update comments Jan Kara 2009-09-02 13:59 ` [PATCH 12/16] ocfs2: Update syncing after splicing to match generic version Jan Kara 2009-09-02 13:59 ` [Ocfs2-devel] " Jan Kara 2009-09-02 13:59 ` Jan Kara 2009-09-02 13:59 ` Jan Kara [this message] 2009-09-02 13:59 ` [PATCH 13/16] xfs: Convert sync_page_range() to simple filemap_write_and_wait_range() Jan Kara 2009-09-02 13:59 ` [PATCH 14/16] pohmelfs: Use new syncing helper Jan Kara 2009-09-02 13:59 ` [PATCH 15/16] fat: Opencode sync_page_range_nolock() Jan Kara 2009-09-02 13:59 ` [PATCH 16/16] vfs: Remove generic_osync_inode() and sync_page_range{_nolock}() Jan Kara 2009-09-02 14:16 ` [PATCH 0/16] Make O_SYNC handling use standard syncing path (version 4) Christoph Hellwig 2009-09-02 22:18 ` [PATCH] fsync: wait for data writeout completion before calling ->fsync Christoph Hellwig 2009-09-02 22:37 ` Joel Becker 2009-09-03 10:47 ` Jan Kara 2009-09-03 15:39 ` Christoph Hellwig 2009-09-10 20:25 ` [PATCH 18/16] implement posix O_SYNC and O_DSYNC semantics Christoph Hellwig 2009-09-10 20:38 ` Trond Myklebust 2009-09-10 20:40 ` Christoph Hellwig 2009-09-10 20:43 ` Trond Myklebust 2009-09-10 20:44 ` Christoph Hellwig 2009-09-10 23:07 ` Andreas Dilger 2009-09-10 23:18 ` Christoph Hellwig 2009-09-11 19:16 ` [PATCHv2 " Christoph Hellwig 2009-09-14 16:54 ` Jan Kara 2009-09-14 17:02 ` Christoph Hellwig 2009-09-15 13:12 ` [PATCH] " Christoph Hellwig 2009-09-15 14:10 ` Jan Kara 2009-09-15 14:50 ` Ulrich Drepper 2009-09-17 17:16 ` Christoph Hellwig 2009-09-17 21:03 ` Kyle McMartin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1251899966-7316-14-git-send-email-jack@suse.cz \ --to=jack@suse.cz \ --cc=felixb@sgi.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.