* [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.
@ 2009-09-08 6:52 ` thomas.ab at samsung.com
0 siblings, 0 replies; 4+ messages in thread
From: thomas.ab @ 2009-09-08 6:52 UTC (permalink / raw)
To: ben-linux; +Cc: linux-arm-kernel, linux-mmc, Thomas Abraham
From: Thomas Abraham <thomas.ab@samsung.com>
This patch enables ADMA feature in 6410 SDHCI controller
driver.
---
drivers/mmc/host/sdhci-s3c.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index db1bb93..7f5b64e 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
host->irq = irq;
/* Setup quirks for the controller */
-
- /* Currently with ADMA enabled we are getting some length
- * interrupts that are not being dealt with, do disable
- * ADMA until this is sorted out. */
- host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
- host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
+ host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
#ifndef CONFIG_MMC_SDHCI_S3C_DMA
--
1.5.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.
@ 2009-09-08 6:52 ` thomas.ab at samsung.com
0 siblings, 0 replies; 4+ messages in thread
From: thomas.ab at samsung.com @ 2009-09-08 6:52 UTC (permalink / raw)
To: linux-arm-kernel
From: Thomas Abraham <thomas.ab@samsung.com>
This patch enables ADMA feature in 6410 SDHCI controller
driver.
---
drivers/mmc/host/sdhci-s3c.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index db1bb93..7f5b64e 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
host->irq = irq;
/* Setup quirks for the controller */
-
- /* Currently with ADMA enabled we are getting some length
- * interrupts that are not being dealt with, do disable
- * ADMA until this is sorted out. */
- host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
- host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
+ host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
#ifndef CONFIG_MMC_SDHCI_S3C_DMA
--
1.5.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.
2009-09-08 6:52 ` thomas.ab at samsung.com
@ 2009-09-16 0:47 ` Ben Dooks
-1 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2009-09-16 0:47 UTC (permalink / raw)
To: thomas.ab; +Cc: ben-linux, linux-mmc, linux-arm-kernel
On Tue, Sep 08, 2009 at 03:52:49PM +0900, thomas.ab@samsung.com wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> This patch enables ADMA feature in 6410 SDHCI controller
> driver.
Hmm, surely this wouldn't have wrapped and could have goine onto one line?
Also no signoff.
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index db1bb93..7f5b64e 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> host->irq = irq;
>
> /* Setup quirks for the controller */
> -
> - /* Currently with ADMA enabled we are getting some length
> - * interrupts that are not being dealt with, do disable
> - * ADMA until this is sorted out. */
> - host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
> - host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
> + host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
>
> #ifndef CONFIG_MMC_SDHCI_S3C_DMA
>
> --
> 1.5.3.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller.
@ 2009-09-16 0:47 ` Ben Dooks
0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2009-09-16 0:47 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 08, 2009 at 03:52:49PM +0900, thomas.ab at samsung.com wrote:
> From: Thomas Abraham <thomas.ab@samsung.com>
>
> This patch enables ADMA feature in 6410 SDHCI controller
> driver.
Hmm, surely this wouldn't have wrapped and could have goine onto one line?
Also no signoff.
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index db1bb93..7f5b64e 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -329,12 +329,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> host->irq = irq;
>
> /* Setup quirks for the controller */
> -
> - /* Currently with ADMA enabled we are getting some length
> - * interrupts that are not being dealt with, do disable
> - * ADMA until this is sorted out. */
> - host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
> - host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
> + host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
>
> #ifndef CONFIG_MMC_SDHCI_S3C_DMA
>
> --
> 1.5.3.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-16 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-08 6:52 [PATCH 4/8] s3c6410: sdhci: Enable ADMA feature in 6410 sdhci controller thomas.ab
2009-09-08 6:52 ` thomas.ab at samsung.com
2009-09-16 0:47 ` Ben Dooks
2009-09-16 0:47 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.