* [PATCH] x86: avoid modifying global flag tsc_unstable in unsychronized_tsc()
@ 2009-10-12 14:22 Hillier, Gernot
2009-10-13 1:21 ` Alok Kataria
0 siblings, 1 reply; 2+ messages in thread
From: Hillier, Gernot @ 2009-10-12 14:22 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, akataria
From: Gernot Hillier <gernot.hillier@siemens.com>
The current behavior of unsynchronized_tsc() prevents the warning for
unsychronized TSCs to be printed: tsc_init() calls unsynchronized_tsc()
first to check for such problems; if found, mark_tsc_unstable() is
called. However, the latter bails out immediately as unsynchronized_
tsc() did already set the global flag tsc_unstable. Thus, the intended
warning message "Marking TSC unstable due to TSCs unsynchronized" won't
show up.
This patch changes the behavior for unsynchronized_tsc() to only *check*
for the quirk condition, but not to modify any global flags. If I'm not
mistaken, the only place to *set* the flag shall be mark_tsc_unstable().
Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index cd982f4..ffbb786 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -836,10 +836,10 @@ __cpuinit int unsynchronized_tsc(void)
if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
/* assume multi socket systems are not synchronized: */
if (num_possible_cpus() > 1)
- tsc_unstable = 1;
+ return 1;
}
- return tsc_unstable;
+ return 0;
}
static void __init init_tsc_clocksource(void)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: avoid modifying global flag tsc_unstable in unsychronized_tsc()
2009-10-12 14:22 [PATCH] x86: avoid modifying global flag tsc_unstable in unsychronized_tsc() Hillier, Gernot
@ 2009-10-13 1:21 ` Alok Kataria
0 siblings, 0 replies; 2+ messages in thread
From: Alok Kataria @ 2009-10-13 1:21 UTC (permalink / raw)
To: Hillier, Gernot; +Cc: x86, linux-kernel
On Mon, 2009-10-12 at 07:22 -0700, Hillier, Gernot wrote:
> From: Gernot Hillier <gernot.hillier@siemens.com>
>
> The current behavior of unsynchronized_tsc() prevents the warning for
> unsychronized TSCs to be printed: tsc_init() calls unsynchronized_tsc()
> first to check for such problems; if found, mark_tsc_unstable() is
> called. However, the latter bails out immediately as unsynchronized_
> tsc() did already set the global flag tsc_unstable. Thus, the intended
> warning message "Marking TSC unstable due to TSCs unsynchronized" won't
> show up.
>
> This patch changes the behavior for unsynchronized_tsc() to only *check*
> for the quirk condition, but not to modify any global flags. If I'm not
> mistaken, the only place to *set* the flag shall be mark_tsc_unstable().
Yes, you are right. The patch looks good to me.
Thanks,
Alok
>
> Signed-off-by: Gernot Hillier <gernot.hillier@siemens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index cd982f4..ffbb786 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -836,10 +836,10 @@ __cpuinit int unsynchronized_tsc(void)
> if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
> /* assume multi socket systems are not synchronized: */
> if (num_possible_cpus() > 1)
> - tsc_unstable = 1;
> + return 1;
> }
>
> - return tsc_unstable;
> + return 0;
> }
>
> static void __init init_tsc_clocksource(void)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 1:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-12 14:22 [PATCH] x86: avoid modifying global flag tsc_unstable in unsychronized_tsc() Hillier, Gernot
2009-10-13 1:21 ` Alok Kataria
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.