All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings
@ 2009-10-16  9:46 amit.kucheria
  2009-10-20  6:11 ` Amit Kucheria
  2009-11-05 22:33 ` Len Brown
  0 siblings, 2 replies; 4+ messages in thread
From: amit.kucheria @ 2009-10-16  9:46 UTC (permalink / raw)
  To: List Linux Kernel; +Cc: len.brown, Amit Kucheria

From: Amit Kucheria <amit.kucheria@canonical.com>

Make the trip_point_N_type sysfs files return a string ending in EOL for
consistency with other sysfs files.

Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
---
 drivers/thermal/thermal_sys.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 4e83c29..6f8d8f9 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -180,15 +180,15 @@ trip_point_type_show(struct device *dev, struct device_attribute *attr,
 
 	switch (type) {
 	case THERMAL_TRIP_CRITICAL:
-		return sprintf(buf, "critical");
+		return sprintf(buf, "critical\n");
 	case THERMAL_TRIP_HOT:
-		return sprintf(buf, "hot");
+		return sprintf(buf, "hot\n");
 	case THERMAL_TRIP_PASSIVE:
-		return sprintf(buf, "passive");
+		return sprintf(buf, "passive\n");
 	case THERMAL_TRIP_ACTIVE:
-		return sprintf(buf, "active");
+		return sprintf(buf, "active\n");
 	default:
-		return sprintf(buf, "unknown");
+		return sprintf(buf, "unknown\n");
 	}
 }
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings
  2009-10-16  9:46 [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings amit.kucheria
@ 2009-10-20  6:11 ` Amit Kucheria
  2009-10-20  6:16   ` Zhang Rui
  2009-11-05 22:33 ` Len Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Amit Kucheria @ 2009-10-20  6:11 UTC (permalink / raw)
  To: rui.zhang, linux-acpi

Rui,

This patch should perhaps have been cc'ed to you and the linux-acpi
list as well.

Regards,
Amit

---------- Forwarded message ----------
From:  <amit.kucheria@canonical.com>
Date: Fri, Oct 16, 2009 at 12:46 PM
Subject: [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the
trip_point_N_type strings
To: List Linux Kernel <linux-kernel@vger.kernel.org>
Cc: len.brown@intel.com, Amit Kucheria <amit.kucheria@canonical.com>


From: Amit Kucheria <amit.kucheria@canonical.com>

Make the trip_point_N_type sysfs files return a string ending in EOL for
consistency with other sysfs files.

Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
---
 drivers/thermal/thermal_sys.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 4e83c29..6f8d8f9 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -180,15 +180,15 @@ trip_point_type_show(struct device *dev, struct
device_attribute *attr,

       switch (type) {
       case THERMAL_TRIP_CRITICAL:
-               return sprintf(buf, "critical");
+               return sprintf(buf, "critical\n");
       case THERMAL_TRIP_HOT:
-               return sprintf(buf, "hot");
+               return sprintf(buf, "hot\n");
       case THERMAL_TRIP_PASSIVE:
-               return sprintf(buf, "passive");
+               return sprintf(buf, "passive\n");
       case THERMAL_TRIP_ACTIVE:
-               return sprintf(buf, "active");
+               return sprintf(buf, "active\n");
       default:
-               return sprintf(buf, "unknown");
+               return sprintf(buf, "unknown\n");
       }
 }

--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings
  2009-10-20  6:11 ` Amit Kucheria
@ 2009-10-20  6:16   ` Zhang Rui
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang Rui @ 2009-10-20  6:16 UTC (permalink / raw)
  To: Amit Kucheria; +Cc: linux-acpi

Acked-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui

On Tue, 2009-10-20 at 14:11 +0800, Amit Kucheria wrote:
> Rui,
> 
> This patch should perhaps have been cc'ed to you and the linux-acpi
> list as well.
> 
> Regards,
> Amit
> 
> ---------- Forwarded message ----------
> From:  <amit.kucheria@canonical.com>
> Date: Fri, Oct 16, 2009 at 12:46 PM
> Subject: [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the
> trip_point_N_type strings
> To: List Linux Kernel <linux-kernel@vger.kernel.org>
> Cc: len.brown@intel.com, Amit Kucheria <amit.kucheria@canonical.com>
> 
> 
> From: Amit Kucheria <amit.kucheria@canonical.com>
> 
> Make the trip_point_N_type sysfs files return a string ending in EOL for
> consistency with other sysfs files.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
> ---
>  drivers/thermal/thermal_sys.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 4e83c29..6f8d8f9 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -180,15 +180,15 @@ trip_point_type_show(struct device *dev, struct
> device_attribute *attr,
> 
>        switch (type) {
>        case THERMAL_TRIP_CRITICAL:
> -               return sprintf(buf, "critical");
> +               return sprintf(buf, "critical\n");
>        case THERMAL_TRIP_HOT:
> -               return sprintf(buf, "hot");
> +               return sprintf(buf, "hot\n");
>        case THERMAL_TRIP_PASSIVE:
> -               return sprintf(buf, "passive");
> +               return sprintf(buf, "passive\n");
>        case THERMAL_TRIP_ACTIVE:
> -               return sprintf(buf, "active");
> +               return sprintf(buf, "active\n");
>        default:
> -               return sprintf(buf, "unknown");
> +               return sprintf(buf, "unknown\n");
>        }
>  }
> 
> --
> 1.6.3.3


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings
  2009-10-16  9:46 [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings amit.kucheria
  2009-10-20  6:11 ` Amit Kucheria
@ 2009-11-05 22:33 ` Len Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Len Brown @ 2009-11-05 22:33 UTC (permalink / raw)
  To: Amit Kucheria; +Cc: List Linux Kernel, linux-acpi

applied

thanks,
Len Brown, Intel Open Source Technology Center


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-05 22:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-16  9:46 [PATCH] acpi: thermal: [TRIVIAL] Add EOL to the trip_point_N_type strings amit.kucheria
2009-10-20  6:11 ` Amit Kucheria
2009-10-20  6:16   ` Zhang Rui
2009-11-05 22:33 ` Len Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.