All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Carsten Otte <cotte@de.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON
Date: Thu, 29 Oct 2009 14:39:54 -0700	[thread overview]
Message-ID: <1256852394.9044.118.camel@slab.beaverton.ibm.com> (raw)
In-Reply-To: <1256152621-18863-10-git-send-email-agraf@suse.de>

On Wed, 2009-10-21 at 21:17 +0200, Alexander Graf wrote:
> MP State is implemented in the generic code, so let's move the variable
> it accesses to generic code as well.
> 
> Still unbreaks PPC and now even S390x w/ KVM.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Acked-by: Hollis Blanchard <hollisb@us.ibm.com>

Anthony, this patch fixes a build break in PowerPC KVM. Arguably it
should not be patch 9/9 in an S390 series, but in any case please apply
it. :)

-- 
Hollis Blanchard
IBM Linux Technology Center

> ---
>  cpu-defs.h        |    1 +
>  target-i386/cpu.h |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/cpu-defs.h b/cpu-defs.h
> index 95068b5..ad804e6 100644
> --- a/cpu-defs.h
> +++ b/cpu-defs.h
> @@ -197,6 +197,7 @@ typedef struct CPUWatchpoint {
>      const char *cpu_model_str;                                          \
>      struct KVMState *kvm_state;                                         \
>      struct kvm_run *kvm_run;                                            \
> +    uint32_t mp_state;                                                  \
>      int kvm_fd;
> 
>  #endif
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 5929d28..8d0c2a9 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -692,7 +692,6 @@ typedef struct CPUX86State {
> 
>      /* For KVM */
>      uint64_t interrupt_bitmap[256 / 64];
> -    uint32_t mp_state;
> 
>      /* in order to simplify APIC support, we leave this pointer to the
>         user */

  reply	other threads:[~2009-10-29 21:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 19:16 [Qemu-devel] [PATCH 0/9] S390x KVM support v3 Alexander Graf
2009-10-21 19:16 ` [Qemu-devel] [PATCH 1/9] Add KVM support for S390x Alexander Graf
2009-10-21 19:16   ` [Qemu-devel] [PATCH 2/9] Allocate physical memory in low virtual address space Alexander Graf
2009-10-21 19:16     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-21 19:16       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-21 19:16         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-21 19:16           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-21 19:16             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-21 19:17               ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf
2009-10-21 19:17                 ` [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON Alexander Graf
2009-10-29 21:39                   ` Hollis Blanchard [this message]
2009-11-05 10:16                     ` Alexander Graf
2009-11-09 19:44                       ` Anthony Liguori
2009-11-09 19:45                         ` Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2009-10-21  9:24 [Qemu-devel] [PATCH 0/9] S390x KVM support v2 Alexander Graf
2009-10-21  9:24 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
2009-10-21  9:24   ` [Qemu-devel] [PATCH 2/9] Add KVM support for S390x Alexander Graf
2009-10-21  9:25     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-21  9:25       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-21  9:25         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-21  9:25           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-21  9:25             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-21  9:25               ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf
2009-10-21  9:25                 ` [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON Alexander Graf
2009-10-19 14:37 [Qemu-devel] [PATCH 0/9] S390x KVM support Alexander Graf
2009-10-19 14:37 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
2009-10-19 14:37   ` [Qemu-devel] [PATCH 2/9] Add KVM support for S390x Alexander Graf
2009-10-19 14:37     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-19 14:37       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-19 14:37         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-19 14:37           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-19 14:37             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-19 14:37               ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf
2009-10-19 14:37                 ` [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256852394.9044.118.camel@slab.beaverton.ibm.com \
    --to=hollisb@us.ibm.com \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=cotte@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.