* [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
@ 2009-11-02 7:56 manjugk
2009-11-02 7:59 ` G, Manjunath Kondaiah
2009-11-02 8:26 ` Artem Bityutskiy
0 siblings, 2 replies; 10+ messages in thread
From: manjugk @ 2009-11-02 7:56 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, Manjunatha GK
From: Manjunatha GK <manjugk@ti.com>
Signed-off-by: Manjunatha GK <manjugk@ti.com>
---
arch/arm/configs/omap_zoom2_defconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/omap_zoom2_defconfig b/arch/arm/configs/omap_zoom2_defconfig
index f1739fa..8ca835a 100644
--- a/arch/arm/configs/omap_zoom2_defconfig
+++ b/arch/arm/configs/omap_zoom2_defconfig
@@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
CONFIG_FRAME_WARN=1024
CONFIG_MAGIC_SYSRQ=y
# CONFIG_UNUSED_SYMBOLS is not set
-# CONFIG_DEBUG_FS is not set
+CONFIG_DEBUG_FS=y
# CONFIG_HEADERS_CHECK is not set
CONFIG_DEBUG_KERNEL=y
# CONFIG_DEBUG_SHIRQ is not set
--
1.6.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 7:56 [PATCH] [OMAP3_PM] Fix zoom2 defconfig build manjugk
@ 2009-11-02 7:59 ` G, Manjunath Kondaiah
2009-11-02 8:26 ` Artem Bityutskiy
1 sibling, 0 replies; 10+ messages in thread
From: G, Manjunath Kondaiah @ 2009-11-02 7:59 UTC (permalink / raw)
To: G, Manjunath Kondaiah, linux-omap; +Cc: khilman
It looks like config issue with git-send-email on my system.
Here is Patch Description:
The CONFIG_DEBUG_FS is not enabled in omap_zoom2_defconfig which
is breaking zoom2 defconfig build in linux-omap-pm(pm branch).
This patch fixes build issue and kernel booting is also tested
on zoom2.
> -----Original Message-----
> From: G, Manjunath Kondaiah
> Sent: Monday, November 02, 2009 1:26 PM
> To: linux-omap@vger.kernel.org
> Cc: khilman@deeprootsystems.com; G, Manjunath Kondaiah
> Subject: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
>
> From: Manjunatha GK <manjugk@ti.com>
>
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> ---
> arch/arm/configs/omap_zoom2_defconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/configs/omap_zoom2_defconfig
> b/arch/arm/configs/omap_zoom2_defconfig
> index f1739fa..8ca835a 100644
> --- a/arch/arm/configs/omap_zoom2_defconfig
> +++ b/arch/arm/configs/omap_zoom2_defconfig
> @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> CONFIG_FRAME_WARN=1024
> CONFIG_MAGIC_SYSRQ=y
> # CONFIG_UNUSED_SYMBOLS is not set
> -# CONFIG_DEBUG_FS is not set
> +CONFIG_DEBUG_FS=y
> # CONFIG_HEADERS_CHECK is not set
> CONFIG_DEBUG_KERNEL=y
> # CONFIG_DEBUG_SHIRQ is not set
> --
> 1.6.0.4
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 7:56 [PATCH] [OMAP3_PM] Fix zoom2 defconfig build manjugk
2009-11-02 7:59 ` G, Manjunath Kondaiah
@ 2009-11-02 8:26 ` Artem Bityutskiy
2009-11-02 9:00 ` G, Manjunath Kondaiah
1 sibling, 1 reply; 10+ messages in thread
From: Artem Bityutskiy @ 2009-11-02 8:26 UTC (permalink / raw)
To: manjugk; +Cc: linux-omap, khilman
On Mon, 2009-11-02 at 13:26 +0530, manjugk@ti.com wrote:
> From: Manjunatha GK <manjugk@ti.com>
>
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> ---
> arch/arm/configs/omap_zoom2_defconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/configs/omap_zoom2_defconfig b/arch/arm/configs/omap_zoom2_defconfig
> index f1739fa..8ca835a 100644
> --- a/arch/arm/configs/omap_zoom2_defconfig
> +++ b/arch/arm/configs/omap_zoom2_defconfig
> @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> CONFIG_FRAME_WARN=1024
> CONFIG_MAGIC_SYSRQ=y
> # CONFIG_UNUSED_SYMBOLS is not set
> -# CONFIG_DEBUG_FS is not set
> +CONFIG_DEBUG_FS=y
> # CONFIG_HEADERS_CHECK is not set
> CONFIG_DEBUG_KERNEL=y
> # CONFIG_DEBUG_SHIRQ is not set
It is nicer to provide the build failure log. But if this is a build
failure, this means there is a problem with Kconfig dependency, which
should be fixed properly, not hidden.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 8:26 ` Artem Bityutskiy
@ 2009-11-02 9:00 ` G, Manjunath Kondaiah
2009-11-02 9:14 ` Felipe Balbi
2009-11-02 9:17 ` Artem Bityutskiy
0 siblings, 2 replies; 10+ messages in thread
From: G, Manjunath Kondaiah @ 2009-11-02 9:00 UTC (permalink / raw)
To: dedekind1; +Cc: linux-omap, khilman
> > --- a/arch/arm/configs/omap_zoom2_defconfig
> > +++ b/arch/arm/configs/omap_zoom2_defconfig
> > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> > CONFIG_FRAME_WARN=1024
> > CONFIG_MAGIC_SYSRQ=y
> > # CONFIG_UNUSED_SYMBOLS is not set
> > -# CONFIG_DEBUG_FS is not set
> > +CONFIG_DEBUG_FS=y
> > # CONFIG_HEADERS_CHECK is not set
> > CONFIG_DEBUG_KERNEL=y
> > # CONFIG_DEBUG_SHIRQ is not set
>
> It is nicer to provide the build failure log. But if this is a build
> failure, this means there is a problem with Kconfig dependency, which
> should be fixed properly, not hidden.
Here is build failure log:
MODPOST vmlinux.o
WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save'
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save'
arch/arm/mach-omap2/built-in.o: In function `configure_vc':
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init'
/home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init'
make: *** [.tmp_vmlinux1] Error 1
The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c
-Manjunath
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 9:00 ` G, Manjunath Kondaiah
@ 2009-11-02 9:14 ` Felipe Balbi
2009-11-02 10:00 ` G, Manjunath Kondaiah
2009-11-02 9:17 ` Artem Bityutskiy
1 sibling, 1 reply; 10+ messages in thread
From: Felipe Balbi @ 2009-11-02 9:14 UTC (permalink / raw)
To: ext G, Manjunath Kondaiah; +Cc: dedekind1, linux-omap, khilman
On Mon, Nov 02, 2009 at 10:00:23AM +0100, ext G, Manjunath Kondaiah wrote:
>
> > > --- a/arch/arm/configs/omap_zoom2_defconfig
> > > +++ b/arch/arm/configs/omap_zoom2_defconfig
> > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> > > CONFIG_FRAME_WARN=1024
> > > CONFIG_MAGIC_SYSRQ=y
> > > # CONFIG_UNUSED_SYMBOLS is not set
> > > -# CONFIG_DEBUG_FS is not set
> > > +CONFIG_DEBUG_FS=y
> > > # CONFIG_HEADERS_CHECK is not set
> > > CONFIG_DEBUG_KERNEL=y
> > > # CONFIG_DEBUG_SHIRQ is not set
> >
> > It is nicer to provide the build failure log. But if this is a build
> > failure, this means there is a problem with Kconfig dependency, which
> > should be fixed properly, not hidden.
>
> Here is build failure log:
> MODPOST vmlinux.o
> WARNING: modpost: Found 1 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save'
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save'
> arch/arm/mach-omap2/built-in.o: In function `configure_vc':
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init'
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init'
> make: *** [.tmp_vmlinux1] Error 1
>
> The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c
so the right fix would be to change the ifdef to something saner.
Probably on the header file something like:
#if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
--
balbi
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 9:00 ` G, Manjunath Kondaiah
2009-11-02 9:14 ` Felipe Balbi
@ 2009-11-02 9:17 ` Artem Bityutskiy
1 sibling, 0 replies; 10+ messages in thread
From: Artem Bityutskiy @ 2009-11-02 9:17 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: linux-omap, khilman
On Mon, 2009-11-02 at 14:30 +0530, G, Manjunath Kondaiah wrote:
> > > --- a/arch/arm/configs/omap_zoom2_defconfig
> > > +++ b/arch/arm/configs/omap_zoom2_defconfig
> > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> > > CONFIG_FRAME_WARN=1024
> > > CONFIG_MAGIC_SYSRQ=y
> > > # CONFIG_UNUSED_SYMBOLS is not set
> > > -# CONFIG_DEBUG_FS is not set
> > > +CONFIG_DEBUG_FS=y
> > > # CONFIG_HEADERS_CHECK is not set
> > > CONFIG_DEBUG_KERNEL=y
> > > # CONFIG_DEBUG_SHIRQ is not set
> >
> > It is nicer to provide the build failure log. But if this is a build
> > failure, this means there is a problem with Kconfig dependency, which
> > should be fixed properly, not hidden.
>
> Here is build failure log:
> MODPOST vmlinux.o
> WARNING: modpost: Found 1 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save'
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save'
> arch/arm/mach-omap2/built-in.o: In function `configure_vc':
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init'
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init'
> make: *** [.tmp_vmlinux1] Error 1
>
> The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c
OK, but why do you send a band-aid to fix this, instead of a real fix?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 9:14 ` Felipe Balbi
@ 2009-11-02 10:00 ` G, Manjunath Kondaiah
2009-11-02 16:09 ` Kevin Hilman
0 siblings, 1 reply; 10+ messages in thread
From: G, Manjunath Kondaiah @ 2009-11-02 10:00 UTC (permalink / raw)
To: felipe.balbi; +Cc: dedekind1, linux-omap, khilman
> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> Sent: Monday, November 02, 2009 2:44 PM
> To: G, Manjunath Kondaiah
> Cc: dedekind1@gmail.com; linux-omap@vger.kernel.org;
> khilman@deeprootsystems.com
> Subject: Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
>
> On Mon, Nov 02, 2009 at 10:00:23AM +0100, ext G, Manjunath
> Kondaiah wrote:
> >
> > > > --- a/arch/arm/configs/omap_zoom2_defconfig
> > > > +++ b/arch/arm/configs/omap_zoom2_defconfig
> > > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
> > > > CONFIG_FRAME_WARN=1024
> > > > CONFIG_MAGIC_SYSRQ=y
> > > > # CONFIG_UNUSED_SYMBOLS is not set
> > > > -# CONFIG_DEBUG_FS is not set
> > > > +CONFIG_DEBUG_FS=y
> > > > # CONFIG_HEADERS_CHECK is not set
> > > > CONFIG_DEBUG_KERNEL=y
> > > > # CONFIG_DEBUG_SHIRQ is not set
> > >
> > > It is nicer to provide the build failure log. But if this
> is a build
> > > failure, this means there is a problem with Kconfig
> dependency, which
> > > should be fixed properly, not hidden.
> >
> > Here is build failure log:
> > MODPOST vmlinux.o
> > WARNING: modpost: Found 1 section mismatch(es).
> > To see full details build your kernel with:
> > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > GEN .version
> > CHK include/linux/compile.h
> > UPD include/linux/compile.h
> > CC init/version.o
> > LD init/built-in.o
> > LD .tmp_vmlinux1
> > arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
> >
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
> x.c:441: undefined reference to `pm_dbg_regset_save'
> >
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
> x.c:452: undefined reference to `pm_dbg_regset_save'
> > arch/arm/mach-omap2/built-in.o: In function `configure_vc':
> >
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
> x.c:1226: undefined reference to `pm_dbg_regset_init'
> >
> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
> x.c:1227: undefined reference to `pm_dbg_regset_init'
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > The above two API's are under CONFIG_DEBUG_FS flag in
> arch/arm/mach-omap2/pm-debug.c
>
> so the right fix would be to change the ifdef to something saner.
> Probably on the header file something like:
>
> #if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
>
Thanks for review comments. I have handled the same thing in pm-debug.c.
Here is code snippet. Now it compiles even without enabling CONFIG_DEBUG_FS.
I will submit this patch if there are no comments for this rework.
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 767ebbc..3a42615 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
#else
void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
+int pm_dbg_regset_init(int reg_set) {}
+int pm_dbg_regset_save(int reg_set) {}
#endif
> --
> balbi
>
>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 10:00 ` G, Manjunath Kondaiah
@ 2009-11-02 16:09 ` Kevin Hilman
2009-11-02 16:30 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 10+ messages in thread
From: Kevin Hilman @ 2009-11-02 16:09 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: felipe.balbi, dedekind1, linux-omap
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
>> -----Original Message-----
>> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
>> Sent: Monday, November 02, 2009 2:44 PM
>> To: G, Manjunath Kondaiah
>> Cc: dedekind1@gmail.com; linux-omap@vger.kernel.org;
>> khilman@deeprootsystems.com
>> Subject: Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
>>
>> On Mon, Nov 02, 2009 at 10:00:23AM +0100, ext G, Manjunath
>> Kondaiah wrote:
>> >
>> > > > --- a/arch/arm/configs/omap_zoom2_defconfig
>> > > > +++ b/arch/arm/configs/omap_zoom2_defconfig
>> > > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y
>> > > > CONFIG_FRAME_WARN=1024
>> > > > CONFIG_MAGIC_SYSRQ=y
>> > > > # CONFIG_UNUSED_SYMBOLS is not set
>> > > > -# CONFIG_DEBUG_FS is not set
>> > > > +CONFIG_DEBUG_FS=y
>> > > > # CONFIG_HEADERS_CHECK is not set
>> > > > CONFIG_DEBUG_KERNEL=y
>> > > > # CONFIG_DEBUG_SHIRQ is not set
>> > >
>> > > It is nicer to provide the build failure log. But if this
>> is a build
>> > > failure, this means there is a problem with Kconfig
>> dependency, which
>> > > should be fixed properly, not hidden.
>> >
>> > Here is build failure log:
>> > MODPOST vmlinux.o
>> > WARNING: modpost: Found 1 section mismatch(es).
>> > To see full details build your kernel with:
>> > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> > GEN .version
>> > CHK include/linux/compile.h
>> > UPD include/linux/compile.h
>> > CC init/version.o
>> > LD init/built-in.o
>> > LD .tmp_vmlinux1
>> > arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle':
>> >
>> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
>> x.c:441: undefined reference to `pm_dbg_regset_save'
>> >
>> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
>> x.c:452: undefined reference to `pm_dbg_regset_save'
>> > arch/arm/mach-omap2/built-in.o: In function `configure_vc':
>> >
>> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
>> x.c:1226: undefined reference to `pm_dbg_regset_init'
>> >
>> /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34x
>> x.c:1227: undefined reference to `pm_dbg_regset_init'
>> > make: *** [.tmp_vmlinux1] Error 1
>> >
>> > The above two API's are under CONFIG_DEBUG_FS flag in
>> arch/arm/mach-omap2/pm-debug.c
>>
>> so the right fix would be to change the ifdef to something saner.
>> Probably on the header file something like:
>>
>> #if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
>>
>
> Thanks for review comments. I have handled the same thing in pm-debug.c.
> Here is code snippet. Now it compiles even without enabling CONFIG_DEBUG_FS.
> I will submit this patch if there are no comments for this rework.
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 767ebbc..3a42615 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
>
> #else
> void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
> +int pm_dbg_regset_init(int reg_set) {}
> +int pm_dbg_regset_save(int reg_set) {}
you'll get compiler warnings from these.
> #endif
but even there, this should be fixed in pm.h. The current PM branch
has these defines already:
#define pm_dbg_regset_save(reg_set) do {} while (0);
#define pm_dbg_regset_init(reg_set) do {} while (0);
It would be cleaner to fix the #ifdef there to handle the
!CONFIG_DEBUG_FS case.
Kevin
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 16:09 ` Kevin Hilman
@ 2009-11-02 16:30 ` G, Manjunath Kondaiah
2009-11-02 17:10 ` Kevin Hilman
0 siblings, 1 reply; 10+ messages in thread
From: G, Manjunath Kondaiah @ 2009-11-02 16:30 UTC (permalink / raw)
To: Kevin Hilman; +Cc: felipe.balbi, dedekind1, linux-omap
> > diff --git a/arch/arm/mach-omap2/pm-debug.c
> b/arch/arm/mach-omap2/pm-debug.c
> > index 767ebbc..3a42615 100644
> > --- a/arch/arm/mach-omap2/pm-debug.c
> > +++ b/arch/arm/mach-omap2/pm-debug.c
> > @@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
> >
> > #else
> > void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
> > +int pm_dbg_regset_init(int reg_set) {}
> > +int pm_dbg_regset_save(int reg_set) {}
>
> you'll get compiler warnings from these.
Can be changed to return with value zero for these API's.
>
> > #endif
>
> but even there, this should be fixed in pm.h. The current PM branch
> has these defines already:
>
> #define pm_dbg_regset_save(reg_set) do {} while (0);
> #define pm_dbg_regset_init(reg_set) do {} while (0);
>
> It would be cleaner to fix the #ifdef there to handle the
> !CONFIG_DEBUG_FS case.
pm branch has else condition for CONFIG_PM_DEBUG. But, CONFIG_DEBUG_FS
is not handled. As there is already similar API - pm_dbg_update_time in
pm_debug.c, these API's can also fit there. More over, using !CONFIG_DEBUG_FS
will add some #ifdef's in header.
-Manjunath
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build
2009-11-02 16:30 ` G, Manjunath Kondaiah
@ 2009-11-02 17:10 ` Kevin Hilman
0 siblings, 0 replies; 10+ messages in thread
From: Kevin Hilman @ 2009-11-02 17:10 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: felipe.balbi, dedekind1, linux-omap
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
>> > diff --git a/arch/arm/mach-omap2/pm-debug.c
>> b/arch/arm/mach-omap2/pm-debug.c
>> > index 767ebbc..3a42615 100644
>> > --- a/arch/arm/mach-omap2/pm-debug.c
>> > +++ b/arch/arm/mach-omap2/pm-debug.c
>> > @@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
>> >
>> > #else
>> > void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
>> > +int pm_dbg_regset_init(int reg_set) {}
>> > +int pm_dbg_regset_save(int reg_set) {}
>>
>> you'll get compiler warnings from these.
>
> Can be changed to return with value zero for these API's.
>
>>
>> > #endif
>>
>> but even there, this should be fixed in pm.h. The current PM branch
>> has these defines already:
>>
>> #define pm_dbg_regset_save(reg_set) do {} while (0);
>> #define pm_dbg_regset_init(reg_set) do {} while (0);
>>
>> It would be cleaner to fix the #ifdef there to handle the
>> !CONFIG_DEBUG_FS case.
>
> pm branch has else condition for CONFIG_PM_DEBUG. But, CONFIG_DEBUG_FS
> is not handled.
I know, my proposal is to handle the DEBUG_FS case there also.
> As there is already similar API - pm_dbg_update_time in pm_debug.c,
> these API's can also fit there. More over, using !CONFIG_DEBUG_FS
> will add some #ifdef's in header.
So handle the pm_dbg_update_time() in the header as well.
Handling them in the header will also eliminate the runtime overhead
of an empty function call when DEBUG_FS is not included.
Kevin
<
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-11-02 17:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-02 7:56 [PATCH] [OMAP3_PM] Fix zoom2 defconfig build manjugk
2009-11-02 7:59 ` G, Manjunath Kondaiah
2009-11-02 8:26 ` Artem Bityutskiy
2009-11-02 9:00 ` G, Manjunath Kondaiah
2009-11-02 9:14 ` Felipe Balbi
2009-11-02 10:00 ` G, Manjunath Kondaiah
2009-11-02 16:09 ` Kevin Hilman
2009-11-02 16:30 ` G, Manjunath Kondaiah
2009-11-02 17:10 ` Kevin Hilman
2009-11-02 9:17 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.