All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] leds: add exit function to cobalt-raq led.
@ 2009-11-07 17:50 Thiago Farina
  2009-11-07 23:45 ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: Thiago Farina @ 2009-11-07 17:50 UTC (permalink / raw)
  To: linux-kernel; +Cc: rpurdie, gregkh, yuasa, ralf, Thiago Farina

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 drivers/leds/leds-cobalt-raq.c |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/leds/leds-cobalt-raq.c b/drivers/leds/leds-cobalt-raq.c
index defc212..e43fcb2 100644
--- a/drivers/leds/leds-cobalt-raq.c
+++ b/drivers/leds/leds-cobalt-raq.c
@@ -135,4 +135,15 @@ static int __init cobalt_raq_led_init(void)
 	return platform_driver_register(&cobalt_raq_led_driver);
 }
 
+static void __exit cobalt_raq_led_exit(void)
+{
+	platform_driver_unregister(&cobalt_raq_led_driver);
+}
+
 module_init(cobalt_raq_led_init);
+module_exit(cobalt_raq_led_exit);
+
+MODULE_AUTHOR("Yoichi Yuasa <yuasa@linux-mips.org>");
+MODULE_DESCRIPTION("LEDs driver for the Cobalt Raq series.");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:cobalt-raq-leds");
-- 
1.6.5.2.150.g1b52a


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] leds: add exit function to cobalt-raq led.
  2009-11-07 17:50 [PATCH] leds: add exit function to cobalt-raq led Thiago Farina
@ 2009-11-07 23:45 ` Ralf Baechle
  2009-11-07 23:56   ` Thiago Farina
  0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2009-11-07 23:45 UTC (permalink / raw)
  To: Thiago Farina; +Cc: linux-kernel, rpurdie, gregkh, yuasa

On Sat, Nov 07, 2009 at 12:50:35PM -0500, Thiago Farina wrote:

This driver has no exit function because it cannot be built as a module.
I've not reviewed the driver in detail but at the very least the
LEDS_COBALT_RAQ Kconfig statement for the driver would need to be changed
to tristate before this patch makes any sense.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] leds: add exit function to cobalt-raq led.
  2009-11-07 23:45 ` Ralf Baechle
@ 2009-11-07 23:56   ` Thiago Farina
  0 siblings, 0 replies; 3+ messages in thread
From: Thiago Farina @ 2009-11-07 23:56 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-kernel, rpurdie, gregkh, yuasa

On Sat, Nov 7, 2009 at 9:45 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Sat, Nov 07, 2009 at 12:50:35PM -0500, Thiago Farina wrote:
>
> This driver has no exit function because it cannot be built as a module.
> I've not reviewed the driver in detail but at the very least the
> LEDS_COBALT_RAQ Kconfig statement for the driver would need to be changed
> to tristate before this patch makes any sense.

According to this thread:
"Therefore, this driver is not tristate."
http://lkml.org/lkml/2007/9/13/377

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-07 23:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-07 17:50 [PATCH] leds: add exit function to cobalt-raq led Thiago Farina
2009-11-07 23:45 ` Ralf Baechle
2009-11-07 23:56   ` Thiago Farina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.