All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request
@ 2009-11-09  0:02 Jason Andryuk
  2009-11-10  8:00 ` Kalle Valo
  2009-11-11 21:47 ` John W. Linville
  0 siblings, 2 replies; 3+ messages in thread
From: Jason Andryuk @ 2009-11-09  0:02 UTC (permalink / raw)
  To: linux-wireless; +Cc: Kalle Valo

For my Linksys WUSB11 at76c503-i3861 device, scanning fails without
probe_delay, min_channel_time, and max_channel_time specified for the
scan request.  These values were found by checking scan requests from
the at76_usb driver.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
--
Prior to this patch, the driver did not produce any scan results on my device.


diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x
index d9f2c52..4a3f4ff 100644
--- a/drivers/net/wireless/at76c50x-usb.c
+++ b/drivers/net/wireless/at76c50x-usb.c
@@ -1180,6 +1180,9 @@ static int at76_start_monitor(struct at76_priv *priv)
        scan.channel = priv->channel;
        scan.scan_type = SCAN_TYPE_PASSIVE;
        scan.international_scan = 0;
+       scan.min_channel_time = cpu_to_le16(priv->scan_min_time);
+       scan.max_channel_time = cpu_to_le16(priv->scan_max_time);
+       scan.probe_delay = cpu_to_le16(0);
 
        ret = at76_set_card_command(priv->udev, CMD_SCAN, &scan, sizeof(scan));
        if (ret >= 0)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request
  2009-11-09  0:02 [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request Jason Andryuk
@ 2009-11-10  8:00 ` Kalle Valo
  2009-11-11 21:47 ` John W. Linville
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2009-11-10  8:00 UTC (permalink / raw)
  To: Jason Andryuk; +Cc: linux-wireless

Jason Andryuk <jandryuk@gmail.com> writes:

> For my Linksys WUSB11 at76c503-i3861 device, scanning fails without
> probe_delay, min_channel_time, and max_channel_time specified for the
> scan request.  These values were found by checking scan requests from
> the at76_usb driver.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Thank you for finding this.

Acked-by: Kalle Valo <kalle.valo@iki.fi>

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request
  2009-11-09  0:02 [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request Jason Andryuk
  2009-11-10  8:00 ` Kalle Valo
@ 2009-11-11 21:47 ` John W. Linville
  1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2009-11-11 21:47 UTC (permalink / raw)
  To: Jason Andryuk; +Cc: linux-wireless, Kalle Valo

On Sun, Nov 08, 2009 at 07:02:19PM -0500, Jason Andryuk wrote:
> For my Linksys WUSB11 at76c503-i3861 device, scanning fails without
> probe_delay, min_channel_time, and max_channel_time specified for the
> scan request.  These values were found by checking scan requests from
> the at76_usb driver.
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> --
> Prior to this patch, the driver did not produce any scan results on my device.
> 
> 
> diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x
> index d9f2c52..4a3f4ff 100644
> --- a/drivers/net/wireless/at76c50x-usb.c
> +++ b/drivers/net/wireless/at76c50x-usb.c
> @@ -1180,6 +1180,9 @@ static int at76_start_monitor(struct at76_priv *priv)
>         scan.channel = priv->channel;
>         scan.scan_type = SCAN_TYPE_PASSIVE;
>         scan.international_scan = 0;
> +       scan.min_channel_time = cpu_to_le16(priv->scan_min_time);
> +       scan.max_channel_time = cpu_to_le16(priv->scan_max_time);
> +       scan.probe_delay = cpu_to_le16(0);
>  
>         ret = at76_set_card_command(priv->udev, CMD_SCAN, &scan, sizeof(scan));
>         if (ret >= 0)

This patch was whitespace-damaged.  I've manually fixed it, but please
adjust your mailer appropriate for any future patches...

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-11 22:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-09  0:02 [PATCH] at76c50x-usb: Supply additional parameters to at76_start_monitor scan request Jason Andryuk
2009-11-10  8:00 ` Kalle Valo
2009-11-11 21:47 ` John W. Linville

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.