From: Wu Zhangjin <wuzhangjin@gmail.com> To: Frederic Weisbecker <fweisbec@gmail.com> Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, Ralf Baechle <ralf@linux-mips.org>, Richard Sandiford <rdsandiford@googlemail.com>, Nicholas Mc Guire <der.herr@hofr.at>, David Daney <ddaney@caviumnetworks.com>, Adam Nemet <anemet@caviumnetworks.com>, Patrik Kluba <kpajko79@gmail.com>, Ralf Baechle <ralf@linux-mips.org> Subject: Re: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS Date: Mon, 09 Nov 2009 11:31:08 +0800 [thread overview] Message-ID: <1257737468.3451.9.camel@falcon.domain.org> (raw) In-Reply-To: <20091109022640.GC13153@nowhere> Hi, On Mon, 2009-11-09 at 03:26 +0100, Frederic Weisbecker wrote: > On Mon, Oct 26, 2009 at 11:13:25PM +0800, Wu Zhangjin wrote: > > This patch add a new section for MIPS to record the block of the hardirq > > handling for function graph tracer(print_graph_irq) via adding the > > __irq_entry annotation to the the entrypoints of the hardirqs(the block > > with irq_enter()...irq_exit()). > > > > Thanks goes to Steven & Frederic Weisbecker for their feedbacks. > > > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> > > + > > +/* > > + * do_IRQ handles all normal device IRQ's (the special > > + * SMP cross-CPU interrupts have their own specific > > + * handlers). > > + */ > > +unsigned int __irq_entry do_IRQ(unsigned int irq) > > +{ > > + irq_enter(); > > + __DO_IRQ_SMTC_HOOK(irq); > > + generic_handle_irq(irq); > > + irq_exit(); > > + > > + return 1; > > +} > > > > Nano-neat: > > Why is it returning a value, it doesn't seem needed (the macro > version didn't)? > Will remove it later. > Anyway, that looks good to me. I hope the changes from macro > to function calls will be ack by the MIPS maintainers. > Hope Ralf give some feedbacks about it ;) > Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com> > Thanks! BTW: Who should I resend this patchset to? you or Steven? If this patchset are okay, I will rebase it on the latest tracing/core branch of -tip and send the latest version out, and hope you can apply it, otherwise, I need to rebase it to the future mainline versions again and again ;) and at least, I have tested all of them and their combinations on YeeLoong netbook, they work well. of course, more testing report from the other MIPS developers are welcome ;) Regards, Wu Zhangjin
WARNING: multiple messages have this Message-ID (diff)
From: Wu Zhangjin <wuzhangjin@gmail.com> To: Frederic Weisbecker <fweisbec@gmail.com> Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>, Ralf Baechle <ralf@linux-mips.org>, Richard Sandiford <rdsandiford@googlemail.com>, Nicholas Mc Guire <der.herr@hofr.at>, David Daney <ddaney@caviumnetworks.com>, Adam Nemet <anemet@caviumnetworks.com>, Patrik Kluba <kpajko79@gmail.com>Ralf Baechle <ralf@linux-mips.org> Subject: Re: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS Date: Mon, 09 Nov 2009 11:31:08 +0800 [thread overview] Message-ID: <1257737468.3451.9.camel@falcon.domain.org> (raw) Message-ID: <20091109033108.Py_o3_fayCxS9T0DHxGnv1clbMmv4AotjnNuCBrnrrw@z> (raw) In-Reply-To: <20091109022640.GC13153@nowhere> Hi, On Mon, 2009-11-09 at 03:26 +0100, Frederic Weisbecker wrote: > On Mon, Oct 26, 2009 at 11:13:25PM +0800, Wu Zhangjin wrote: > > This patch add a new section for MIPS to record the block of the hardirq > > handling for function graph tracer(print_graph_irq) via adding the > > __irq_entry annotation to the the entrypoints of the hardirqs(the block > > with irq_enter()...irq_exit()). > > > > Thanks goes to Steven & Frederic Weisbecker for their feedbacks. > > > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> > > + > > +/* > > + * do_IRQ handles all normal device IRQ's (the special > > + * SMP cross-CPU interrupts have their own specific > > + * handlers). > > + */ > > +unsigned int __irq_entry do_IRQ(unsigned int irq) > > +{ > > + irq_enter(); > > + __DO_IRQ_SMTC_HOOK(irq); > > + generic_handle_irq(irq); > > + irq_exit(); > > + > > + return 1; > > +} > > > > Nano-neat: > > Why is it returning a value, it doesn't seem needed (the macro > version didn't)? > Will remove it later. > Anyway, that looks good to me. I hope the changes from macro > to function calls will be ack by the MIPS maintainers. > Hope Ralf give some feedbacks about it ;) > Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com> > Thanks! BTW: Who should I resend this patchset to? you or Steven? If this patchset are okay, I will rebase it on the latest tracing/core branch of -tip and send the latest version out, and hope you can apply it, otherwise, I need to rebase it to the future mainline versions again and again ;) and at least, I have tested all of them and their combinations on YeeLoong netbook, they work well. of course, more testing report from the other MIPS developers are welcome ;) Regards, Wu Zhangjin
next prev parent reply other threads:[~2009-11-09 3:31 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-26 15:13 [PATCH -v6 00/13] ftrace for MIPS Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 01/13] tracing: convert trace_clock_local() as weak function Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 02/13] tracing: add mips_timecounter_read() for MIPS Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 03/13] tracing: add MIPS specific trace_clock_local() Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 04/13] tracing: add static function tracer support for MIPS Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 05/13] tracing: enable HAVE_FUNCTION_TRACE_MCOUNT_TEST " Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 06/13] tracing: add an endian argument to scripts/recordmcount.pl Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 07/13] tracing: add dynamic function tracer support for MIPS Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section " Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 09/13] tracing: Add __arch_notrace for arch specific requirement Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 10/13] tracing: not trace the timecounter_read* in kernel/time/clocksource.c Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 11/13] tracing: not trace mips_timecounter_read() for MIPS Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 12/13] tracing: add function graph tracer support " Wu Zhangjin 2009-10-26 15:13 ` [PATCH -v6 13/13] tracing: add dynamic function graph tracer " Wu Zhangjin 2009-11-09 2:26 ` [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section " Frederic Weisbecker 2009-11-09 3:31 ` Wu Zhangjin [this message] 2009-11-09 3:31 ` Wu Zhangjin 2009-11-09 11:36 ` Frederic Weisbecker 2009-11-09 12:46 ` Steven Rostedt 2009-11-09 12:48 ` Steven Rostedt 2009-11-09 4:16 ` Wu Zhangjin 2009-10-26 16:06 ` [PATCH -v6 07/13] tracing: add dynamic function tracer support " Steven Rostedt 2009-10-26 16:35 ` Wu Zhangjin 2009-10-26 16:45 ` Steven Rostedt 2009-10-26 17:35 ` Wu Zhangjin 2009-10-26 15:41 ` [PATCH -v6 05/13] tracing: enable HAVE_FUNCTION_TRACE_MCOUNT_TEST " Sergei Shtylyov 2009-10-26 15:57 ` Steven Rostedt 2009-10-26 15:57 ` Steven Rostedt 2009-10-26 16:16 ` Wu Zhangjin 2009-11-09 4:15 ` [PATCH -v6 02/13] tracing: add mips_timecounter_read() " Wu Zhangjin 2009-11-09 4:15 ` Wu Zhangjin 2009-11-09 2:10 ` [PATCH -v6 01/13] tracing: convert trace_clock_local() as weak function Frederic Weisbecker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1257737468.3451.9.camel@falcon.domain.org \ --to=wuzhangjin@gmail.com \ --cc=anemet@caviumnetworks.com \ --cc=ddaney@caviumnetworks.com \ --cc=der.herr@hofr.at \ --cc=fweisbec@gmail.com \ --cc=kpajko79@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=ralf@linux-mips.org \ --cc=rdsandiford@googlemail.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.