* [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()
@ 2009-11-10 16:40 ` Ali Gholami Rudi
0 siblings, 0 replies; 4+ messages in thread
From: Ali Gholami Rudi @ 2009-11-10 16:40 UTC (permalink / raw)
To: David S. Miller
Cc: netdev, linux-kernel, e1000-devel, Jeff Kirsher,
Jesse Brandeburg, Bruce Allan, PJ Waskiewicz, John Ronciak
The values of r_idx and rx_ring are not used after the last time they
are set in ixgbe_msix_clean_rx(), so they can be removed.
Signed-off-by: Ali Gholami Rudi <ali@rudi.ir>
---
drivers/net/ixgbe/ixgbe_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 5bd9e6b..6541c80 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
if (!q_vector->rxr_count)
return IRQ_HANDLED;
- r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
- rx_ring = &(adapter->rx_ring[r_idx]);
/* disable interrupts on this vector only */
ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
napi_schedule(&q_vector->napi);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()
@ 2009-11-10 16:40 ` Ali Gholami Rudi
0 siblings, 0 replies; 4+ messages in thread
From: Ali Gholami Rudi @ 2009-11-10 16:40 UTC (permalink / raw)
To: David S. Miller
Cc: e1000-devel, netdev, Bruce Allan, Jesse Brandeburg, linux-kernel,
John Ronciak, Jeff Kirsher
The values of r_idx and rx_ring are not used after the last time they
are set in ixgbe_msix_clean_rx(), so they can be removed.
Signed-off-by: Ali Gholami Rudi <ali@rudi.ir>
---
drivers/net/ixgbe/ixgbe_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 5bd9e6b..6541c80 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
if (!q_vector->rxr_count)
return IRQ_HANDLED;
- r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
- rx_ring = &(adapter->rx_ring[r_idx]);
/* disable interrupts on this vector only */
ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
napi_schedule(&q_vector->napi);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()
2009-11-10 16:40 ` Ali Gholami Rudi
@ 2009-11-10 16:45 ` Peter P Waskiewicz Jr
-1 siblings, 0 replies; 4+ messages in thread
From: Peter P Waskiewicz Jr @ 2009-11-10 16:45 UTC (permalink / raw)
To: Ali Gholami Rudi
Cc: David S. Miller, netdev, linux-kernel, e1000-devel, Kirsher,
Jeffrey T, Brandeburg, Jesse, Allan, Bruce W, Ronciak, John
On Tue, 2009-11-10 at 08:40 -0800, Ali Gholami Rudi wrote:
> The values of r_idx and rx_ring are not used after the last time they
> are set in ixgbe_msix_clean_rx(), so they can be removed.
>
Thanks for cleaning this up.
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Ali Gholami Rudi <ali@rudi.ir>
> ---
> drivers/net/ixgbe/ixgbe_main.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 5bd9e6b..6541c80 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
> if (!q_vector->rxr_count)
> return IRQ_HANDLED;
>
> - r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
> - rx_ring = &(adapter->rx_ring[r_idx]);
> /* disable interrupts on this vector only */
> ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
> napi_schedule(&q_vector->napi);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()
@ 2009-11-10 16:45 ` Peter P Waskiewicz Jr
0 siblings, 0 replies; 4+ messages in thread
From: Peter P Waskiewicz Jr @ 2009-11-10 16:45 UTC (permalink / raw)
To: Ali Gholami Rudi
Cc: e1000-devel, netdev, Allan, Bruce W, Brandeburg, Jesse,
linux-kernel, Ronciak, John, Kirsher, Jeffrey T, David S. Miller
On Tue, 2009-11-10 at 08:40 -0800, Ali Gholami Rudi wrote:
> The values of r_idx and rx_ring are not used after the last time they
> are set in ixgbe_msix_clean_rx(), so they can be removed.
>
Thanks for cleaning this up.
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Ali Gholami Rudi <ali@rudi.ir>
> ---
> drivers/net/ixgbe/ixgbe_main.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 5bd9e6b..6541c80 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
> if (!q_vector->rxr_count)
> return IRQ_HANDLED;
>
> - r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
> - rx_ring = &(adapter->rx_ring[r_idx]);
> /* disable interrupts on this vector only */
> ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
> napi_schedule(&q_vector->napi);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-10 16:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 16:40 [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx() Ali Gholami Rudi
2009-11-10 16:40 ` Ali Gholami Rudi
2009-11-10 16:45 ` Peter P Waskiewicz Jr
2009-11-10 16:45 ` Peter P Waskiewicz Jr
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.