* [PATCH] powerpc: _exception: kill the obsolete code under is_global_init()
@ 2009-11-10 0:25 Oleg Nesterov
2009-11-11 1:12 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2009-11-10 0:25 UTC (permalink / raw)
To: Andrew Morton
Cc: Benjamin Herrenschmidt, Geert Uytterhoeven, Kumar Gala, Liu Yu,
Roland McGrath, linux-kernel
The code under "if (is_global_init())" is bogus, and is_global_init()
itself is not right in mt case.
Contrary to what the comment says, nowadays force_sig_info() does kill
init even if the handler is SIG_DFL. Note that force_sig_info() clears
SIGNAL_UNKILLABLE exactly for this case.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
arch/powerpc/kernel/traps.c | 22 ----------------------
1 file changed, 22 deletions(-)
--- TH/arch/powerpc/kernel/traps.c~PPC_EXCEPTION_DONT_CK_INIT 2009-11-10 01:03:23.000000000 +0100
+++ TH/arch/powerpc/kernel/traps.c 2009-11-10 01:06:41.000000000 +0100
@@ -198,28 +198,6 @@ void _exception(int signr, struct pt_reg
info.si_code = code;
info.si_addr = (void __user *) addr;
force_sig_info(signr, &info, current);
-
- /*
- * Init gets no signals that it doesn't have a handler for.
- * That's all very well, but if it has caused a synchronous
- * exception and we ignore the resulting signal, it will just
- * generate the same exception over and over again and we get
- * nowhere. Better to kill it and let the kernel panic.
- */
- if (is_global_init(current)) {
- __sighandler_t handler;
-
- spin_lock_irq(¤t->sighand->siglock);
- handler = current->sighand->action[signr-1].sa.sa_handler;
- spin_unlock_irq(¤t->sighand->siglock);
- if (handler == SIG_DFL) {
- /* init has generated a synchronous exception
- and it doesn't have a handler for the signal */
- printk(KERN_CRIT "init has generated signal %d "
- "but has no handler for it\n", signr);
- do_exit(signr);
- }
- }
}
#ifdef CONFIG_PPC64
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: _exception: kill the obsolete code under is_global_init()
2009-11-10 0:25 [PATCH] powerpc: _exception: kill the obsolete code under is_global_init() Oleg Nesterov
@ 2009-11-11 1:12 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-11-11 1:12 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andrew Morton, Geert Uytterhoeven, Kumar Gala, Liu Yu,
Roland McGrath, linux-kernel
On Tue, 2009-11-10 at 01:25 +0100, Oleg Nesterov wrote:
> The code under "if (is_global_init())" is bogus, and is_global_init()
> itself is not right in mt case.
>
> Contrary to what the comment says, nowadays force_sig_info() does kill
> init even if the handler is SIG_DFL. Note that force_sig_info() clears
> SIGNAL_UNKILLABLE exactly for this case.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
Thanks. I'll take that one.
Cheers,
Ben.
> arch/powerpc/kernel/traps.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> --- TH/arch/powerpc/kernel/traps.c~PPC_EXCEPTION_DONT_CK_INIT 2009-11-10 01:03:23.000000000 +0100
> +++ TH/arch/powerpc/kernel/traps.c 2009-11-10 01:06:41.000000000 +0100
> @@ -198,28 +198,6 @@ void _exception(int signr, struct pt_reg
> info.si_code = code;
> info.si_addr = (void __user *) addr;
> force_sig_info(signr, &info, current);
> -
> - /*
> - * Init gets no signals that it doesn't have a handler for.
> - * That's all very well, but if it has caused a synchronous
> - * exception and we ignore the resulting signal, it will just
> - * generate the same exception over and over again and we get
> - * nowhere. Better to kill it and let the kernel panic.
> - */
> - if (is_global_init(current)) {
> - __sighandler_t handler;
> -
> - spin_lock_irq(¤t->sighand->siglock);
> - handler = current->sighand->action[signr-1].sa.sa_handler;
> - spin_unlock_irq(¤t->sighand->siglock);
> - if (handler == SIG_DFL) {
> - /* init has generated a synchronous exception
> - and it doesn't have a handler for the signal */
> - printk(KERN_CRIT "init has generated signal %d "
> - "but has no handler for it\n", signr);
> - do_exit(signr);
> - }
> - }
> }
>
> #ifdef CONFIG_PPC64
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-11 1:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 0:25 [PATCH] powerpc: _exception: kill the obsolete code under is_global_init() Oleg Nesterov
2009-11-11 1:12 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.