[PATCH] drm/radeon/kms: Add default 800x600 mode when getting bad EDID

[PATCH] drm/radeon/kms: Add default 800x600 mode when getting bad EDID

[Jerome Glisse]

Adding default 800x600 mode should be a safe fail solution in front
of broken EDID, user can then add new mode to fit its needs.

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_connectors.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index 292b170..4dec82e 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -566,8 +566,10 @@ static enum drm_connector_status radeon_vga_detect(struct drm_connector *connect
 		radeon_i2c_do_lock(radeon_connector, 0);
 
 		if (!radeon_connector->edid) {
-			DRM_ERROR("DDC responded but not EDID found for %s\n",
+			DRM_ERROR("DDC responded but not EDID found for %s, adding default mode\n",
 				  drm_get_connector_name(connector));
+			if (!drm_add_modes_noedid(&radeon_connector->base, 800, 600))
+				ret = connector_status_connected;
 		} else {
 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 
@@ -720,8 +722,10 @@ static enum drm_connector_status radeon_dvi_detect(struct drm_connector *connect
 		radeon_i2c_do_lock(radeon_connector, 0);
 
 		if (!radeon_connector->edid) {
-			DRM_ERROR("DDC responded but not EDID found for %s\n",
+			DRM_ERROR("DDC responded but not EDID found for %s, adding default mode\n",
 				  drm_get_connector_name(connector));
+			if (!drm_add_modes_noedid(&radeon_connector->base, 800, 600))
+				ret = connector_status_connected;
 		} else {
 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 
-- 
1.6.5.2

Re: [PATCH] drm/radeon/kms: Add default 800x600 mode when getting bad EDID

[Jerome Glisse]

On Thu, 2009-11-12 at 10:09 +0100, Jerome Glisse wrote:
> Adding default 800x600 mode should be a safe fail solution in front
> of broken EDID, user can then add new mode to fit its needs.
> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>

Forget this patch a better one is coming.

Cheers,
Jerome Glisse