* [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
@ 2009-11-17 7:52 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2009-11-17 7:52 UTC (permalink / raw)
To: linux-arm-kernel, linux-samsung-soc, linux-mmc
Cc: m.szyprowski, kyungmin.park, ben-linux
From: Kyungmin Park <kyungmin.park@samsung.com>
Samsung S5PC100 SoC has SDHCI controller compatible to the one known from
S3C64xx SoCs. Enable support for sdhci-s3c driver also on S5PC1xx platform.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 432ae83..faddf82 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
config MMC_SDHCI_S3C
tristate "SDHCI support on Samsung S3C SoC"
- depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
+ depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX || PLAT_S5PC1XX)
help
This selects the Secure Digital Host Controller Interface (SDHCI)
often referrered to as the HSMMC block in some of the Samsung S3C
--
1.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
@ 2009-11-17 7:52 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2009-11-17 7:52 UTC (permalink / raw)
To: linux-arm-kernel
From: Kyungmin Park <kyungmin.park@samsung.com>
Samsung S5PC100 SoC has SDHCI controller compatible to the one known from
S3C64xx SoCs. Enable support for sdhci-s3c driver also on S5PC1xx platform.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 432ae83..faddf82 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
config MMC_SDHCI_S3C
tristate "SDHCI support on Samsung S3C SoC"
- depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
+ depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX || PLAT_S5PC1XX)
help
This selects the Secure Digital Host Controller Interface (SDHCI)
often referrered to as the HSMMC block in some of the Samsung S3C
--
1.6.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
2009-11-17 7:52 ` Marek Szyprowski
@ 2009-11-17 11:11 ` Marc Zyngier
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2009-11-17 11:11 UTC (permalink / raw)
Cc: linux-arm-kernel, linux-samsung-soc, linux-mmc, kyungmin.park,
ben-linux, m.szyprowski
On Tue, 17 Nov 2009 08:52:54 +0100
Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Samsung S5PC100 SoC has SDHCI controller compatible to the one known
> from S3C64xx SoCs. Enable support for sdhci-s3c driver also on
> S5PC1xx platform.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 432ae83..faddf82 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
>
> config MMC_SDHCI_S3C
> tristate "SDHCI support on Samsung S3C SoC"
> - depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
> + depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX ||
> PLAT_S5PC1XX) help
> This selects the Secure Digital Host Controller Interface
> (SDHCI) often referrered to as the HSMMC block in some of the Samsung
> S3C
I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C
symbol, selected by interested parties (S3C, S5P, S5PC...).
Given the way Samsung SoCs are assembled (from an IP point of view), it
would make sense for one SoC to describe its features in
"HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever
growing list of SoC.
M.
--
Fast. Cheap. Reliable. Pick two.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
@ 2009-11-17 11:11 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2009-11-17 11:11 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 17 Nov 2009 08:52:54 +0100
Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Samsung S5PC100 SoC has SDHCI controller compatible to the one known
> from S3C64xx SoCs. Enable support for sdhci-s3c driver also on
> S5PC1xx platform.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 432ae83..faddf82 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -96,7 +96,7 @@ config MMC_SDHCI_PLTFM
>
> config MMC_SDHCI_S3C
> tristate "SDHCI support on Samsung S3C SoC"
> - depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
> + depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX ||
> PLAT_S5PC1XX) help
> This selects the Secure Digital Host Controller Interface
> (SDHCI) often referrered to as the HSMMC block in some of the Samsung
> S3C
I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C
symbol, selected by interested parties (S3C, S5P, S5PC...).
Given the way Samsung SoCs are assembled (from an IP point of view), it
would make sense for one SoC to describe its features in
"HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever
growing list of SoC.
M.
--
Fast. Cheap. Reliable. Pick two.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
2009-11-17 11:11 ` Marc Zyngier
@ 2009-11-17 13:01 ` Ben Dooks
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2009-11-17 13:01 UTC (permalink / raw)
To: Marc Zyngier
Cc: Marek Szyprowski, linux-arm-kernel, linux-samsung-soc, linux-mmc,
kyungmin.park, ben-linux
On Tue, Nov 17, 2009 at 12:11:43PM +0100, Marc Zyngier wrote:
> On Tue, 17 Nov 2009 08:52:54 +0100
> Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C
> symbol, selected by interested parties (S3C, S5P, S5PC...).
Yes, I did mention this and it is an option to either replace the patch
now or to do at a later date to tidy things up. I'm not going to reject
this patch now (or force a rewrite at this late stage)
I'll try and look at acking the last set of SDHCI patches Thomas sent
and see if akpm will pick them up for linux-mmc.
> Given the way Samsung SoCs are assembled (from an IP point of view), it
> would make sense for one SoC to describe its features in
> "HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever
> growing list of SoC.
Yes, I was feeling that this is something that we should probably discuss
either on linux-arm-kernel or to a wide audience. It might not suit
everyone's taste, etc.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform
@ 2009-11-17 13:01 ` Ben Dooks
0 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2009-11-17 13:01 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 17, 2009 at 12:11:43PM +0100, Marc Zyngier wrote:
> On Tue, 17 Nov 2009 08:52:54 +0100
> Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> I think it was Ben that suggested once to introduce a HAVE_SDHCI_S3C
> symbol, selected by interested parties (S3C, S5P, S5PC...).
Yes, I did mention this and it is an option to either replace the patch
now or to do at a later date to tidy things up. I'm not going to reject
this patch now (or force a rewrite at this late stage)
I'll try and look at acking the last set of SDHCI patches Thomas sent
and see if akpm will pick them up for linux-mmc.
> Given the way Samsung SoCs are assembled (from an IP point of view), it
> would make sense for one SoC to describe its features in
> "HAVE_FEATURE_FOO" terms rather than each subsystem depending an ever
> growing list of SoC.
Yes, I was feeling that this is something that we should probably discuss
either on linux-arm-kernel or to a wide audience. It might not suit
everyone's taste, etc.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-17 13:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-17 7:52 [PATCH] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform Marek Szyprowski
2009-11-17 7:52 ` Marek Szyprowski
2009-11-17 11:11 ` Marc Zyngier
2009-11-17 11:11 ` Marc Zyngier
2009-11-17 13:01 ` Ben Dooks
2009-11-17 13:01 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.