From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i3c@lists.infradead.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i3c: master: no need to iterate master device twice
Date: Tue, 18 Feb 2020 00:38:20 +0000 [thread overview]
Message-ID: <1258dbb3-f9f3-0d3e-77e0-094e6f1bc633@ideasonboard.com> (raw)
In-Reply-To: <20200214145853.24762-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On 14/02/2020 14:58, Wolfram Sang wrote:
> We already have the master device in a variable, reuse it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>
> Found while refactoring of_i2c_get_board_info() and checking its users.
>
> drivers/i3c/master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f8f896fa0c3..b56207bbed2b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(&master->dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.");
> return -ENOTSUPP;
> }
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i3c@lists.infradead.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i3c: master: no need to iterate master device twice
Date: Tue, 18 Feb 2020 00:38:20 +0000 [thread overview]
Message-ID: <1258dbb3-f9f3-0d3e-77e0-094e6f1bc633@ideasonboard.com> (raw)
In-Reply-To: <20200214145853.24762-1-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On 14/02/2020 14:58, Wolfram Sang wrote:
> We already have the master device in a variable, reuse it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>
> Found while refactoring of_i2c_get_board_info() and checking its users.
>
> drivers/i3c/master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f8f896fa0c3..b56207bbed2b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(&master->dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.");
> return -ENOTSUPP;
> }
>
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-02-18 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 14:58 [PATCH] i3c: master: no need to iterate master device twice Wolfram Sang
2020-02-14 14:58 ` Wolfram Sang
2020-02-14 15:22 ` Geert Uytterhoeven
2020-02-14 15:22 ` Geert Uytterhoeven
2020-02-17 10:43 ` Vitor Soares
2020-02-17 10:43 ` Vitor Soares
2020-02-17 11:29 ` Boris Brezillon
2020-02-17 11:29 ` Boris Brezillon
2020-02-17 11:18 ` Vitor Soares
2020-02-17 11:18 ` Vitor Soares
2020-02-18 0:38 ` Kieran Bingham [this message]
2020-02-18 0:38 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258dbb3-f9f3-0d3e-77e0-094e6f1bc633@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.