From: Dave Hansen <dave.hansen@intel.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: mingo@kernel.org, tglx@linutronix.de, gregkh@linuxfoundation.org,
pombredanne@nexb.com, ebiederm@xmission.com, luto@kernel.org,
linux-kernel@vger.kernel.org, philip.li@intel.com,
leist.fnst@cn.fujitsu.com, zhijianx.li@intel.com
Subject: Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set'
Date: Tue, 8 May 2018 09:30:04 -0700 [thread overview]
Message-ID: <125eb810-1d48-394d-9665-40da64326fbb@intel.com> (raw)
In-Reply-To: <1525770870-19067-2-git-send-email-lizhijian@cn.fujitsu.com>
On 05/08/2018 02:14 AM, Li Zhijian wrote:
> -u32 pkey_get(int pkey, unsigned long flags)
> +u32 _pkey_get(int pkey, unsigned long flags)
> {
> u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
> u32 pkru = __rdpkru();
> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
> return masked_pkru;
> }
I'm not a huge fan of random underscores for undocumented reasons. But,
oh well.
Acked-by: Dave Hansen <dave.hansen@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: dave.hansen at intel.com (Dave Hansen)
Subject: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set'
Date: Tue, 8 May 2018 09:30:04 -0700 [thread overview]
Message-ID: <125eb810-1d48-394d-9665-40da64326fbb@intel.com> (raw)
In-Reply-To: <1525770870-19067-2-git-send-email-lizhijian@cn.fujitsu.com>
On 05/08/2018 02:14 AM, Li Zhijian wrote:
> -u32 pkey_get(int pkey, unsigned long flags)
> +u32 _pkey_get(int pkey, unsigned long flags)
> {
> u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
> u32 pkru = __rdpkru();
> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
> return masked_pkru;
> }
I'm not a huge fan of random underscores for undocumented reasons. But,
oh well.
Acked-by: Dave Hansen <dave.hansen at intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dave.hansen@intel.com (Dave Hansen)
Subject: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set'
Date: Tue, 8 May 2018 09:30:04 -0700 [thread overview]
Message-ID: <125eb810-1d48-394d-9665-40da64326fbb@intel.com> (raw)
Message-ID: <20180508163004.wgmoprdkhQ-LdGc3j6Uhxz8rT0LYbbcsWUW9Cdof4Qg@z> (raw)
In-Reply-To: <1525770870-19067-2-git-send-email-lizhijian@cn.fujitsu.com>
On 05/08/2018 02:14 AM, Li Zhijian wrote:
> -u32 pkey_get(int pkey, unsigned long flags)
> +u32 _pkey_get(int pkey, unsigned long flags)
> {
> u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
> u32 pkru = __rdpkru();
> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
> return masked_pkru;
> }
I'm not a huge fan of random underscores for undocumented reasons. But,
oh well.
Acked-by: Dave Hansen <dave.hansen at intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-08 16:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 9:14 [PATCH 1/2] tools/testing/selftests/x86: fix warning: "SEGV_PKUERR|SEGV_BNDERR" redefined Li Zhijian
2018-05-08 9:14 ` Li Zhijian
2018-05-08 9:14 ` lizhijian
2018-05-08 9:14 ` [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set' Li Zhijian
2018-05-08 9:14 ` Li Zhijian
2018-05-08 9:14 ` lizhijian
2018-05-08 16:30 ` Dave Hansen [this message]
2018-05-08 16:30 ` Dave Hansen
2018-05-08 16:30 ` dave.hansen
2018-05-08 17:36 ` Shuah Khan
2018-05-08 17:36 ` Shuah Khan
2018-05-08 17:36 ` shuah
2018-05-14 9:30 ` Ingo Molnar
2018-05-14 9:30 ` Ingo Molnar
2018-05-14 9:30 ` mingo.kernel.org
2018-05-08 16:25 ` [PATCH 1/2] tools/testing/selftests/x86: fix warning: "SEGV_PKUERR|SEGV_BNDERR" redefined Dave Hansen
2018-05-08 16:25 ` Dave Hansen
2018-05-08 16:25 ` dave.hansen
2018-05-08 17:35 ` Shuah Khan
2018-05-08 17:35 ` Shuah Khan
2018-05-08 17:35 ` shuah
2018-05-14 9:31 ` Ingo Molnar
2018-05-14 9:31 ` Ingo Molnar
2018-05-14 9:31 ` mingo
2018-05-15 20:08 ` Shuah Khan
2018-05-15 20:08 ` Shuah Khan
2018-05-15 20:08 ` shuah
2018-05-18 10:10 ` Ingo Molnar
2018-05-18 10:10 ` Ingo Molnar
2018-05-18 10:10 ` mingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125eb810-1d48-394d-9665-40da64326fbb@intel.com \
--to=dave.hansen@intel.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=leist.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=philip.li@intel.com \
--cc=pombredanne@nexb.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.