All of lore.kernel.org
 help / color / mirror / Atom feed
* Question about git _latest_revision
@ 2020-08-04 15:38 Chris Laplante
  2020-08-04 22:08 ` [bitbake-devel] " Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Laplante @ 2020-08-04 15:38 UTC (permalink / raw)
  To: bitbake-devel

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Question regarding the _latest_revision method in bb.fetch2.git: why do we do an unfiltered 'git ls-remote' and then filter the output on the client side? Wouldn't it be more efficient to just call 'git ls-remote <rev>' with the rev(s) that we actually care about?

Thanks,
Chris

[-- Attachment #2: Type: text/html, Size: 1875 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [bitbake-devel] Question about git _latest_revision
  2020-08-04 15:38 Question about git _latest_revision Chris Laplante
@ 2020-08-04 22:08 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2020-08-04 22:08 UTC (permalink / raw)
  To: chris.laplante, bitbake-devel

On Tue, 2020-08-04 at 15:38 +0000, Chris Laplante via
lists.openembedded.org wrote:
> Question regarding the _latest_revision method in bb.fetch2.git: why
> do we do an unfiltered ‘git ls-remote’ and then filter the output on
> the client side? Wouldn’t it be more efficient to just call ‘git ls-
> remote <rev>’ with the rev(s) that we actually care about?

I had vague memories about a good reason:

http://git.yoctoproject.org/cgit.cgi/poky/commit/bitbake/lib/bb/fetch2/git.py?id=83a30dfd495f0b8e90b7b5725c946c659ecbd93d

so it was a sorting problem between proper and lightweight tags.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-04 22:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 15:38 Question about git _latest_revision Chris Laplante
2020-08-04 22:08 ` [bitbake-devel] " Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.