All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ext3: add writepage sanity checks
@ 2010-03-02 12:51 Dmitry Monakhov
  2010-03-03  8:01 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Monakhov @ 2010-03-02 12:51 UTC (permalink / raw)
  To: linux-ext4; +Cc: jack, Dmitry Monakhov

- There is theoretical possibility to perform writepage on
   RO superblock. Add explicit check for what case.
- Page must being locked before writepage.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 fs/ext3/inode.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 8ac4acf..14d40a4 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1528,6 +1528,7 @@ static int ext3_ordered_writepage(struct page *page,
 	int err;
 
 	J_ASSERT(PageLocked(page));
+	WARN_ON_ONCE(IS_RDONLY(inode));
 
 	/*
 	 * We give up here if we're reentered, because it might be for a
@@ -1600,6 +1601,9 @@ static int ext3_writeback_writepage(struct page *page,
 	int ret = 0;
 	int err;
 
+	J_ASSERT(PageLocked(page));
+	WARN_ON_ONCE(IS_RDONLY(inode));
+
 	if (ext3_journal_current_handle())
 		goto out_fail;
 
@@ -1642,6 +1646,9 @@ static int ext3_journalled_writepage(struct page *page,
 	int ret = 0;
 	int err;
 
+	J_ASSERT(PageLocked(page));
+	WARN_ON_ONCE(IS_RDONLY(inode));
+
 	if (ext3_journal_current_handle())
 		goto no_write;
 
-- 
1.6.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext3: add writepage sanity checks
  2010-03-02 12:51 [PATCH] ext3: add writepage sanity checks Dmitry Monakhov
@ 2010-03-03  8:01 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2010-03-03  8:01 UTC (permalink / raw)
  To: Dmitry Monakhov; +Cc: linux-ext4, jack

On Tue 02-03-10 15:51:02, Dmitry Monakhov wrote:
> - There is theoretical possibility to perform writepage on
>    RO superblock. Add explicit check for what case.
> - Page must being locked before writepage.
  Thanks. Merged into my tree.

								Honza
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  fs/ext3/inode.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 8ac4acf..14d40a4 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -1528,6 +1528,7 @@ static int ext3_ordered_writepage(struct page *page,
>  	int err;
>  
>  	J_ASSERT(PageLocked(page));
> +	WARN_ON_ONCE(IS_RDONLY(inode));
>  
>  	/*
>  	 * We give up here if we're reentered, because it might be for a
> @@ -1600,6 +1601,9 @@ static int ext3_writeback_writepage(struct page *page,
>  	int ret = 0;
>  	int err;
>  
> +	J_ASSERT(PageLocked(page));
> +	WARN_ON_ONCE(IS_RDONLY(inode));
> +
>  	if (ext3_journal_current_handle())
>  		goto out_fail;
>  
> @@ -1642,6 +1646,9 @@ static int ext3_journalled_writepage(struct page *page,
>  	int ret = 0;
>  	int err;
>  
> +	J_ASSERT(PageLocked(page));
> +	WARN_ON_ONCE(IS_RDONLY(inode));
> +
>  	if (ext3_journal_current_handle())
>  		goto no_write;
>  
> -- 
> 1.6.6
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-03  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-02 12:51 [PATCH] ext3: add writepage sanity checks Dmitry Monakhov
2010-03-03  8:01 ` Jan Kara

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.