All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com>
       [not found] <Fix Bluetooth Code Style warnings>
@ 2010-03-07  4:03 ` t.a.c.henriques
  2010-03-07 15:56   ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: t.a.c.henriques @ 2010-03-07  4:03 UTC (permalink / raw)
  To: gregkh, t.a.c.henriques
  Cc: marcel, adobriyan, tglx, linux-bluetooth, linux-kernel

From: root <root@balganUbuntuVM.(none)>

---
 drivers/bluetooth/hci_vhci.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index bb0aefd..4a5386e 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -264,12 +264,9 @@ static int vhci_release(struct inode *inode, struct file *file)
 	struct vhci_data *data = file->private_data;
 	struct hci_dev *hdev = data->hdev;
 
-	if (hci_unregister_dev(hdev) < 0) {
+	if (hci_unregister_dev(hdev) < 0)
 		BT_ERR("Can't unregister HCI device %s", hdev->name);
-	}
-
 	hci_free_dev(hdev);
-
 	file->private_data = NULL;
 
 	return 0;
@@ -284,7 +281,7 @@ static const struct file_operations vhci_fops = {
 	.release	= vhci_release,
 };
 
-static struct miscdevice vhci_miscdev= {
+static struct miscdevice vhci_miscdev = {
 	.name	= "vhci",
 	.fops	= &vhci_fops,
 	.minor	= MISC_DYNAMIC_MINOR,
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com>
  2010-03-07  4:03 ` [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com> t.a.c.henriques
@ 2010-03-07 15:56   ` Greg KH
  2010-03-07 21:08     ` Marcel Holtmann
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2010-03-07 15:56 UTC (permalink / raw)
  To: t.a.c.henriques
  Cc: t.a.c.henriques, marcel, adobriyan, tglx, linux-bluetooth, linux-kernel

Your Subject line is a bit messed up :)

You need to put extra lines in your git commit so that git-send-email
doesn't barf on it.

On Sun, Mar 07, 2010 at 04:03:51AM +0000, t.a.c.henriques@googlemail.com wrote:
> From: root <root@balganUbuntuVM.(none)>

And this is incorrect.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com>
  2010-03-07 15:56   ` Greg KH
@ 2010-03-07 21:08     ` Marcel Holtmann
  2010-03-07 23:27       ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2010-03-07 21:08 UTC (permalink / raw)
  To: Greg KH
  Cc: t.a.c.henriques, t.a.c.henriques, adobriyan, tglx,
	linux-bluetooth, linux-kernel

Hi Tiago,

> Your Subject line is a bit messed up :)
> 
> You need to put extra lines in your git commit so that git-send-email
> doesn't barf on it.
> 
> On Sun, Mar 07, 2010 at 04:03:51AM +0000, t.a.c.henriques@googlemail.com wrote:
> > From: root <root@balganUbuntuVM.(none)>
> 
> And this is incorrect.

and this goes only to linux-bluetooth@vger.kernel.org. I really have no
idea why anybody else is on CC here. It is pure Bluetooth cleanup patch.

Regards

Marcel



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com>
  2010-03-07 21:08     ` Marcel Holtmann
@ 2010-03-07 23:27       ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2010-03-07 23:27 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: t.a.c.henriques, t.a.c.henriques, adobriyan, tglx,
	linux-bluetooth, linux-kernel

On Sun, Mar 07, 2010 at 01:08:12PM -0800, Marcel Holtmann wrote:
> Hi Tiago,
> 
> > Your Subject line is a bit messed up :)
> > 
> > You need to put extra lines in your git commit so that git-send-email
> > doesn't barf on it.
> > 
> > On Sun, Mar 07, 2010 at 04:03:51AM +0000, t.a.c.henriques@googlemail.com wrote:
> > > From: root <root@balganUbuntuVM.(none)>
> > 
> > And this is incorrect.
> 
> and this goes only to linux-bluetooth@vger.kernel.org. I really have no
> idea why anybody else is on CC here. It is pure Bluetooth cleanup patch.

scripts/get_maintainer.pl lists all of these, that is why.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-03-07 23:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <Fix Bluetooth Code Style warnings>
2010-03-07  4:03 ` [PATCH] Bluetooth: fix coding style issue in hci_vhci.c This patch affects hci_vhci.c it fixes some warnings detected by the checkpath.pl tool Signed-off-by: Tiago Henriques <t.a.c.henriques@gmail.com> t.a.c.henriques
2010-03-07 15:56   ` Greg KH
2010-03-07 21:08     ` Marcel Holtmann
2010-03-07 23:27       ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.