* [PATCH 01/16] ARM mach-at91: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
` (13 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Russell King, Nicolas Ferre, Andrew Victor,
Dmitry Torokhov, linux-arm-kernel, linux-kernel
arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-at91/board-sam9m10g45ek.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-at91/board-sam9m10g45ek.c b/arch/arm/mach-at91/board-sam9m10g45ek.c
index 98f9f4b..ee80059 100644
--- a/arch/arm/mach-at91/board-sam9m10g45ek.c
+++ b/arch/arm/mach-at91/board-sam9m10g45ek.c
@@ -25,7 +25,6 @@
#include <linux/leds.h>
#include <linux/clk.h>
-#include <mach/hardware.h>
#include <video/atmel_lcdc.h>
#include <asm/setup.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 01/16] ARM mach-at91: duplicated include
@ 2010-03-25 17:22 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-arm-kernel
arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-at91/board-sam9m10g45ek.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-at91/board-sam9m10g45ek.c b/arch/arm/mach-at91/board-sam9m10g45ek.c
index 98f9f4b..ee80059 100644
--- a/arch/arm/mach-at91/board-sam9m10g45ek.c
+++ b/arch/arm/mach-at91/board-sam9m10g45ek.c
@@ -25,7 +25,6 @@
#include <linux/leds.h>
#include <linux/clk.h>
-#include <mach/hardware.h>
#include <video/atmel_lcdc.h>
#include <asm/setup.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 02/16] ARM mach-mx3: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
` (13 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Sascha Hauer, Russell King,
Uwe Kleine-König, linux-arm-kernel, linux-kernel
arch/arm/mach-mx3/mach-pcm037.c: linux/fsl_devices.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-mx3/mach-pcm037.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx3/mach-pcm037.c b/arch/arm/mach-mx3/mach-pcm037.c
index 11f5315..a550ae9 100644
--- a/arch/arm/mach-mx3/mach-pcm037.c
+++ b/arch/arm/mach-mx3/mach-pcm037.c
@@ -35,7 +35,6 @@
#include <linux/can/platform/sja1000.h>
#include <linux/usb/otg.h>
#include <linux/usb/ulpi.h>
-#include <linux/fsl_devices.h>
#include <media/soc_camera.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 02/16] ARM mach-mx3: duplicated include
@ 2010-03-25 17:22 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-arm-kernel
arch/arm/mach-mx3/mach-pcm037.c: linux/fsl_devices.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-mx3/mach-pcm037.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx3/mach-pcm037.c b/arch/arm/mach-mx3/mach-pcm037.c
index 11f5315..a550ae9 100644
--- a/arch/arm/mach-mx3/mach-pcm037.c
+++ b/arch/arm/mach-mx3/mach-pcm037.c
@@ -35,7 +35,6 @@
#include <linux/can/platform/sja1000.h>
#include <linux/usb/otg.h>
#include <linux/usb/ulpi.h>
-#include <linux/fsl_devices.h>
#include <media/soc_camera.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 03/16] ARM mach-mx3: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
` (13 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Sascha Hauer, Russell King, Daniel Mack,
Vladimir Zapolskiy, linux-arm-kernel, linux-kernel
arch/arm/mach-mx3/mx31lite-db.c: linux/platform_device.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-mx3/mx31lite-db.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx3/mx31lite-db.c b/arch/arm/mach-mx3/mx31lite-db.c
index ccd8742..16c955e 100644
--- a/arch/arm/mach-mx3/mx31lite-db.c
+++ b/arch/arm/mach-mx3/mx31lite-db.c
@@ -28,7 +28,6 @@
#include <linux/types.h>
#include <linux/init.h>
#include <linux/gpio.h>
-#include <linux/platform_device.h>
#include <linux/leds.h>
#include <linux/platform_device.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 03/16] ARM mach-mx3: duplicated include
@ 2010-03-25 17:22 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-arm-kernel
arch/arm/mach-mx3/mx31lite-db.c: linux/platform_device.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/arm/mach-mx3/mx31lite-db.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx3/mx31lite-db.c b/arch/arm/mach-mx3/mx31lite-db.c
index ccd8742..16c955e 100644
--- a/arch/arm/mach-mx3/mx31lite-db.c
+++ b/arch/arm/mach-mx3/mx31lite-db.c
@@ -28,7 +28,6 @@
#include <linux/types.h>
#include <linux/init.h>
#include <linux/gpio.h>
-#include <linux/platform_device.h>
#include <linux/leds.h>
#include <linux/platform_device.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 04/16] x86 init_64.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (2 preceding siblings ...)
2010-03-25 17:22 ` Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 05/16] Docs hpet_example.c: duplicated includes Andrea Gelmini
` (10 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86, Andrew Morton, KAMEZAWA Hiroyuki, Yinghai Lu, linux-kernel
arch/x86/mm/init_64.c: linux/bootmem.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/x86/mm/init_64.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index e9b040e..a544bec 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -49,7 +49,6 @@
#include <asm/numa.h>
#include <asm/cacheflush.h>
#include <asm/init.h>
-#include <linux/bootmem.h>
static unsigned long dma_reserve __initdata;
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 05/16] Docs hpet_example.c: duplicated includes
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (3 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 04/16] x86 init_64.c: " Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include Andrea Gelmini
` (9 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Thomas Gleixner, Randy Dunlap, Andrew Morton,
linux-kernel
Documentation/timers/hpet_example.c: fcntl.h is included more than once.
Documentation/timers/hpet_example.c: signal.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
Documentation/timers/hpet_example.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/Documentation/timers/hpet_example.c b/Documentation/timers/hpet_example.c
index f9ce2d9..4bfafb7 100644
--- a/Documentation/timers/hpet_example.c
+++ b/Documentation/timers/hpet_example.c
@@ -10,7 +10,6 @@
#include <sys/types.h>
#include <sys/wait.h>
#include <signal.h>
-#include <fcntl.h>
#include <errno.h>
#include <sys/time.h>
#include <linux/hpet.h>
@@ -24,7 +23,6 @@ extern void hpet_read(int, const char **);
#include <sys/poll.h>
#include <sys/ioctl.h>
-#include <signal.h>
struct hpet_command {
char *command;
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (4 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 05/16] Docs hpet_example.c: duplicated includes Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 18:09 ` Jonathan Cameron
2010-03-25 17:22 ` [PATCH 07/16] Staging: sep: sep_driver.c: " Andrea Gelmini
` (8 subsequent siblings)
14 siblings, 1 reply; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Greg Kroah-Hartman, Jonathan Cameron, devel,
linux-kernel
drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c: dirent.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
.../iio/Documentation/lis3l02dqbuffersimple.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
index 2b5cfc5..6a8fa0c 100644
--- a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
+++ b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
@@ -19,7 +19,6 @@
#include <sys/dir.h>
#include <linux/types.h>
-#include <dirent.h>
#include "iio_util.h"
static const char *ring_access = "/dev/iio/lis3l02dq_ring_access";
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 07/16] Staging: sep: sep_driver.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (5 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:27 ` Randy Dunlap
2010-03-25 17:22 ` [PATCH 08/16] Staging: wlan-ng: p80211wext.c: " Andrea Gelmini
` (7 subsequent siblings)
14 siblings, 1 reply; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Greg Kroah-Hartman, Alan Cox, Ben Hutchings,
Joe Perches, devel, linux-kernel
drivers/staging/sep/sep_driver.c: linux/sched.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
drivers/staging/sep/sep_driver.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 265de79..9be1fb7 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -39,7 +39,6 @@
#include <linux/mm.h>
#include <linux/poll.h>
#include <linux/wait.h>
-#include <linux/sched.h>
#include <linux/pci.h>
#include <linux/firmware.h>
#include <asm/ioctl.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 08/16] Staging: wlan-ng: p80211wext.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (6 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 07/16] Staging: sep: sep_driver.c: " Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 10/16] USB gadget r8a66597-udc.c: " Andrea Gelmini
` (6 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Greg Kroah-Hartman, Moritz Muehlenhoff,
Andrew Elwell, Mithlesh Thukral, devel, linux-kernel
drivers/staging/wlan-ng/p80211wext.c: linux/bitops.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
drivers/staging/wlan-ng/p80211wext.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c
index 2fa1dfa..b6734e7 100644
--- a/drivers/staging/wlan-ng/p80211wext.c
+++ b/drivers/staging/wlan-ng/p80211wext.c
@@ -50,7 +50,6 @@
#include <linux/uaccess.h>
#include <asm/byteorder.h>
#include <linux/if_ether.h>
-#include <linux/bitops.h>
#include "p80211types.h"
#include "p80211hdr.h"
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 10/16] USB gadget r8a66597-udc.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (7 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 08/16] Staging: wlan-ng: p80211wext.c: " Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-26 3:12 ` Paul Mundt
2010-03-25 17:22 ` Andrea Gelmini
` (5 subsequent siblings)
14 siblings, 1 reply; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, David Brownell, Greg Kroah-Hartman, Paul Mundt,
Magnus Damm, Yoshihiro Shimoda, Mark Brown, linux-usb,
linux-kernel
drivers/usb/gadget/r8a66597-udc.c: linux/err.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
drivers/usb/gadget/r8a66597-udc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
index 5e13d23..8b45145 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++ b/drivers/usb/gadget/r8a66597-udc.c
@@ -23,7 +23,6 @@
#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/delay.h>
-#include <linux/err.h>
#include <linux/io.h>
#include <linux/platform_device.h>
#include <linux/clk.h>
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 11/16] XFS xfs_trace.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
` (13 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Alex Elder, xfs-masters, Christoph Hellwig,
Dave Chinner, xfs, linux-kernel
fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
fs/xfs/linux-2.6/xfs_trace.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
index 5a10760..cb840e0 100644
--- a/fs/xfs/linux-2.6/xfs_trace.c
+++ b/fs/xfs/linux-2.6/xfs_trace.c
@@ -41,7 +41,6 @@
#include "xfs_alloc.h"
#include "xfs_bmap.h"
#include "xfs_attr.h"
-#include "xfs_attr_sf.h"
#include "xfs_attr_leaf.h"
#include "xfs_log_priv.h"
#include "xfs_buf_item.h"
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 11/16] XFS xfs_trace.c: duplicated include
@ 2010-03-25 17:22 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: linux-kernel, xfs, xfs-masters, Alex Elder, Andrea Gelmini,
Christoph Hellwig
fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
fs/xfs/linux-2.6/xfs_trace.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
index 5a10760..cb840e0 100644
--- a/fs/xfs/linux-2.6/xfs_trace.c
+++ b/fs/xfs/linux-2.6/xfs_trace.c
@@ -41,7 +41,6 @@
#include "xfs_alloc.h"
#include "xfs_bmap.h"
#include "xfs_attr.h"
-#include "xfs_attr_sf.h"
#include "xfs_attr_leaf.h"
#include "xfs_log_priv.h"
#include "xfs_buf_item.h"
--
1.7.0.3.296.g9776a
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 12/16] Scripts lex.c: remove extra spaces
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (9 preceding siblings ...)
2010-03-25 17:22 ` Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-26 13:15 ` Michal Marek
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
` (3 subsequent siblings)
14 siblings, 1 reply; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc; +Cc: Andrea Gelmini, linux-kernel
scripts/genksyms/lex.c: deleted extra spaces
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
scripts/genksyms/lex.c_shipped | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/genksyms/lex.c_shipped b/scripts/genksyms/lex.c_shipped
index 2ac23bc..5682dfd 100644
--- a/scripts/genksyms/lex.c_shipped
+++ b/scripts/genksyms/lex.c_shipped
@@ -27,7 +27,7 @@
/* %endif */
/* %if-c-only */
-
+
/* %endif */
/* %if-c-only */
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (10 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 12/16] Scripts lex.c: remove extra spaces Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-26 8:00 ` Ingo Molnar
2010-03-26 8:02 ` Ingo Molnar
2010-03-25 17:22 ` [PATCH 14/16] Tools perf probe-finder.c: duplicated include Andrea Gelmini
` (2 subsequent siblings)
14 siblings, 2 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker,
linux-kernel
tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
tools/perf/builtin-trace.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 407041d..3c699c5 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -59,9 +59,6 @@ static int cleanup_scripting(void)
#include "perf.h"
#include "util/debug.h"
-#include "util/trace-event.h"
-#include "util/exec_cmd.h"
-
static char const *input_name = "perf.data";
static int process_sample_event(event_t *event, struct perf_session *session)
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 14/16] Tools perf probe-finder.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (11 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:42 ` Masami Hiramatsu
2010-03-25 17:22 ` [PATCH 15/16] BTRFS ioctl.c: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
14 siblings, 1 reply; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Masami Hiramatsu, Frederic Weisbecker,
linux-kernel
tools/perf/util/probe-finder.c: string.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
tools/perf/util/probe-finder.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 1e6c65e..682eb37 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -32,7 +32,6 @@
#include <stdarg.h>
#include <ctype.h>
-#include "string.h"
#include "event.h"
#include "debug.h"
#include "util.h"
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 15/16] BTRFS ioctl.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
` (12 preceding siblings ...)
2010-03-25 17:22 ` [PATCH 14/16] Tools perf probe-finder.c: duplicated include Andrea Gelmini
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Chris Mason, Yan Zheng, Josef Bacik, Sage Weil,
Al Viro, linux-btrfs, linux-kernel
fs/btrfs/ioctl.c: ctree.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
fs/btrfs/ioctl.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 2845c6c..5c9f8b3 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -48,7 +48,6 @@
#include "print-tree.h"
#include "volumes.h"
#include "locking.h"
-#include "ctree.h"
/* Mask out flags that are inappropriate for the given type of inode. */
static inline __u32 btrfs_mask_flags(umode_t mode, __u32 flags)
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 16/16] Video omap lcd_omap3beagle.c: duplicated include
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
@ 2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
` (13 subsequent siblings)
14 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Tomi Valkeinen, Tony Lindgren, Andrew Morton,
Koen Kooi, linux-fbdev, linux-omap, linux-kernel
drivers/video/omap/lcd_omap3beagle.c: plat/mux.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
drivers/video/omap/lcd_omap3beagle.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index ca75cc2..ac715f9 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -26,7 +26,6 @@
#include <linux/i2c/twl.h>
#include <plat/mux.h>
-#include <plat/mux.h>
#include <asm/mach-types.h>
#include "omapfb.h"
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 16/16] Video omap lcd_omap3beagle.c: duplicated include
@ 2010-03-25 17:22 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:22 UTC (permalink / raw)
To: linux-doc
Cc: Andrea Gelmini, Tomi Valkeinen, Tony Lindgren, Andrew Morton,
Koen Kooi, linux-fbdev, linux-omap, linux-kernel
drivers/video/omap/lcd_omap3beagle.c: plat/mux.h is included more than once.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
drivers/video/omap/lcd_omap3beagle.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
index ca75cc2..ac715f9 100644
--- a/drivers/video/omap/lcd_omap3beagle.c
+++ b/drivers/video/omap/lcd_omap3beagle.c
@@ -26,7 +26,6 @@
#include <linux/i2c/twl.h>
#include <plat/mux.h>
-#include <plat/mux.h>
#include <asm/mach-types.h>
#include "omapfb.h"
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 07/16] Staging: sep: sep_driver.c: duplicated include
2010-03-25 17:22 ` [PATCH 07/16] Staging: sep: sep_driver.c: " Andrea Gelmini
@ 2010-03-25 17:27 ` Randy Dunlap
2010-03-25 17:32 ` Andrea Gelmini
0 siblings, 1 reply; 40+ messages in thread
From: Randy Dunlap @ 2010-03-25 17:27 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, devel, Greg Kroah-Hartman, linux-kernel, Joe Perches,
Ben Hutchings, Alan Cox
On 03/25/10 10:22, Andrea Gelmini wrote:
> drivers/staging/sep/sep_driver.c: linux/sched.h is included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Hi,
You don't need to be sending these patches to the linux-doc mailing list.
Thanks.
> ---
> drivers/staging/sep/sep_driver.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
> index 265de79..9be1fb7 100644
> --- a/drivers/staging/sep/sep_driver.c
> +++ b/drivers/staging/sep/sep_driver.c
> @@ -39,7 +39,6 @@
> #include <linux/mm.h>
> #include <linux/poll.h>
> #include <linux/wait.h>
> -#include <linux/sched.h>
> #include <linux/pci.h>
> #include <linux/firmware.h>
> #include <asm/ioctl.h>
--
~Randy
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 07/16] Staging: sep: sep_driver.c: duplicated include
2010-03-25 17:27 ` Randy Dunlap
@ 2010-03-25 17:32 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:32 UTC (permalink / raw)
To: Randy Dunlap
Cc: devel, linux-doc, Greg Kroah-Hartman, linux-kernel, Joe Perches,
Ben Hutchings, Alan Cox
2010/3/25 Randy Dunlap <rdunlap@xenotime.net>:
> Hi,
>
> You don't need to be sending these patches to the linux-doc mailing list.
> Thanks.
Shame on me. I made a mess with bash history...
I'm very sorry,
Andrea
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
2010-03-25 17:22 ` [PATCH 14/16] Tools perf probe-finder.c: duplicated include Andrea Gelmini
@ 2010-03-25 17:42 ` Masami Hiramatsu
2010-03-25 17:45 ` Andrea Gelmini
2010-03-26 5:32 ` KOSAKI Motohiro
0 siblings, 2 replies; 40+ messages in thread
From: Masami Hiramatsu @ 2010-03-25 17:42 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Frederic Weisbecker, linux-kernel
Hi Andrea,
Andrea Gelmini wrote:
> tools/perf/util/probe-finder.c: string.h is included more than once.
Would you mean that <string.h> and "string.h" are duplicated?
If so, NAK, sorry. Those are different, <string.h> is for
/usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
Thank you,
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> tools/perf/util/probe-finder.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 1e6c65e..682eb37 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -32,7 +32,6 @@
> #include <stdarg.h>
> #include <ctype.h>
>
> -#include "string.h"
> #include "event.h"
> #include "debug.h"
> #include "util.h"
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
2010-03-25 17:42 ` Masami Hiramatsu
@ 2010-03-25 17:45 ` Andrea Gelmini
2010-03-26 5:32 ` KOSAKI Motohiro
1 sibling, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-25 17:45 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: linux-doc, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Frederic Weisbecker, linux-kernel
2010/3/25 Masami Hiramatsu <mhiramat@redhat.com>:
> Would you mean that <string.h> and "string.h" are duplicated?
> If so, NAK, sorry. Those are different, <string.h> is for
> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
I'm an asshole...
Sorry, you're right.
Ciao,
Andrea
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include
2010-03-25 17:22 ` [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include Andrea Gelmini
@ 2010-03-25 18:09 ` Jonathan Cameron
0 siblings, 0 replies; 40+ messages in thread
From: Jonathan Cameron @ 2010-03-25 18:09 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, Greg Kroah-Hartman, devel, linux-kernel, linux-iio
On 03/25/10 17:22, Andrea Gelmini wrote:
> drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c: dirent.h is included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Fair point.
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> .../iio/Documentation/lis3l02dqbuffersimple.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> index 2b5cfc5..6a8fa0c 100644
> --- a/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> +++ b/drivers/staging/iio/Documentation/lis3l02dqbuffersimple.c
> @@ -19,7 +19,6 @@
> #include <sys/dir.h>
>
> #include <linux/types.h>
> -#include <dirent.h>
> #include "iio_util.h"
>
> static const char *ring_access = "/dev/iio/lis3l02dq_ring_access";
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 11/16] XFS xfs_trace.c: duplicated include
2010-03-25 17:22 ` Andrea Gelmini
@ 2010-03-25 18:37 ` Alex Elder
-1 siblings, 0 replies; 40+ messages in thread
From: Alex Elder @ 2010-03-25 18:37 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, xfs-masters, Christoph Hellwig, Dave Chinner, xfs,
linux-kernel
On Thu, 2010-03-25 at 18:22 +0100, Andrea Gelmini wrote:
> fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Looks good. -Alex
Reviewed-by: Alex Elder <aelder@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_trace.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
> index 5a10760..cb840e0 100644
> --- a/fs/xfs/linux-2.6/xfs_trace.c
> +++ b/fs/xfs/linux-2.6/xfs_trace.c
> @@ -41,7 +41,6 @@
> #include "xfs_alloc.h"
> #include "xfs_bmap.h"
> #include "xfs_attr.h"
> -#include "xfs_attr_sf.h"
> #include "xfs_attr_leaf.h"
> #include "xfs_log_priv.h"
> #include "xfs_buf_item.h"
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 11/16] XFS xfs_trace.c: duplicated include
@ 2010-03-25 18:37 ` Alex Elder
0 siblings, 0 replies; 40+ messages in thread
From: Alex Elder @ 2010-03-25 18:37 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, linux-kernel, xfs, xfs-masters, Christoph Hellwig
On Thu, 2010-03-25 at 18:22 +0100, Andrea Gelmini wrote:
> fs/xfs/linux-2.6/xfs_trace.c: xfs_attr_sf.h is included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Looks good. -Alex
Reviewed-by: Alex Elder <aelder@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_trace.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c
> index 5a10760..cb840e0 100644
> --- a/fs/xfs/linux-2.6/xfs_trace.c
> +++ b/fs/xfs/linux-2.6/xfs_trace.c
> @@ -41,7 +41,6 @@
> #include "xfs_alloc.h"
> #include "xfs_bmap.h"
> #include "xfs_attr.h"
> -#include "xfs_attr_sf.h"
> #include "xfs_attr_leaf.h"
> #include "xfs_log_priv.h"
> #include "xfs_buf_item.h"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 10/16] USB gadget r8a66597-udc.c: duplicated include
2010-03-25 17:22 ` [PATCH 10/16] USB gadget r8a66597-udc.c: " Andrea Gelmini
@ 2010-03-26 3:12 ` Paul Mundt
0 siblings, 0 replies; 40+ messages in thread
From: Paul Mundt @ 2010-03-26 3:12 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, David Brownell, Greg Kroah-Hartman, Magnus Damm,
Yoshihiro Shimoda, Mark Brown, linux-usb, linux-kernel
On Thu, Mar 25, 2010 at 06:22:40PM +0100, Andrea Gelmini wrote:
> drivers/usb/gadget/r8a66597-udc.c: linux/err.h is included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
It seems the same fix was done in two different trees and merged at
different times, resulting in the duplication now.
Applied, thanks.
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
2010-03-25 17:42 ` Masami Hiramatsu
2010-03-25 17:45 ` Andrea Gelmini
@ 2010-03-26 5:32 ` KOSAKI Motohiro
2010-03-26 15:44 ` Masami Hiramatsu
1 sibling, 1 reply; 40+ messages in thread
From: KOSAKI Motohiro @ 2010-03-26 5:32 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: kosaki.motohiro, Andrea Gelmini, linux-doc, Peter Zijlstra,
Paul Mackerras, Ingo Molnar, Arnaldo Carvalho de Melo,
Frederic Weisbecker, linux-kernel
> Hi Andrea,
>
> Andrea Gelmini wrote:
> > tools/perf/util/probe-finder.c: string.h is included more than once.
>
> Would you mean that <string.h> and "string.h" are duplicated?
> If so, NAK, sorry. Those are different, <string.h> is for
> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
>
> Thank you,
I think this discussion suggested "string.h" should be renameed more review
friendly name. probably.
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
@ 2010-03-26 8:00 ` Ingo Molnar
2010-03-26 13:27 ` Andrea Gelmini
2010-03-26 8:02 ` Ingo Molnar
1 sibling, 1 reply; 40+ messages in thread
From: Ingo Molnar @ 2010-03-26 8:00 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, Peter Zijlstra, Paul Mackerras,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker,
linux-kernel
* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:
> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> tools/perf/builtin-trace.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 407041d..3c699c5 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -59,9 +59,6 @@ static int cleanup_scripting(void)
> #include "perf.h"
> #include "util/debug.h"
>
> -#include "util/trace-event.h"
> -#include "util/exec_cmd.h"
> -
> static char const *input_name = "perf.data";
>
> static int process_sample_event(event_t *event, struct perf_session *session)
Please send a more complete patch that fixes the root cause of the
duplication: a few header files are in the middle of the .c file - all
inclusions should be at the top of the file.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
2010-03-26 8:00 ` Ingo Molnar
@ 2010-03-26 8:02 ` Ingo Molnar
2010-03-26 13:47 ` [PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup Andrea Gelmini
2010-03-26 13:47 ` [PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld Andrea Gelmini
1 sibling, 2 replies; 40+ messages in thread
From: Ingo Molnar @ 2010-03-26 8:02 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, Peter Zijlstra, Paul Mackerras,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker,
linux-kernel
* Andrea Gelmini <andrea.gelmini@gelma.net> wrote:
> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
Also, could you please update your patch to fix the subject lines of these
auto-generated patches? The subject lines are missing a verb. The correct one
would be:
Subject: [PATCH 13/16] Tools perf builtin-trace.c: Remove duplicated #includes
Thanks,
Ingo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 12/16] Scripts lex.c: remove extra spaces
2010-03-25 17:22 ` [PATCH 12/16] Scripts lex.c: remove extra spaces Andrea Gelmini
@ 2010-03-26 13:15 ` Michal Marek
2010-03-26 13:23 ` Andrea Gelmini
0 siblings, 1 reply; 40+ messages in thread
From: Michal Marek @ 2010-03-26 13:15 UTC (permalink / raw)
To: Andrea Gelmini; +Cc: linux-doc, linux-kernel
On 25.3.2010 18:22, Andrea Gelmini wrote:
> scripts/genksyms/lex.c: deleted extra spaces
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> scripts/genksyms/lex.c_shipped | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/genksyms/lex.c_shipped b/scripts/genksyms/lex.c_shipped
> index 2ac23bc..5682dfd 100644
> --- a/scripts/genksyms/lex.c_shipped
> +++ b/scripts/genksyms/lex.c_shipped
> @@ -27,7 +27,7 @@
> /* %endif */
>
> /* %if-c-only */
> -
> +
> /* %endif */
This is a generated file, I don't think there is value in manually
fixing coding style issues in it, each subsequent update would overwrite
the changes.
Michal
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 12/16] Scripts lex.c: remove extra spaces
2010-03-26 13:15 ` Michal Marek
@ 2010-03-26 13:23 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-26 13:23 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-doc, linux-kernel
2010/3/26 Michal Marek <mmarek@suse.cz>:
> This is a generated file, I don't think there is value in manually
> fixing coding style issues in it, each subsequent update would overwrite
> the changes.
You're right. I saw it after send.
Thanks a lot,
Andrea
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes
2010-03-26 8:00 ` Ingo Molnar
@ 2010-03-26 13:27 ` Andrea Gelmini
0 siblings, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-26 13:27 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-doc, Peter Zijlstra, Paul Mackerras,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker,
linux-kernel
2010/3/26 Ingo Molnar <mingo@elte.hu>:
> Please send a more complete patch that fixes the root cause of the
> duplication: a few header files are in the middle of the .c file - all
> inclusions should be at the top of the file.
I try to be less intrusive as possibile.
Now I reworked the patch, and I'll send it in a while.
Thanks a lot for your advices,
Andrea
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup
2010-03-26 8:02 ` Ingo Molnar
@ 2010-03-26 13:47 ` Andrea Gelmini
2010-03-26 13:47 ` [PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld Andrea Gelmini
1 sibling, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-26 13:47 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, Andrea Gelmini, Peter Zijlstra, Paul Mackerras,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker
Removed util/exec_cmd.h and util/trace-event.h included more than once.
Grouped and ordered includes.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
tools/perf/builtin-trace.c | 19 +++++++------------
1 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 407041d..c743c86 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1,13 +1,16 @@
#include "builtin.h"
+#include "perf.h"
-#include "util/util.h"
#include "util/cache.h"
+#include "util/debug.h"
+#include "util/exec_cmd.h"
+#include "util/header.h"
+#include "util/parse-options.h"
+#include "util/session.h"
#include "util/symbol.h"
#include "util/thread.h"
-#include "util/header.h"
-#include "util/exec_cmd.h"
#include "util/trace-event.h"
-#include "util/session.h"
+#include "util/util.h"
static char const *script_name;
static char const *generate_script_lang;
@@ -54,14 +57,6 @@ static int cleanup_scripting(void)
return scripting_ops->stop_script();
}
-#include "util/parse-options.h"
-
-#include "perf.h"
-#include "util/debug.h"
-
-#include "util/trace-event.h"
-#include "util/exec_cmd.h"
-
static char const *input_name = "perf.data";
static int process_sample_event(event_t *event, struct perf_session *session)
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* [PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld
2010-03-26 8:02 ` Ingo Molnar
2010-03-26 13:47 ` [PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup Andrea Gelmini
@ 2010-03-26 13:47 ` Andrea Gelmini
1 sibling, 0 replies; 40+ messages in thread
From: Andrea Gelmini @ 2010-03-26 13:47 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, Andrea Gelmini, Peter Zijlstra, Paul Mackerras,
Arnaldo Carvalho de Melo, Tom Zanussi, Frederic Weisbecker
Chackpatch.pl cleanup:
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
+·⁖⁖dump_printf("(IP, %d): %d/%d: %#Lx period: %Ld\n", event->header.misc,
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
tools/perf/builtin-trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index c743c86..49b772f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -71,7 +71,7 @@ static int process_sample_event(event_t *event, struct perf_session *session)
event__parse_sample(event, session->sample_type, &data);
- dump_printf("(IP, %d): %d/%d: %#Lx period: %Ld\n", event->header.misc,
+ dump_printf("(IP, %d): %d/%d: %#Lx period: %lld\n", event->header.misc,
data.pid, data.tid, data.ip, data.period);
thread = perf_session__findnew(session, event->ip.pid);
--
1.7.0.3.296.g9776a
^ permalink raw reply related [flat|nested] 40+ messages in thread
* Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
2010-03-26 5:32 ` KOSAKI Motohiro
@ 2010-03-26 15:44 ` Masami Hiramatsu
2010-03-26 18:26 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 40+ messages in thread
From: Masami Hiramatsu @ 2010-03-26 15:44 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Andrea Gelmini, linux-doc, Peter Zijlstra, Paul Mackerras,
Ingo Molnar, Arnaldo Carvalho de Melo, Frederic Weisbecker,
linux-kernel
KOSAKI Motohiro wrote:
>> Hi Andrea,
>>
>> Andrea Gelmini wrote:
>>> tools/perf/util/probe-finder.c: string.h is included more than once.
>>
>> Would you mean that <string.h> and "string.h" are duplicated?
>> If so, NAK, sorry. Those are different, <string.h> is for
>> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
>>
>> Thank you,
>
> I think this discussion suggested "string.h" should be renameed more review
> friendly name. probably.
Hmm, we'd better review files under tools/utils/include too. :(
(not sure why we have those files, because some files includes
headers from original include directory, as like as
"../../include/linux/blahblah.h")
Thank you,
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
2010-03-26 15:44 ` Masami Hiramatsu
@ 2010-03-26 18:26 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 40+ messages in thread
From: Arnaldo Carvalho de Melo @ 2010-03-26 18:26 UTC (permalink / raw)
To: Masami Hiramatsu
Cc: KOSAKI Motohiro, Andrea Gelmini, linux-doc, Peter Zijlstra,
Paul Mackerras, Ingo Molnar, Frederic Weisbecker, linux-kernel
Em Fri, Mar 26, 2010 at 11:44:15AM -0400, Masami Hiramatsu escreveu:
> KOSAKI Motohiro wrote:
> >> Hi Andrea,
> >>
> >> Andrea Gelmini wrote:
> >>> tools/perf/util/probe-finder.c: string.h is included more than once.
> >>
> >> Would you mean that <string.h> and "string.h" are duplicated?
> >> If so, NAK, sorry. Those are different, <string.h> is for
> >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
> >>
> >> Thank you,
> >
> > I think this discussion suggested "string.h" should be renameed more review
> > friendly name. probably.
String should be renamed, yes, I'll do that.
> Hmm, we'd better review files under tools/utils/include too. :(
> (not sure why we have those files, because some files includes
> headers from original include directory, as like as
> "../../include/linux/blahblah.h")
To share code with the kernel (rbtree.[ch], list.h).
- Arnaldo
^ permalink raw reply [flat|nested] 40+ messages in thread
* Re: [PATCH 01/16] ARM mach-at91: duplicated include
2010-03-25 17:22 ` Andrea Gelmini
@ 2010-03-29 20:35 ` Andrew Victor
-1 siblings, 0 replies; 40+ messages in thread
From: Andrew Victor @ 2010-03-29 20:35 UTC (permalink / raw)
To: Andrea Gelmini
Cc: linux-doc, Russell King, Nicolas Ferre, Andrew Victor,
Dmitry Torokhov, linux-arm-kernel, linux-kernel
> arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Acked-by: Andrew Victor <linux@maxim.org.za>
Please submit the patch to Russell King's patch tracking system.
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH 01/16] ARM mach-at91: duplicated include
@ 2010-03-29 20:35 ` Andrew Victor
0 siblings, 0 replies; 40+ messages in thread
From: Andrew Victor @ 2010-03-29 20:35 UTC (permalink / raw)
To: linux-arm-kernel
> arch/arm/mach-at91/board-sam9m10g45ek.c: mach/hardware.h is included more than once
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Acked-by: Andrew Victor <linux@maxim.org.za>
Please submit the patch to Russell King's patch tracking system.
^ permalink raw reply [flat|nested] 40+ messages in thread
end of thread, other threads:[~2010-03-29 20:35 UTC | newest]
Thread overview: 40+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1269537767-7553-1-git-send-email-andrea.gelmini@gelma.net>
2010-03-25 17:22 ` [PATCH 01/16] ARM mach-at91: duplicated include Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-29 20:35 ` Andrew Victor
2010-03-29 20:35 ` Andrew Victor
2010-03-25 17:22 ` [PATCH 02/16] ARM mach-mx3: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 03/16] " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 04/16] x86 init_64.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 05/16] Docs hpet_example.c: duplicated includes Andrea Gelmini
2010-03-25 17:22 ` [PATCH 06/16] Staging: iio: Documentation/lis3l02dqbuffersimple.c: duplicated include Andrea Gelmini
2010-03-25 18:09 ` Jonathan Cameron
2010-03-25 17:22 ` [PATCH 07/16] Staging: sep: sep_driver.c: " Andrea Gelmini
2010-03-25 17:27 ` Randy Dunlap
2010-03-25 17:32 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 08/16] Staging: wlan-ng: p80211wext.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 10/16] USB gadget r8a66597-udc.c: " Andrea Gelmini
2010-03-26 3:12 ` Paul Mundt
2010-03-25 17:22 ` [PATCH 11/16] XFS xfs_trace.c: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
2010-03-25 18:37 ` Alex Elder
2010-03-25 18:37 ` Alex Elder
2010-03-25 17:22 ` [PATCH 12/16] Scripts lex.c: remove extra spaces Andrea Gelmini
2010-03-26 13:15 ` Michal Marek
2010-03-26 13:23 ` Andrea Gelmini
2010-03-25 17:22 ` [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes Andrea Gelmini
2010-03-26 8:00 ` Ingo Molnar
2010-03-26 13:27 ` Andrea Gelmini
2010-03-26 8:02 ` Ingo Molnar
2010-03-26 13:47 ` [PATCH 1/2] Tools perf builtin-trace.c: #includes cleanup Andrea Gelmini
2010-03-26 13:47 ` [PATCH 2/2] Tools perf builtin-trace.c: %Ld -> %lld Andrea Gelmini
2010-03-25 17:22 ` [PATCH 14/16] Tools perf probe-finder.c: duplicated include Andrea Gelmini
2010-03-25 17:42 ` Masami Hiramatsu
2010-03-25 17:45 ` Andrea Gelmini
2010-03-26 5:32 ` KOSAKI Motohiro
2010-03-26 15:44 ` Masami Hiramatsu
2010-03-26 18:26 ` Arnaldo Carvalho de Melo
2010-03-25 17:22 ` [PATCH 15/16] BTRFS ioctl.c: " Andrea Gelmini
2010-03-25 17:22 ` [PATCH 16/16] Video omap lcd_omap3beagle.c: " Andrea Gelmini
2010-03-25 17:22 ` Andrea Gelmini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.