* [PATCH] xfs: don't warn on EAGAIN in inode reclaim
@ 2010-03-30 6:20 Dave Chinner
2010-03-30 18:30 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Dave Chinner @ 2010-03-30 6:20 UTC (permalink / raw)
To: xfs
From: Dave Chinner <dchinner@redhat.com>
Any inode reclaim flush that returns EAGAIN will result in the inode
reclaim being attempted again later. There is no need to issue a
warning into the logs about this situation.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/linux-2.6/xfs_sync.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 97813e7..5a4731e 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -820,10 +820,10 @@ xfs_reclaim_inode(
* call into reclaim to find it in a clean state instead of waiting for
* it now. We also don't return errors here - if the error is transient
* then the next reclaim pass will flush the inode, and if the error
- * is permanent then the next sync reclaim will relcaim the inode and
+ * is permanent then the next sync reclaim will reclaim the inode and
* pass on the error.
*/
- if (error && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
+ if (error && error != EAGAIN && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
xfs_fs_cmn_err(CE_WARN, ip->i_mount,
"inode 0x%llx background reclaim flush failed with %d",
(long long)ip->i_ino, error);
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: don't warn on EAGAIN in inode reclaim
2010-03-30 6:20 [PATCH] xfs: don't warn on EAGAIN in inode reclaim Dave Chinner
@ 2010-03-30 18:30 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2010-03-30 18:30 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Tue, 2010-03-30 at 17:20 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Any inode reclaim flush that returns EAGAIN will result in the inode
> reclaim being attempted again later. There is no need to issue a
> warning into the logs about this situation.
Looks good.
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_sync.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
> index 97813e7..5a4731e 100644
> --- a/fs/xfs/linux-2.6/xfs_sync.c
> +++ b/fs/xfs/linux-2.6/xfs_sync.c
> @@ -820,10 +820,10 @@ xfs_reclaim_inode(
> * call into reclaim to find it in a clean state instead of waiting for
> * it now. We also don't return errors here - if the error is transient
> * then the next reclaim pass will flush the inode, and if the error
> - * is permanent then the next sync reclaim will relcaim the inode and
> + * is permanent then the next sync reclaim will reclaim the inode and
> * pass on the error.
> */
> - if (error && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> + if (error && error != EAGAIN && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> xfs_fs_cmn_err(CE_WARN, ip->i_mount,
> "inode 0x%llx background reclaim flush failed with %d",
> (long long)ip->i_ino, error);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-30 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-30 6:20 [PATCH] xfs: don't warn on EAGAIN in inode reclaim Dave Chinner
2010-03-30 18:30 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.