[PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean

[PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean

[Gunnar Gudvardarson]

This is the first linux kernel patch i have ever made, i don't even
know the C programming language except reading the syntax (basic)

It didn't compile on my machine due to invalid configuration of something
on my machine, because i have not yet learned how to configure the compiler.

Signed-off-by: Gunnar Gudvardarson <gunni@wave.is>
---
 drivers/staging/asus_oled/asus_oled.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 7ebecc9..5b279fb 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -771,7 +771,7 @@ static struct usb_driver oled_driver = {
 };
 
 static CLASS_ATTR_STRING(version, S_IRUGO,
-		 	ASUS_OLED_UNDERSCORE_NAME " " ASUS_OLED_VERSION);
+			ASUS_OLED_UNDERSCORE_NAME " " ASUS_OLED_VERSION);
 
 static int __init asus_oled_init(void)
 {
-- 
1.6.3.3

Re: [PATCH] Staging: asus_oled: asus_oled.c removed an unnessecary space, making it checkpatch clean

[Greg KH]

On Fri, Apr 09, 2010 at 01:01:09PM +0000, Gunnar Gudvardarson wrote:
> This is the first linux kernel patch i have ever made, i don't even
> know the C programming language except reading the syntax (basic)

Then I would strongly encourage you to either learn it, or not modify
the code.

> It didn't compile on my machine due to invalid configuration of something
> on my machine, because i have not yet learned how to configure the compiler.

Especially as you were not able to build test the patch, which is a
basic requirement for submitting code changes.

Try reading the kernel file, Documentation/HOWTO for pointers on how to
find information to learn the C language, and to learn how to build a
kernel on your own.

best of luck,

greg k-h