* [Ocfs2-devel] [PATCH] ocfs2: Reset status if we want to restart file extension.
@ 2010-04-16 5:59 Tao Ma
2010-04-16 10:14 ` Joel Becker
0 siblings, 1 reply; 2+ messages in thread
From: Tao Ma @ 2010-04-16 5:59 UTC (permalink / raw)
To: ocfs2-devel
In __ocfs2_extend_allocation, we will restart our file extension
if ((!status) && restart_func). But there is a bug that the
status is still left as -EGAIN. This is really an old bug,
but it is masked by the return value of ocfs2_journal_dirty.
So it show up when we make ocfs2_journal_dirty void.
Signed-off-by: Tao Ma <tao.ma@oracle.com>
---
fs/ocfs2/file.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 19d16f2..6342f42 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -678,6 +678,7 @@ restarted_transaction:
if (why == RESTART_META) {
mlog(0, "restarting function.\n");
restart_func = 1;
+ status = 0;
} else {
BUG_ON(why != RESTART_TRANS);
--
1.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Reset status if we want to restart file extension.
2010-04-16 5:59 [Ocfs2-devel] [PATCH] ocfs2: Reset status if we want to restart file extension Tao Ma
@ 2010-04-16 10:14 ` Joel Becker
0 siblings, 0 replies; 2+ messages in thread
From: Joel Becker @ 2010-04-16 10:14 UTC (permalink / raw)
To: ocfs2-devel
On Fri, Apr 16, 2010 at 01:59:25PM +0800, Tao Ma wrote:
> In __ocfs2_extend_allocation, we will restart our file extension
> if ((!status) && restart_func). But there is a bug that the
> status is still left as -EGAIN. This is really an old bug,
> but it is masked by the return value of ocfs2_journal_dirty.
> So it show up when we make ocfs2_journal_dirty void.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
good catch. This patch is now in the 'fixes' branch of
ocfs2.git.
Joel
--
"The nearest approach to immortality on Earth is a government
bureau."
- James F. Byrnes
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-16 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-16 5:59 [Ocfs2-devel] [PATCH] ocfs2: Reset status if we want to restart file extension Tao Ma
2010-04-16 10:14 ` Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.