[PATCH]: libertas: fix uninitialized variable warning

[PATCH]: libertas: fix uninitialized variable warning

[Prarit Bhargava]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

Fixes:

drivers/net/wireless/libertas/rx.c: In function ‘process_rxed_802_11_packet’:
drivers/net/wireless/libertas/rx.c:354: error: ‘radiotap_hdr.flags’ may be used uninitialized in this function

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c
index e2b8d88..2319bde 100644
--- a/drivers/net/wireless/libertas/rx.c
+++ b/drivers/net/wireless/libertas/rx.c
@@ -330,9 +330,8 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,
 	/* create the exported radio header */
 
 	/* radiotap header */
-	radiotap_hdr.hdr.it_version = 0;
-	/* XXX must check this value for pad */
-	radiotap_hdr.hdr.it_pad = 0;
+	memset(&radiotap_hdr, 0, sizeof(radiotap_hdr));
+	/* XXX must check radiotap_hdr.hdr.it_pad for pad */
 	radiotap_hdr.hdr.it_len = cpu_to_le16 (sizeof(struct rx_radiotap_hdr));
 	radiotap_hdr.hdr.it_present = cpu_to_le32 (RX_RADIOTAP_PRESENT);
 	radiotap_hdr.rate = convert_mv_rate_to_radiotap(prxpd->rx_rate);

Re: [PATCH]: libertas: fix uninitialized variable warning

[Dan Williams]

On Thu, 2010-05-27 at 14:41 -0400, Prarit Bhargava wrote:
> Fixes:
> 
> drivers/net/wireless/libertas/rx.c: In function ‘process_rxed_802_11_packet’:
> drivers/net/wireless/libertas/rx.c:354: error: ‘radiotap_hdr.flags’ may be used uninitialized in this function
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>

Acked-by: Dan Williams <dcbw@redhat.com>

> 
> diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c
> index e2b8d88..2319bde 100644
> --- a/drivers/net/wireless/libertas/rx.c
> +++ b/drivers/net/wireless/libertas/rx.c
> @@ -330,9 +330,8 @@ static int process_rxed_802_11_packet(struct lbs_private *priv,
>  	/* create the exported radio header */
>  
>  	/* radiotap header */
> -	radiotap_hdr.hdr.it_version = 0;
> -	/* XXX must check this value for pad */
> -	radiotap_hdr.hdr.it_pad = 0;
> +	memset(&radiotap_hdr, 0, sizeof(radiotap_hdr));
> +	/* XXX must check radiotap_hdr.hdr.it_pad for pad */
>  	radiotap_hdr.hdr.it_len = cpu_to_le16 (sizeof(struct rx_radiotap_hdr));
>  	radiotap_hdr.hdr.it_present = cpu_to_le32 (RX_RADIOTAP_PRESENT);
>  	radiotap_hdr.rate = convert_mv_rate_to_radiotap(prxpd->rx_rate);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html