* [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
@ 2010-06-14 7:17 ` Ozan Çağlayan
0 siblings, 0 replies; 8+ messages in thread
From: Ozan Çağlayan @ 2010-06-14 7:17 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi
Acer Aspire 5710 suffers from a similar ACPI problem reported at:
http://bugzilla.kernel.org/show_bug.cgi?id=13121
like the 5710Z and 7720.
Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
---
drivers/acpi/video.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 9865d46..e2436d1 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -571,6 +571,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
},
{
.callback = video_set_bqc_offset,
+ .ident = "Acer Aspire 5710",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5710"),
+ },
+ },
+ {
+ .callback = video_set_bqc_offset,
.ident = "Acer Aspire 5710Z",
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
@ 2010-06-14 7:17 ` Ozan Çağlayan
0 siblings, 0 replies; 8+ messages in thread
From: Ozan Çağlayan @ 2010-06-14 7:17 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi
Acer Aspire 5710 suffers from a similar ACPI problem reported at:
http://bugzilla.kernel.org/show_bug.cgi?id=13121
like the 5710Z and 7720.
Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
---
drivers/acpi/video.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 9865d46..e2436d1 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -571,6 +571,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
},
{
.callback = video_set_bqc_offset,
+ .ident = "Acer Aspire 5710",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5710"),
+ },
+ },
+ {
+ .callback = video_set_bqc_offset,
.ident = "Acer Aspire 5710Z",
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
2010-06-14 7:17 ` Ozan Çağlayan
@ 2010-06-14 14:25 ` Matthew Garrett
-1 siblings, 0 replies; 8+ messages in thread
From: Matthew Garrett @ 2010-06-14 14:25 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-kernel, linux-acpi
On Mon, Jun 14, 2010 at 10:17:44AM +0300, Ozan Çağlayan wrote:
> Acer Aspire 5710 suffers from a similar ACPI problem reported at:
> http://bugzilla.kernel.org/show_bug.cgi?id=13121
Bleah. Is this really necessary? If we set maximum brightness and then
read back something other than maximum brightness, then that gives us
the offset.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
@ 2010-06-14 14:25 ` Matthew Garrett
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Garrett @ 2010-06-14 14:25 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-kernel, linux-acpi
On Mon, Jun 14, 2010 at 10:17:44AM +0300, Ozan Çağlayan wrote:
> Acer Aspire 5710 suffers from a similar ACPI problem reported at:
> http://bugzilla.kernel.org/show_bug.cgi?id=13121
Bleah. Is this really necessary? If we set maximum brightness and then
read back something other than maximum brightness, then that gives us
the offset.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
2010-06-14 14:25 ` Matthew Garrett
@ 2010-06-14 16:19 ` Ozan Çağlayan
-1 siblings, 0 replies; 8+ messages in thread
From: Ozan Çağlayan @ 2010-06-14 16:19 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-kernel, linux-acpi
Matthew Garrett wrote:
> On Mon, Jun 14, 2010 at 10:17:44AM +0300, Ozan Çağlayan wrote:
>> Acer Aspire 5710 suffers from a similar ACPI problem reported at:
>> http://bugzilla.kernel.org/show_bug.cgi?id=13121
>
> Bleah. Is this really necessary? If we set maximum brightness and then
> read back something other than maximum brightness, then that gives us
> the offset.
By *this* do you mean the specific quirk that I sent or the whole offset workaround
suggested and upstreamed in the bug report?
Actually I sync'ed the video driver from linux-2.6 on top of 2.6.31.13 and applied this patch.
The user reported that it fixed the issue but it is possible that this quirk
is NOOP and the bug is already fixed with what I've backported.
I'll let him try without the patch, and report back.
Thanks,
Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
@ 2010-06-14 16:19 ` Ozan Çağlayan
0 siblings, 0 replies; 8+ messages in thread
From: Ozan Çağlayan @ 2010-06-14 16:19 UTC (permalink / raw)
To: Matthew Garrett; +Cc: linux-kernel, linux-acpi
Matthew Garrett wrote:
> On Mon, Jun 14, 2010 at 10:17:44AM +0300, Ozan Çağlayan wrote:
>> Acer Aspire 5710 suffers from a similar ACPI problem reported at:
>> http://bugzilla.kernel.org/show_bug.cgi?id=13121
>
> Bleah. Is this really necessary? If we set maximum brightness and then
> read back something other than maximum brightness, then that gives us
> the offset.
By *this* do you mean the specific quirk that I sent or the whole offset workaround
suggested and upstreamed in the bug report?
Actually I sync'ed the video driver from linux-2.6 on top of 2.6.31.13 and applied this patch.
The user reported that it fixed the issue but it is possible that this quirk
is NOOP and the bug is already fixed with what I've backported.
I'll let him try without the patch, and report back.
Thanks,
Regards.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
2010-06-14 16:19 ` Ozan Çağlayan
@ 2010-06-14 16:36 ` Matthew Garrett
-1 siblings, 0 replies; 8+ messages in thread
From: Matthew Garrett @ 2010-06-14 16:36 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-kernel, linux-acpi
On Mon, Jun 14, 2010 at 07:19:16PM +0300, Ozan Çağlayan wrote:
> By *this* do you mean the specific quirk that I sent or the whole offset workaround
> suggested and upstreamed in the bug report?
Sorry, yeah, the entire workaround. I'll look into producing something
more generic. Right now the quirk is the only thing that'll work.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
@ 2010-06-14 16:36 ` Matthew Garrett
0 siblings, 0 replies; 8+ messages in thread
From: Matthew Garrett @ 2010-06-14 16:36 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-kernel, linux-acpi
On Mon, Jun 14, 2010 at 07:19:16PM +0300, Ozan Çağlayan wrote:
> By *this* do you mean the specific quirk that I sent or the whole offset workaround
> suggested and upstreamed in the bug report?
Sorry, yeah, the entire workaround. I'll look into producing something
more generic. Right now the quirk is the only thing that'll work.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-06-14 16:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-14 7:17 [PATCH] ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness Ozan Çağlayan
2010-06-14 7:17 ` Ozan Çağlayan
2010-06-14 14:25 ` Matthew Garrett
2010-06-14 14:25 ` Matthew Garrett
2010-06-14 16:19 ` Ozan Çağlayan
2010-06-14 16:19 ` Ozan Çağlayan
2010-06-14 16:36 ` Matthew Garrett
2010-06-14 16:36 ` Matthew Garrett
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.