* [PATCH] net: Fix error in comment on net_device_ops::ndo_get_stats
@ 2010-06-14 15:19 Ben Hutchings
2010-06-15 22:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2010-06-14 15:19 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
ndo_get_stats still returns struct net_device_stats *; there is
no struct net_device_stats64.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
include/linux/netdevice.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index d85a38e..4164285 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -671,7 +671,7 @@ struct netdev_rx_queue {
* 1. Define @ndo_get_stats64 to update a rtnl_link_stats64 structure
* (which should normally be dev->stats64) and return a ponter to
* it. The structure must not be changed asynchronously.
- * 2. Define @ndo_get_stats to update a net_device_stats64 structure
+ * 2. Define @ndo_get_stats to update a net_device_stats structure
* (which should normally be dev->stats) and return a pointer to
* it. The structure may be changed asynchronously only if each
* field is written atomically.
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: Fix error in comment on net_device_ops::ndo_get_stats
2010-06-14 15:19 [PATCH] net: Fix error in comment on net_device_ops::ndo_get_stats Ben Hutchings
@ 2010-06-15 22:10 ` David Miller
2010-06-15 22:24 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-06-15 22:10 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 14 Jun 2010 16:19:41 +0100
> ndo_get_stats still returns struct net_device_stats *; there is
> no struct net_device_stats64.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
But, I am ignoring every single patch you submit from here on
out that lacks a proper "net-2.6" or "net-next-2.6" destination
tree indication in your Subject line.
I've asked this of you at least 3 times, and you seem content to just
ignore my request. But that's OK, as I think you'll stop ignoring
me when it starts causing patches you care about to be dropped.
Thanks :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: Fix error in comment on net_device_ops::ndo_get_stats
2010-06-15 22:10 ` David Miller
@ 2010-06-15 22:24 ` Ben Hutchings
0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2010-06-15 22:24 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
On Tue, 2010-06-15 at 15:10 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 14 Jun 2010 16:19:41 +0100
>
> > ndo_get_stats still returns struct net_device_stats *; there is
> > no struct net_device_stats64.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Applied.
>
> But, I am ignoring every single patch you submit from here on
> out that lacks a proper "net-2.6" or "net-next-2.6" destination
> tree indication in your Subject line.
>
> I've asked this of you at least 3 times, and you seem content to just
> ignore my request. But that's OK, as I think you'll stop ignoring
> me when it starts causing patches you care about to be dropped.
>
> Thanks :-)
Sorry Dave, I thought net-next-2.6 was still the default and I only
needed to make it more obvious when I wanted patches to go to net-2.6.
I've added the suffix to my git configuration now.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-15 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-14 15:19 [PATCH] net: Fix error in comment on net_device_ops::ndo_get_stats Ben Hutchings
2010-06-15 22:10 ` David Miller
2010-06-15 22:24 ` Ben Hutchings
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.