All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] SQUASHME: pnfs-submit: destroy layout rather than return on state reclaim
@ 2010-06-16 16:38 Benny Halevy
  0 siblings, 0 replies; only message in thread
From: Benny Halevy @ 2010-06-16 16:38 UTC (permalink / raw)
  To: linux-nfs

In the nograce path we already lost the state and there's no point
in returning the layout.  The sync layoutreturn apparently caused a deadlock
since layoutreturn needed the state_manager to make progress.

squash into "pnfs: return layout on state recovery"

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
 fs/nfs/nfs4proc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 6b266dd..c8053a6 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1092,8 +1092,7 @@ static void pnfs4_layout_reclaim(struct nfs4_state *state)
 	/* FIXME: send gratuitous layout commits and return with the reclaim
 	 * flag during grace period
 	 */
-	pnfs_return_layout(state->inode, NULL, &state->open_stateid,
-			   RETURN_FILE, true);
+	pnfs_destroy_layout(NFS_I(state->inode));
 	pnfs_set_layout_stateid(&NFS_I(state->inode)->layout, &zero_stateid);
 #endif /* CONFIG_NFS_V4_1 */
 }
-- 
1.6.4.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-16 16:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-16 16:38 [PATCH 1/2] SQUASHME: pnfs-submit: destroy layout rather than return on state reclaim Benny Halevy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.