All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajay Kumar Gupta <ajay.gupta@ti.com>
To: linux-usb@vger.kernel.org
Cc: linux-omap@vger.kernel.org, felipe.balbi@nokia.com,
	gregkh@suse.de, Ajay Kumar Gupta <ajay.gupta@ti.com>
Subject: [PATCH 3/8] musb: fix compilation warning in host only mode
Date: Thu, 17 Jun 2010 16:10:36 +0530	[thread overview]
Message-ID: <1276771242-5201-4-git-send-email-ajay.gupta@ti.com> (raw)
In-Reply-To: <1276771242-5201-3-git-send-email-ajay.gupta@ti.com>

Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'

Also removed definition of 'mbase' from multiple places to only
at function top.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
 drivers/usb/musb/musb_core.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index f0ff893..7cc8398 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -455,6 +455,9 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 				u8 devctl, u8 power)
 {
 	irqreturn_t handled = IRQ_NONE;
+#ifdef CONFIG_USB_MUSB_HDRC_HCD
+	void __iomem	*mbase = musb->mregs;
+#endif
 
 	DBG(3, "<== Power=%02x, DevCtl=%02x, int_usb=0x%x\n", power, devctl,
 		int_usb);
@@ -469,8 +472,6 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 
 		if (devctl & MUSB_DEVCTL_HM) {
 #ifdef CONFIG_USB_MUSB_HDRC_HCD
-			void __iomem *mbase = musb->mregs;
-
 			switch (musb->xceiv->state) {
 			case OTG_STATE_A_SUSPEND:
 				/* remote wakeup?  later, GetPortStatus
@@ -548,8 +549,6 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 #ifdef CONFIG_USB_MUSB_HDRC_HCD
 	/* see manual for the order of the tests */
 	if (int_usb & MUSB_INTR_SESSREQ) {
-		void __iomem *mbase = musb->mregs;
-
 		DBG(1, "SESSION_REQUEST (%s)\n", otg_state_string(musb));
 
 		/* IRQ arrives from ID pin sense or (later, if VBUS power
@@ -598,8 +597,6 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 		case OTG_STATE_A_WAIT_BCON:
 		case OTG_STATE_A_WAIT_VRISE:
 			if (musb->vbuserr_retry) {
-				void __iomem *mbase = musb->mregs;
-
 				musb->vbuserr_retry--;
 				ignore = 1;
 				devctl |= MUSB_DEVCTL_SESSION;
@@ -703,7 +700,6 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 
 	if (int_usb & MUSB_INTR_CONNECT) {
 		struct usb_hcd *hcd = musb_to_hcd(musb);
-		void __iomem *mbase = musb->mregs;
 
 		handled = IRQ_HANDLED;
 		musb->is_active = 1;
-- 
1.6.2.4


  reply	other threads:[~2010-06-17 10:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 10:40 [patch-2.6.35-rc3+ 0/8] musb patches Ajay Kumar Gupta
2010-06-17 10:40 ` [PATCH 1/8] musb_core: make disconnect and suspend interrupts work again Ajay Kumar Gupta
     [not found]   ` <1276771242-5201-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40     ` [PATCH 2/8] MUSB: make non-OMAP platforms build with CONFIG_PM=y Ajay Kumar Gupta
2010-06-17 10:40       ` Ajay Kumar Gupta [this message]
     [not found]         ` <1276771242-5201-4-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40           ` [PATCH 4/8] USB: musb: suppress warning about unused flags Ajay Kumar Gupta
     [not found]             ` <1276771242-5201-5-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40               ` [PATCH 5/8] usb: musb: fix Blackfin ulpi stubs Ajay Kumar Gupta
2010-06-17 10:40                 ` [PATCH 6/8] usb: musb: Enable the maximum supported burst mode for DMA Ajay Kumar Gupta
     [not found]                   ` <1276771242-5201-7-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40                     ` [PATCH 7/8] musb: Kill board specific pinmux from driver file Ajay Kumar Gupta
2010-06-17 10:40                       ` [PATCH 8/8] usb: musb: Fix suspend interrupt issue in device mode Ajay Kumar Gupta
     [not found]                         ` <1276771242-5201-9-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40                           ` Ajay Kumar Gupta
2010-06-17 11:27                           ` Sergei Shtylyov
     [not found]                             ` <4C1A0687.4080002-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-17 12:15                               ` Maulik
2010-06-17 13:33                                 ` Sergei Shtylyov
     [not found]                                 ` <006501cb0e16$c08bae00$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org>
2010-06-17 14:18                                   ` Greg KH
2010-06-18  5:21                         ` David Brownell
     [not found]                       ` <1276771242-5201-8-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-24  6:11                         ` [PATCH 7/8] musb: Kill board specific pinmux from driver file Felipe Balbi
2010-06-24  6:16                           ` Gadiyar, Anand
2010-06-24  6:11                     ` [PATCH 6/8] usb: musb: Enable the maximum supported burst mode for DMA Felipe Balbi
2010-06-24  6:10                 ` [PATCH 5/8] usb: musb: fix Blackfin ulpi stubs Felipe Balbi
2010-06-24  6:08             ` [PATCH 4/8] USB: musb: suppress warning about unused flags Felipe Balbi
     [not found]               ` <20100624060857.GG8078-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-06-24  9:50                 ` Sergei Shtylyov
     [not found]                   ` <4C232A4C.6040102-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-28 14:24                     ` Felipe Balbi
2010-06-28 17:27                       ` Sergei Shtylyov
2010-06-17 11:18           ` [PATCH 3/8] musb: fix compilation warning in host only mode Sergei Shtylyov
2010-06-17 12:09             ` Gupta, Ajay Kumar
     [not found]               ` <19F8576C6E063C45BE387C64729E7394044E91B843-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-06-17 13:24                 ` Sergei Shtylyov
     [not found]                   ` <4C1A2220.7070502-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-06-17 14:09                     ` Gupta, Ajay Kumar
2010-06-24  6:03           ` Felipe Balbi
2010-06-24 11:17             ` Gupta, Ajay Kumar
2010-06-24 13:10               ` Sergei Shtylyov
     [not found]                 ` <4C235929.9030605-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-24 14:36                   ` Gupta, Ajay Kumar
2010-07-06  9:12                 ` Felipe Balbi
2010-07-06  9:13               ` Felipe Balbi
2010-07-07 22:01                 ` Greg KH
2010-07-08  1:53                   ` Gupta, Ajay Kumar
     [not found]                     ` <19F8576C6E063C45BE387C64729E7394044EB95AE0-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-08  3:35                       ` Greg KH
2010-06-24  6:02       ` [PATCH 2/8] MUSB: make non-OMAP platforms build with CONFIG_PM=y Felipe Balbi
2010-06-24  6:01     ` [PATCH 1/8] musb_core: make disconnect and suspend interrupts work again Felipe Balbi
     [not found]       ` <20100624060151.GD8078-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-06-24 17:01         ` Greg KH
     [not found] ` <1276771242-5201-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 14:17   ` [patch-2.6.35-rc3+ 0/8] musb patches Greg KH
2010-06-17 14:26     ` Gupta, Ajay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276771242-5201-4-git-send-email-ajay.gupta@ti.com \
    --to=ajay.gupta@ti.com \
    --cc=felipe.balbi@nokia.com \
    --cc=gregkh@suse.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.