All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pxa3xx: Fix HSIO bus x24 multiplier
@ 2010-06-21 21:02 Marek Vasut
  2010-06-22  8:06 ` pieterg
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2010-06-21 21:02 UTC (permalink / raw)
  To: linux-arm-kernel

The value should be 24, not 0 in the possibilities array. It was just a silly
mistake.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 arch/arm/mach-pxa/pxa3xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c
index acfa9f7..fa00148 100644
--- a/arch/arm/mach-pxa/pxa3xx.c
+++ b/arch/arm/mach-pxa/pxa3xx.c
@@ -52,7 +52,7 @@
 static unsigned char smcfs_mult[8] = { 6, 0, 8, 0, 0, 16, };
 
 /* crystal frequency to HSIO bus frequency multiplier (HSS) */
-static unsigned char hss_mult[4] = { 8, 12, 16, 0 };
+static unsigned char hss_mult[4] = { 8, 12, 16, 24 };
 
 /*
  * Get the clock frequency as reflected by CCSR and the turbo flag.
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] pxa3xx: Fix HSIO bus x24 multiplier
  2010-06-21 21:02 [PATCH] pxa3xx: Fix HSIO bus x24 multiplier Marek Vasut
@ 2010-06-22  8:06 ` pieterg
  2010-06-22 11:19   ` Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: pieterg @ 2010-06-22  8:06 UTC (permalink / raw)
  To: linux-arm-kernel

On Monday 21 June 2010 23:02:03 Marek Vasut wrote:
> The value should be 24, not 0 in the possibilities array. It was just a
> silly mistake.

Good one, reminds me that I've had this one on my list as well for a while. 
I actually went one step further, made the pxa310 use HSIO 312MHz when 
running on 624MHz.

(not sure whether the patch will apply cleanly, but cpufreq-pxa3xx.c still 
looks roughly the same at first glance..)

Rgds, Pieter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cpufreq-pxa3xx-use-a-default-HSIO-bus-clock-speed-of.patch
Type: text/x-diff
Size: 1832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100622/587105ee/attachment.bin>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pxa3xx: Fix HSIO bus x24 multiplier
  2010-06-22  8:06 ` pieterg
@ 2010-06-22 11:19   ` Marek Vasut
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2010-06-22 11:19 UTC (permalink / raw)
  To: linux-arm-kernel

Dne ?t 22. ?ervna 2010 10:06:20 pieterg napsal(a):
> On Monday 21 June 2010 23:02:03 Marek Vasut wrote:
> > The value should be 24, not 0 in the possibilities array. It was just a
> > silly mistake.
> 
> Good one, reminds me that I've had this one on my list as well for a while.
> I actually went one step further, made the pxa310 use HSIO 312MHz when
> running on 624MHz.
> 
> (not sure whether the patch will apply cleanly, but cpufreq-pxa3xx.c still
> looks roughly the same at first glance..)
> 
> Rgds, Pieter

Hi,

I'd suggest you to submit a proper patch. With your whole name and using git-
send-email.

Cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-22 11:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-21 21:02 [PATCH] pxa3xx: Fix HSIO bus x24 multiplier Marek Vasut
2010-06-22  8:06 ` pieterg
2010-06-22 11:19   ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.