* [U-Boot] (no subject)
@ 2010-06-19 23:48 Wolfgang Denk
2010-06-25 22:39 ` [U-Boot] [PATCH] Fix compiler warnings for EVB64260, P3G4 and ZUMA Anatolij Gustschin
0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2010-06-19 23:48 UTC (permalink / raw)
To: u-boot
Hi,
the EVB64260, P3G4, and ZUMA boards produce a lot of compiler warnings:
mpsc.c: In function 'mpsc_putchar_early':
mpsc.c:121: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:127: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'mpsc_getchar':
mpsc.c:204: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:207: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'mpsc_init':
mpsc.c:273: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:274: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galbrg_set_baudrate':
mpsc.c:402: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galbrg_set_CDV':
mpsc.c:416: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:419: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galbrg_enable':
mpsc.c:429: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:431: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galbrg_disable':
mpsc.c:441: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:443: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galbrg_set_clksrc':
mpsc.c:453: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:456: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_connect':
mpsc.c:585: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:599: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_route_rx_clock':
mpsc.c:630: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:637: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_route_tx_clock':
mpsc.c:647: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:654: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_config_channel_regs':
mpsc.c:685: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:686: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_set_brkcnt':
mpsc.c:707: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:710: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_set_tcschar':
mpsc.c:720: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:723: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_set_char_length':
mpsc.c:733: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:736: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_set_stop_bit_length':
mpsc.c:746: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:748: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_set_parity':
mpsc.c:758: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:767: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_enter_hunt':
mpsc.c:777: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:779: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c: In function 'galmpsc_shutdown':
mpsc.c:809: warning: dereferencing type-punned pointer will break strict-aliasing rules
Are you still maintaining these boards?
If yes, can you please submit a patch to clean this up?
If no, can you please give your OK so we remove these board
configurations from the code base?
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In the face of entropy and nothingness, you kind of have to pretend
it's not there if you want to keep writing good code."
- Karl Lehenbauer
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Fix compiler warnings for EVB64260, P3G4 and ZUMA
2010-06-19 23:48 [U-Boot] (no subject) Wolfgang Denk
@ 2010-06-25 22:39 ` Anatolij Gustschin
2010-06-29 19:54 ` Wolfgang Denk
0 siblings, 1 reply; 3+ messages in thread
From: Anatolij Gustschin @ 2010-06-25 22:39 UTC (permalink / raw)
To: u-boot
Fix following warnings:
$ ./MAKEALL EVB64260 P3G4 ZUMA
Configuring for EVB64260 board...
mpsc.c: In function 'mpsc_putchar_early':
mpsc.c:121: warning: dereferencing type-punned pointer will break strict-aliasing rules
mpsc.c:127: warning: dereferencing type-punned pointer will break strict-aliasing rules
...
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
board/evb64260/mpsc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/evb64260/mpsc.c b/board/evb64260/mpsc.c
index bee04fd..f3dc20b 100644
--- a/board/evb64260/mpsc.c
+++ b/board/evb64260/mpsc.c
@@ -88,7 +88,7 @@ static void galsdma_enable_rx(void);
/* GT64240A errata: cant read MPSC/BRG registers... so make mirrors in ram for read/modify write */
-#define MIRROR_HACK ((struct _tag_mirror_hack *)&(gd->mirror_hack))
+#define MIRROR_HACK ((struct _tag_mirror_hack *)&(gd->mirror_hack[0]))
#define GT_REG_WRITE_MIRROR_G(a,d) {MIRROR_HACK->a ## _M = d; GT_REG_WRITE(a,d);}
#define GTREGREAD_MIRROR_G(a) (MIRROR_HACK->a ## _M)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Fix compiler warnings for EVB64260, P3G4 and ZUMA
2010-06-25 22:39 ` [U-Boot] [PATCH] Fix compiler warnings for EVB64260, P3G4 and ZUMA Anatolij Gustschin
@ 2010-06-29 19:54 ` Wolfgang Denk
0 siblings, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2010-06-29 19:54 UTC (permalink / raw)
To: u-boot
Dear Anatolij Gustschin,
In message <1277505568-30524-1-git-send-email-agust@denx.de> you wrote:
> Fix following warnings:
>
> $ ./MAKEALL EVB64260 P3G4 ZUMA
> Configuring for EVB64260 board...
> mpsc.c: In function 'mpsc_putchar_early':
> mpsc.c:121: warning: dereferencing type-punned pointer will break strict-aliasing rules
> mpsc.c:127: warning: dereferencing type-punned pointer will break strict-aliasing rules
> ...
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> board/evb64260/mpsc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks a lot!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Of course there's no reason for it, it's just our policy.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-29 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-19 23:48 [U-Boot] (no subject) Wolfgang Denk
2010-06-25 22:39 ` [U-Boot] [PATCH] Fix compiler warnings for EVB64260, P3G4 and ZUMA Anatolij Gustschin
2010-06-29 19:54 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.