From: Peter Zijlstra <peterz@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Sridhar Samudrala <sri@us.ibm.com>,
Tejun Heo <tj@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitri Vorobiev <dmitri.vorobiev@movial.com>,
Jiri Kosina <jkosina@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH repost] sched: export sched_set/getaffinity to modules
Date: Thu, 01 Jul 2010 13:43:23 +0200 [thread overview]
Message-ID: <1277984603.1917.15.camel@laptop> (raw)
In-Reply-To: <1277983179.1917.10.camel@laptop>
On Thu, 2010-07-01 at 13:19 +0200, Peter Zijlstra wrote:
> On Thu, 2010-07-01 at 14:07 +0300, Michael S. Tsirkin wrote:
> > Author: Sridhar Samudrala <sri@us.ibm.com>
> >
> > sched: export sched_set/getaffinity to modules
> >
> > vhost-net driver wants to copy the affinity from the
> > owner thread to thread it creates. Export
> > sched_set/get affinity to modules to make this possible
> > when vhost is built as a module.
> Urgh,.. so why again is that a good idea?
In particular:
- who sets the affinity of the task?
- why can't it set the kernel thread's affinity too?
- what happens if someone changes the tasks' affinity?
So no, I don't think this is a sensible thing to do at all.
next prev parent reply other threads:[~2010-07-01 11:43 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 0:04 [PATCH 2/3] workqueue: Add an API to create a singlethread workqueue attached to the current task's cgroup Sridhar Samudrala
2010-05-27 9:14 ` Michael S. Tsirkin
2010-05-27 12:44 ` Oleg Nesterov
2010-05-27 13:12 ` Michael S. Tsirkin
2010-05-27 13:48 ` Oleg Nesterov
2010-05-27 16:15 ` Tejun Heo
2010-05-27 16:39 ` Michael S. Tsirkin
2010-05-27 16:56 ` Tejun Heo
2010-05-27 17:32 ` Michael S. Tsirkin
2010-05-27 21:20 ` Tejun Heo
2010-05-28 15:08 ` Michael S. Tsirkin
2010-05-28 15:54 ` Tejun Heo
2010-05-30 11:29 ` Michael S. Tsirkin
2010-05-30 20:24 ` [PATCH 1/3] vhost: replace vhost_workqueue with per-vhost kthread Tejun Heo
2010-05-31 14:39 ` Oleg Nesterov
2010-05-31 15:07 ` Tejun Heo
2010-05-31 15:31 ` Oleg Nesterov
2010-05-31 15:38 ` Tejun Heo
2010-05-31 15:22 ` Michael S. Tsirkin
2010-05-31 15:45 ` Tejun Heo
2010-05-31 16:00 ` Michael S. Tsirkin
2010-06-01 9:34 ` Tejun Heo
2010-06-02 18:40 ` [PATCH UPDATED " Tejun Heo
2010-06-02 21:34 ` Sridhar Samudrala
2010-07-22 15:58 ` Michael S. Tsirkin
2010-07-22 21:21 ` Tejun Heo
2010-07-24 19:14 ` Michael S. Tsirkin
2010-07-25 7:41 ` Tejun Heo
2010-07-25 10:04 ` Michael S. Tsirkin
2010-07-26 15:25 ` Michael S. Tsirkin
2010-07-26 15:34 ` Tejun Heo
2010-07-26 15:46 ` Tejun Heo
2010-07-26 15:51 ` Michael S. Tsirkin
2010-07-26 15:50 ` Michael S. Tsirkin
2010-07-26 16:05 ` Tejun Heo
2010-07-26 16:14 ` Tejun Heo
2010-07-26 16:31 ` Michael S. Tsirkin
2010-07-26 18:51 ` Tejun Heo
2010-07-26 19:57 ` Michael S. Tsirkin
2010-07-27 8:18 ` Tejun Heo
2010-07-26 16:51 ` Michael S. Tsirkin
2010-07-26 19:14 ` Tejun Heo
2010-07-26 19:31 ` Tejun Heo
2010-07-26 19:59 ` Michael S. Tsirkin
2010-07-27 19:19 ` Michael S. Tsirkin
2010-07-28 7:48 ` Tejun Heo
2010-07-28 10:48 ` Michael S. Tsirkin
2010-07-28 12:00 ` Tejun Heo
2010-07-26 16:57 ` Michael S. Tsirkin
2010-07-26 16:23 ` Michael S. Tsirkin
2010-07-26 19:04 ` Tejun Heo
2010-07-26 20:19 ` Michael S. Tsirkin
2010-07-27 8:21 ` Tejun Heo
2010-06-01 9:34 ` [PATCH 2/3] cgroups: Add an API to attach a task to current task's cgroup Tejun Heo
2010-06-01 9:35 ` [PATCH 3/3] vhost: apply cpumask and cgroup to vhost workers Tejun Heo
2010-06-01 10:17 ` Michael S. Tsirkin
2010-06-01 10:56 ` Tejun Heo
2010-06-01 17:19 ` Sridhar Samudrala
2010-06-01 23:59 ` Tejun Heo
2010-06-01 14:13 ` [PATCH 1/3] vhost: replace vhost_workqueue with per-vhost kthread Paul E. McKenney
2010-05-30 20:24 ` [PATCH 2/3] cgroups: Add an API to attach a task to current task's cgroup Tejun Heo
2010-05-31 1:07 ` Li Zefan
2010-05-31 7:00 ` Tejun Heo
2010-05-30 20:25 ` [PATCH 3/3] vhost: apply cpumask and cgroup to vhost pollers Tejun Heo
2010-05-31 1:11 ` Li Zefan
2010-05-31 6:58 ` [PATCH UPDATED " Tejun Heo
2010-05-31 7:48 ` Li Zefan
2010-05-31 10:20 ` [PATCH UPDATED2 " Tejun Heo
2010-06-24 8:11 ` [PATCH " Michael S. Tsirkin
2010-06-24 22:45 ` Sridhar Samudrala
2010-06-25 10:10 ` [PATCH] sched: export sched_set/getaffinity (was Re: [PATCH 3/3] vhost: apply cpumask and cgroup to vhost pollers) Michael S. Tsirkin
2010-07-01 11:07 ` [PATCH repost] sched: export sched_set/getaffinity to modules Michael S. Tsirkin
2010-07-01 11:19 ` Peter Zijlstra
2010-07-01 11:43 ` Peter Zijlstra [this message]
2010-07-01 11:55 ` Michael S. Tsirkin
2010-07-01 12:23 ` Michael S. Tsirkin
2010-07-01 12:34 ` Peter Zijlstra
2010-07-01 12:46 ` Peter Zijlstra
2010-07-01 13:08 ` Michael S. Tsirkin
2010-07-01 13:30 ` Peter Zijlstra
2010-07-01 13:39 ` Michael S. Tsirkin
2010-07-01 13:57 ` Peter Zijlstra
2010-07-01 14:27 ` Tejun Heo
2010-07-01 14:46 ` Oleg Nesterov
2010-07-01 14:53 ` Tejun Heo
2010-07-01 14:55 ` Peter Zijlstra
2010-07-02 18:01 ` Sridhar Samudrala
2010-07-02 18:11 ` Peter Zijlstra
2010-07-02 21:06 ` Oleg Nesterov
2010-07-04 9:00 ` Michael S. Tsirkin
2010-07-13 6:59 ` Sridhar Samudrala
2010-07-13 11:09 ` Michael S. Tsirkin
2010-07-14 23:26 ` Sridhar Samudrala
2010-07-15 0:05 ` Oleg Nesterov
2010-07-15 5:29 ` Sridhar Samudrala
2010-07-26 17:12 ` Michael S. Tsirkin
2010-07-26 17:51 ` Sridhar Samudrala
2010-07-26 18:08 ` Oleg Nesterov
2010-07-26 19:55 ` Michael S. Tsirkin
2010-07-26 20:27 ` Michael S. Tsirkin
2010-07-27 4:55 ` Michael S. Tsirkin
2010-08-04 10:45 ` Peter Zijlstra
2010-07-27 15:41 ` Michael S. Tsirkin
2010-07-30 14:19 ` Oleg Nesterov
2010-07-30 14:31 ` Tejun Heo
2010-08-01 8:50 ` Michael S. Tsirkin
2010-08-02 15:02 ` Oleg Nesterov
2010-07-01 14:33 ` Oleg Nesterov
2010-07-01 12:32 ` Peter Zijlstra
2010-07-01 12:50 ` Michael S. Tsirkin
2010-07-01 13:07 ` Peter Zijlstra
2010-07-01 13:22 ` Michael S. Tsirkin
2010-05-27 16:24 ` [PATCH 2/3] workqueue: Add an API to create a singlethread workqueue attached to the current task's cgroup Sridhar Samudrala
2010-05-27 16:41 ` Michael S. Tsirkin
2010-05-27 17:30 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277984603.1917.15.camel@laptop \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dmitri.vorobiev@movial.com \
--cc=jkosina@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sri@us.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.