All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/6] Mtd: fixed coding style indent errors
@ 2010-07-12  2:46 ` Neal B
  0 siblings, 0 replies; 4+ messages in thread
From: Neal B @ 2010-07-12  2:46 UTC (permalink / raw)
  To: Artem.Bityutskiy
  Cc: dwmw2, rmk+kernel, cascardo, mohanlaljangir, maximlevitsky,
	Julia Lawall, jkosina, linux-mtd, linux-kernel

 From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
From: Neal Buckendahl <nealb001@gmail.com>
Date: Sun, 11 Jul 2010 16:58:24 -0500
Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
checkpatch.pl tool
  Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

---
  drivers/mtd/afs.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
index cec7ab9..2bea681 100644
--- a/drivers/mtd/afs.c
+++ b/drivers/mtd/afs.c
@@ -162,8 +162,8 @@ afs_read_iis(struct mtd_info *mtd, struct 
image_info_struct *iis, u_int ptr)
  }

  static int parse_afs_partitions(struct mtd_info *mtd,
-                         struct mtd_partition **pparts,
-                         unsigned long origin)
+			struct mtd_partition **pparts,
+			unsigned long origin)
  {
  	struct mtd_partition *parts;
  	u_int mask, off, idx, sz;
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/6] Mtd: fixed coding style indent errors
@ 2010-07-12  2:46 ` Neal B
  0 siblings, 0 replies; 4+ messages in thread
From: Neal B @ 2010-07-12  2:46 UTC (permalink / raw)
  To: Artem.Bityutskiy
  Cc: maximlevitsky, cascardo, linux-kernel, Julia Lawall, linux-mtd,
	jkosina, mohanlaljangir, rmk+kernel, dwmw2

 From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
From: Neal Buckendahl <nealb001@gmail.com>
Date: Sun, 11 Jul 2010 16:58:24 -0500
Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
checkpatch.pl tool
  Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

---
  drivers/mtd/afs.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
index cec7ab9..2bea681 100644
--- a/drivers/mtd/afs.c
+++ b/drivers/mtd/afs.c
@@ -162,8 +162,8 @@ afs_read_iis(struct mtd_info *mtd, struct 
image_info_struct *iis, u_int ptr)
  }

  static int parse_afs_partitions(struct mtd_info *mtd,
-                         struct mtd_partition **pparts,
-                         unsigned long origin)
+			struct mtd_partition **pparts,
+			unsigned long origin)
  {
  	struct mtd_partition *parts;
  	u_int mask, off, idx, sz;
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] Mtd: fixed coding style indent errors
  2010-07-12  2:46 ` Neal B
@ 2010-07-18  7:27   ` Artem Bityutskiy
  -1 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-07-18  7:27 UTC (permalink / raw)
  To: Neal B
  Cc: Artem.Bityutskiy, dwmw2, rmk+kernel, cascardo, mohanlaljangir,
	maximlevitsky, Julia Lawall, jkosina, linux-mtd, linux-kernel

On Sun, 2010-07-11 at 21:46 -0500, Neal B wrote:
> From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
> From: Neal Buckendahl <nealb001@gmail.com>
> Date: Sun, 11 Jul 2010 16:58:24 -0500
> Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
> checkpatch.pl tool
>   Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

Unfortunately, your patches are line-wrapped. You should send
non-wrapped patches. Use git send-email - it can do the trick (use
--dry-run first, check everything is fine, then send).

Also, int the commit message, it is a bit better to specify which
exactly warning it fixes.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/6] Mtd: fixed coding style indent errors
@ 2010-07-18  7:27   ` Artem Bityutskiy
  0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-07-18  7:27 UTC (permalink / raw)
  To: Neal B
  Cc: Artem.Bityutskiy, maximlevitsky, cascardo, linux-kernel,
	Julia Lawall, linux-mtd, jkosina, mohanlaljangir, rmk+kernel,
	dwmw2

On Sun, 2010-07-11 at 21:46 -0500, Neal B wrote:
> From f4301b9c13f65d173d67759d53acaf3e8d2331c6 Mon Sep 17 00:00:00 2001
> From: Neal Buckendahl <nealb001@gmail.com>
> Date: Sun, 11 Jul 2010 16:58:24 -0500
> Subject: [PATCH 1/6] Mtd: fixed coding style indent errors found by the 
> checkpatch.pl tool
>   Signed-off-by: Neal Buckendahl <nealb001@gmail.com>

Unfortunately, your patches are line-wrapped. You should send
non-wrapped patches. Use git send-email - it can do the trick (use
--dry-run first, check everything is fine, then send).

Also, int the commit message, it is a bit better to specify which
exactly warning it fixes.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-07-18  7:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-12  2:46 [PATCH 1/6] Mtd: fixed coding style indent errors Neal B
2010-07-12  2:46 ` Neal B
2010-07-18  7:27 ` Artem Bityutskiy
2010-07-18  7:27   ` Artem Bityutskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.