All of lore.kernel.org
 help / color / mirror / Atom feed
* UBIFS memleak ?
@ 2010-07-13  9:21 Matthieu CASTET
  2010-07-18  8:53 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Matthieu CASTET @ 2010-07-13  9:21 UTC (permalink / raw)
  To: linux-mtd

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Hi,

in mount_ubifs shouldn't we do something like that in case of 
ubifs_leb_unmap error ?


Matthieu

[-- Attachment #2: ubifs.diff --]
[-- Type: text/x-diff, Size: 332 bytes --]

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 4d2f215..9362f16 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1318,7 +1318,7 @@ static int mount_ubifs(struct ubifs_info *c)
 			 */
 			err = ubifs_leb_unmap(c, c->gc_lnum);
 			if (err)
-				return err;
+				goto out_orphans;
 		}
 
 		err = dbg_check_lprops(c);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: UBIFS memleak ?
  2010-07-13  9:21 UBIFS memleak ? Matthieu CASTET
@ 2010-07-18  8:53 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2010-07-18  8:53 UTC (permalink / raw)
  To: Matthieu CASTET; +Cc: linux-mtd

On Tue, 2010-07-13 at 11:21 +0200, Matthieu CASTET wrote:
> Hi,
> 
> in mount_ubifs shouldn't we do something like that in case of 
> ubifs_leb_unmap error ?

Yes, are you going to send a proper patch with signed-off-by?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-18  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-13  9:21 UBIFS memleak ? Matthieu CASTET
2010-07-18  8:53 ` Artem Bityutskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.