* [PATCH] char: mxser: remove unnesesary NULL check
@ 2010-07-23 16:34 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-23 16:34 UTC (permalink / raw)
To: kernel-janitors
Cc: Jiri Slaby, Greg Kroah-Hartman, Alan Cox, Andrew Morton,
Tejun Heo, linux-kernel
mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
NULL check is performed in mxser_interrupt() so it is redundant here.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/char/mxser.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index d2692d4..3fc89da 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
port->icount.tx += (cnt - port->xmit_cnt);
- if (port->xmit_cnt < WAKEUP_CHARS && tty)
+ if (port->xmit_cnt < WAKEUP_CHARS)
tty_wakeup(tty);
if (port->xmit_cnt <= 0) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] char: mxser: remove unnesesary NULL check
@ 2010-07-23 16:34 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-23 16:34 UTC (permalink / raw)
To: kernel-janitors
Cc: Jiri Slaby, Greg Kroah-Hartman, Alan Cox, Andrew Morton,
Tejun Heo, linux-kernel
mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
NULL check is performed in mxser_interrupt() so it is redundant here.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/char/mxser.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index d2692d4..3fc89da 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
port->icount.tx += (cnt - port->xmit_cnt);
- if (port->xmit_cnt < WAKEUP_CHARS && tty)
+ if (port->xmit_cnt < WAKEUP_CHARS)
tty_wakeup(tty);
if (port->xmit_cnt <= 0) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] char: mxser: remove unnesesary NULL check
2010-07-23 16:34 ` Kulikov Vasiliy
@ 2010-07-23 19:18 ` Jiri Slaby
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2010-07-23 19:18 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Alan Cox, Andrew Morton,
Tejun Heo, linux-kernel
On 07/23/2010 06:34 PM, Kulikov Vasiliy wrote:
> mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
> NULL check is performed in mxser_interrupt() so it is redundant here.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/char/mxser.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index d2692d4..3fc89da 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
> port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
> port->icount.tx += (cnt - port->xmit_cnt);
>
> - if (port->xmit_cnt < WAKEUP_CHARS && tty)
> + if (port->xmit_cnt < WAKEUP_CHARS)
> tty_wakeup(tty);
>
> if (port->xmit_cnt <= 0) {
--
js
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] char: mxser: remove unnesesary NULL check
@ 2010-07-23 19:18 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2010-07-23 19:18 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Alan Cox, Andrew Morton,
Tejun Heo, linux-kernel
On 07/23/2010 06:34 PM, Kulikov Vasiliy wrote:
> mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
> NULL check is performed in mxser_interrupt() so it is redundant here.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/char/mxser.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index d2692d4..3fc89da 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
> port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
> port->icount.tx += (cnt - port->xmit_cnt);
>
> - if (port->xmit_cnt < WAKEUP_CHARS && tty)
> + if (port->xmit_cnt < WAKEUP_CHARS)
> tty_wakeup(tty);
>
> if (port->xmit_cnt <= 0) {
--
js
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-23 19:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-23 16:34 [PATCH] char: mxser: remove unnesesary NULL check Kulikov Vasiliy
2010-07-23 16:34 ` Kulikov Vasiliy
2010-07-23 19:18 ` Jiri Slaby
2010-07-23 19:18 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.