All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	KVM list <kvm@vger.kernel.org>
Subject: [PATCH 00/27] KVM PPC PV framework v3
Date: Thu, 29 Jul 2010 14:47:41 +0200	[thread overview]
Message-ID: <1280407688-9815-1-git-send-email-agraf@suse.de> (raw)

On PPC we run PR=0 (kernel mode) code in PR=1 (user mode) and don't use the
hypervisor extensions.

While that is all great to show that virtualization is possible, there are
quite some cases where the emulation overhead of privileged instructions is
killing performance.

This patchset tackles exactly that issue. It introduces a paravirtual framework
using which KVM and Linux share a page to exchange register state with. That
way we don't have to switch to the hypervisor just to change a value of a
privileged register.

To prove my point, I ran the same test I did for the MMU optimizations against
the PV framework. Here are the results:

[without]

debian-powerpc:~# time for i in {1..1000}; do /bin/echo hello > /dev/null; done

real    0m14.659s
user    0m8.967s
sys     0m5.688s

[with]

debian-powerpc:~# time for i in {1..1000}; do /bin/echo hello > /dev/null; done

real    0m7.557s
user    0m4.121s
sys     0m3.426s


So this is a significant performance improvement! I'm quite happy how fast this
whole thing becomes :)

I tried to take all comments I've heard from people so far about such a PV
framework into account. In case you told me something before that is a no-go
and I still did it, please just tell me again.

To make use of this whole thing you also need patches to qemu and openbios. I
have them in my queue, but want to see this set upstream first before I start
sending patches to the other projects.

Now go and have fun with fast VMs on PPC! Get yourself a G5 on ebay and start
experiencing the power yourself. - heh

v1 -> v2:

  - change hypervisor calls to use r0 and r3
  - make crit detection only trigger in supervisor mode
  - RMO -> PAM
  - introduce kvm_patch_ins
  - only flush icache when patching
  - introduce kvm_patch_ins_b
  - update documentation

v2 -> v3:

  - use pPAPR conventions for hypercall interface
  - only use r0 as magic sc number
  - remove PVR detection
  - remove BookE shared page mapping support
  - combine book3s-64 and -32 magic page ra override
  - add self-test check if the mapping works to guest code
  - add safety check for relocatable kernels

Alexander Graf (27):
  KVM: PPC: Introduce shared page
  KVM: PPC: Convert MSR to shared page
  KVM: PPC: Convert DSISR to shared page
  KVM: PPC: Convert DAR to shared page.
  KVM: PPC: Convert SRR0 and SRR1 to shared page
  KVM: PPC: Convert SPRG[0-4] to shared page
  KVM: PPC: Implement hypervisor interface
  KVM: PPC: Add PV guest critical sections
  KVM: PPC: Add PV guest scratch registers
  KVM: PPC: Tell guest about pending interrupts
  KVM: PPC: Make PAM a define
  KVM: PPC: First magic page steps
  KVM: PPC: Magic Page Book3s support
  KVM: PPC: Expose magic page support to guest
  KVM: Move kvm_guest_init out of generic code
  KVM: PPC: Generic KVM PV guest support
  KVM: PPC: KVM PV guest stubs
  KVM: PPC: PV instructions to loads and stores
  KVM: PPC: PV tlbsync to nop
  KVM: PPC: Introduce kvm_tmp framework
  KVM: PPC: Introduce branch patching helper
  KVM: PPC: PV assembler helpers
  KVM: PPC: PV mtmsrd L=1
  KVM: PPC: PV mtmsrd L=0 and mtmsr
  KVM: PPC: PV wrteei
  KVM: PPC: Add Documentation about PV interface
  KVM: PPC: Add get_pvinfo interface to query hypercall instructions

 Documentation/kvm/api.txt                |   23 ++
 Documentation/kvm/ppc-pv.txt             |  180 +++++++++++
 arch/powerpc/include/asm/kvm_book3s.h    |    2 +-
 arch/powerpc/include/asm/kvm_host.h      |   15 +-
 arch/powerpc/include/asm/kvm_para.h      |  135 ++++++++-
 arch/powerpc/include/asm/kvm_ppc.h       |    1 +
 arch/powerpc/kernel/Makefile             |    2 +
 arch/powerpc/kernel/asm-offsets.c        |   18 +-
 arch/powerpc/kernel/kvm.c                |  485 ++++++++++++++++++++++++++++++
 arch/powerpc/kernel/kvm_emul.S           |  247 +++++++++++++++
 arch/powerpc/kvm/44x.c                   |    7 +
 arch/powerpc/kvm/44x_tlb.c               |    8 +-
 arch/powerpc/kvm/book3s.c                |  188 ++++++++----
 arch/powerpc/kvm/book3s_32_mmu.c         |   28 ++-
 arch/powerpc/kvm/book3s_32_mmu_host.c    |    6 +-
 arch/powerpc/kvm/book3s_64_mmu.c         |   42 +++-
 arch/powerpc/kvm/book3s_64_mmu_host.c    |   13 +-
 arch/powerpc/kvm/book3s_emulate.c        |   25 +-
 arch/powerpc/kvm/book3s_paired_singles.c |   11 +-
 arch/powerpc/kvm/booke.c                 |   83 ++++--
 arch/powerpc/kvm/booke.h                 |    6 +-
 arch/powerpc/kvm/booke_emulate.c         |   14 +-
 arch/powerpc/kvm/booke_interrupts.S      |    3 +-
 arch/powerpc/kvm/e500.c                  |    7 +
 arch/powerpc/kvm/e500_tlb.c              |   12 +-
 arch/powerpc/kvm/e500_tlb.h              |    2 +-
 arch/powerpc/kvm/emulate.c               |   36 ++-
 arch/powerpc/kvm/powerpc.c               |   84 +++++-
 arch/powerpc/platforms/Kconfig           |   10 +
 arch/x86/include/asm/kvm_para.h          |    6 +
 include/linux/kvm.h                      |   11 +
 include/linux/kvm_para.h                 |    7 +-
 32 files changed, 1538 insertions(+), 179 deletions(-)
 create mode 100644 Documentation/kvm/ppc-pv.txt
 create mode 100644 arch/powerpc/kernel/kvm.c
 create mode 100644 arch/powerpc/kernel/kvm_emul.S

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	KVM list <kvm@vger.kernel.org>
Subject: [PATCH 00/27] KVM PPC PV framework v3
Date: Thu, 29 Jul 2010 12:47:41 +0000	[thread overview]
Message-ID: <1280407688-9815-1-git-send-email-agraf@suse.de> (raw)

On PPC we run PR=0 (kernel mode) code in PR=1 (user mode) and don't use the
hypervisor extensions.

While that is all great to show that virtualization is possible, there are
quite some cases where the emulation overhead of privileged instructions is
killing performance.

This patchset tackles exactly that issue. It introduces a paravirtual framework
using which KVM and Linux share a page to exchange register state with. That
way we don't have to switch to the hypervisor just to change a value of a
privileged register.

To prove my point, I ran the same test I did for the MMU optimizations against
the PV framework. Here are the results:

[without]

debian-powerpc:~# time for i in {1..1000}; do /bin/echo hello > /dev/null; done

real    0m14.659s
user    0m8.967s
sys     0m5.688s

[with]

debian-powerpc:~# time for i in {1..1000}; do /bin/echo hello > /dev/null; done

real    0m7.557s
user    0m4.121s
sys     0m3.426s


So this is a significant performance improvement! I'm quite happy how fast this
whole thing becomes :)

I tried to take all comments I've heard from people so far about such a PV
framework into account. In case you told me something before that is a no-go
and I still did it, please just tell me again.

To make use of this whole thing you also need patches to qemu and openbios. I
have them in my queue, but want to see this set upstream first before I start
sending patches to the other projects.

Now go and have fun with fast VMs on PPC! Get yourself a G5 on ebay and start
experiencing the power yourself. - heh

v1 -> v2:

  - change hypervisor calls to use r0 and r3
  - make crit detection only trigger in supervisor mode
  - RMO -> PAM
  - introduce kvm_patch_ins
  - only flush icache when patching
  - introduce kvm_patch_ins_b
  - update documentation

v2 -> v3:

  - use pPAPR conventions for hypercall interface
  - only use r0 as magic sc number
  - remove PVR detection
  - remove BookE shared page mapping support
  - combine book3s-64 and -32 magic page ra override
  - add self-test check if the mapping works to guest code
  - add safety check for relocatable kernels

Alexander Graf (27):
  KVM: PPC: Introduce shared page
  KVM: PPC: Convert MSR to shared page
  KVM: PPC: Convert DSISR to shared page
  KVM: PPC: Convert DAR to shared page.
  KVM: PPC: Convert SRR0 and SRR1 to shared page
  KVM: PPC: Convert SPRG[0-4] to shared page
  KVM: PPC: Implement hypervisor interface
  KVM: PPC: Add PV guest critical sections
  KVM: PPC: Add PV guest scratch registers
  KVM: PPC: Tell guest about pending interrupts
  KVM: PPC: Make PAM a define
  KVM: PPC: First magic page steps
  KVM: PPC: Magic Page Book3s support
  KVM: PPC: Expose magic page support to guest
  KVM: Move kvm_guest_init out of generic code
  KVM: PPC: Generic KVM PV guest support
  KVM: PPC: KVM PV guest stubs
  KVM: PPC: PV instructions to loads and stores
  KVM: PPC: PV tlbsync to nop
  KVM: PPC: Introduce kvm_tmp framework
  KVM: PPC: Introduce branch patching helper
  KVM: PPC: PV assembler helpers
  KVM: PPC: PV mtmsrd L=1
  KVM: PPC: PV mtmsrd L=0 and mtmsr
  KVM: PPC: PV wrteei
  KVM: PPC: Add Documentation about PV interface
  KVM: PPC: Add get_pvinfo interface to query hypercall instructions

 Documentation/kvm/api.txt                |   23 ++
 Documentation/kvm/ppc-pv.txt             |  180 +++++++++++
 arch/powerpc/include/asm/kvm_book3s.h    |    2 +-
 arch/powerpc/include/asm/kvm_host.h      |   15 +-
 arch/powerpc/include/asm/kvm_para.h      |  135 ++++++++-
 arch/powerpc/include/asm/kvm_ppc.h       |    1 +
 arch/powerpc/kernel/Makefile             |    2 +
 arch/powerpc/kernel/asm-offsets.c        |   18 +-
 arch/powerpc/kernel/kvm.c                |  485 ++++++++++++++++++++++++++++++
 arch/powerpc/kernel/kvm_emul.S           |  247 +++++++++++++++
 arch/powerpc/kvm/44x.c                   |    7 +
 arch/powerpc/kvm/44x_tlb.c               |    8 +-
 arch/powerpc/kvm/book3s.c                |  188 ++++++++----
 arch/powerpc/kvm/book3s_32_mmu.c         |   28 ++-
 arch/powerpc/kvm/book3s_32_mmu_host.c    |    6 +-
 arch/powerpc/kvm/book3s_64_mmu.c         |   42 +++-
 arch/powerpc/kvm/book3s_64_mmu_host.c    |   13 +-
 arch/powerpc/kvm/book3s_emulate.c        |   25 +-
 arch/powerpc/kvm/book3s_paired_singles.c |   11 +-
 arch/powerpc/kvm/booke.c                 |   83 ++++--
 arch/powerpc/kvm/booke.h                 |    6 +-
 arch/powerpc/kvm/booke_emulate.c         |   14 +-
 arch/powerpc/kvm/booke_interrupts.S      |    3 +-
 arch/powerpc/kvm/e500.c                  |    7 +
 arch/powerpc/kvm/e500_tlb.c              |   12 +-
 arch/powerpc/kvm/e500_tlb.h              |    2 +-
 arch/powerpc/kvm/emulate.c               |   36 ++-
 arch/powerpc/kvm/powerpc.c               |   84 +++++-
 arch/powerpc/platforms/Kconfig           |   10 +
 arch/x86/include/asm/kvm_para.h          |    6 +
 include/linux/kvm.h                      |   11 +
 include/linux/kvm_para.h                 |    7 +-
 32 files changed, 1538 insertions(+), 179 deletions(-)
 create mode 100644 Documentation/kvm/ppc-pv.txt
 create mode 100644 arch/powerpc/kernel/kvm.c
 create mode 100644 arch/powerpc/kernel/kvm_emul.S


             reply	other threads:[~2010-07-29 12:47 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 12:47 Alexander Graf [this message]
2010-07-29 12:47 ` [PATCH 00/27] KVM PPC PV framework v3 Alexander Graf
2010-07-29 12:47 ` [PATCH 04/27] KVM: PPC: Convert DAR to shared page Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 05/27] KVM: PPC: Convert SRR0 and SRR1 " Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 07/27] KVM: PPC: Implement hypervisor interface Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 09/27] KVM: PPC: Add PV guest scratch registers Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 11/27] KVM: PPC: Make PAM a define Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 12/27] KVM: PPC: First magic page steps Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 13/27] KVM: PPC: Magic Page Book3s support Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 15/27] KVM: Move kvm_guest_init out of generic code Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 16/27] KVM: PPC: Generic KVM PV guest support Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47 ` [PATCH 17/27] KVM: PPC: KVM PV guest stubs Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
     [not found]   ` <1280407688-9815-18-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-08-05 17:16     ` Hollis Blanchard
2010-08-05 17:16       ` Hollis Blanchard
2010-08-05 17:16       ` Hollis Blanchard
2010-07-29 12:47 ` [PATCH 18/27] KVM: PPC: PV instructions to loads and stores Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:47   ` Alexander Graf
2010-07-29 12:48 ` [PATCH 22/27] KVM: PPC: PV assembler helpers Alexander Graf
2010-07-29 12:48   ` Alexander Graf
2010-07-29 12:48   ` Alexander Graf
2010-07-29 12:48 ` [PATCH 24/27] KVM: PPC: PV mtmsrd L=0 and mtmsr Alexander Graf
2010-07-29 12:48   ` Alexander Graf
2010-07-29 12:48   ` Alexander Graf
2010-07-29 12:48 ` [PATCH 27/27] KVM: PPC: Add get_pvinfo interface to query hypercall instructions Alexander Graf
2010-07-29 12:48   ` Alexander Graf
2010-07-29 12:48   ` Alexander Graf
     [not found] ` <1280407688-9815-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-07-29 12:47   ` [PATCH 01/27] KVM: PPC: Introduce shared page Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
     [not found]     ` <1280407688-9815-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-08-05 17:05       ` Hollis Blanchard
2010-08-05 17:05         ` Hollis Blanchard
2010-08-05 17:05         ` Hollis Blanchard
2010-07-29 12:47   ` [PATCH 02/27] KVM: PPC: Convert MSR to " Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47   ` [PATCH 03/27] KVM: PPC: Convert DSISR " Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47   ` [PATCH 06/27] KVM: PPC: Convert SPRG[0-4] " Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47   ` [PATCH 08/27] KVM: PPC: Add PV guest critical sections Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47   ` [PATCH 10/27] KVM: PPC: Tell guest about pending interrupts Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47   ` [PATCH 14/27] KVM: PPC: Expose magic page support to guest Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:47     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 19/27] KVM: PPC: PV tlbsync to nop Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 20/27] KVM: PPC: Introduce kvm_tmp framework Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 21/27] KVM: PPC: Introduce branch patching helper Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 23/27] KVM: PPC: PV mtmsrd L=1 Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 25/27] KVM: PPC: PV wrteei Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48   ` [PATCH 26/27] KVM: PPC: Add Documentation about PV interface Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-07-29 12:48     ` Alexander Graf
2010-08-01 14:02   ` [PATCH 00/27] KVM PPC PV framework v3 Avi Kivity
2010-08-01 14:02     ` Avi Kivity
2010-08-01 14:02     ` Avi Kivity
     [not found]     ` <4C557E7A.3010606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-08-01 20:21       ` Alexander Graf
2010-08-01 20:21         ` Alexander Graf
2010-08-01 20:21         ` Alexander Graf
2010-08-03 16:16         ` Scott Wood
2010-08-03 16:16           ` Scott Wood
2010-08-03 16:16           ` Scott Wood
     [not found]           ` <20100803111611.38ca87e6-1MYqz8GpK7RekFaExTCHk1jVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2010-08-05  7:57             ` Avi Kivity
2010-08-05  7:57               ` Avi Kivity
2010-08-05  7:57               ` Avi Kivity
2010-08-05  8:01               ` Alexander Graf
2010-08-05  8:01                 ` Alexander Graf
2010-08-05  8:01                 ` Alexander Graf
2010-08-05  8:05                 ` Avi Kivity
2010-08-05  8:05                   ` Avi Kivity
2010-08-05  8:25   ` Avi Kivity
2010-08-05  8:25     ` Avi Kivity
2010-08-05  8:25     ` Avi Kivity
2010-08-06 16:28   ` Kumar Gala
2010-08-06 16:28     ` Kumar Gala
2010-08-06 16:28     ` Kumar Gala
     [not found]     ` <17DF4824-9EC7-44F4-9408-EA6241C33E70-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2010-08-16 13:11       ` Alexander Graf
2010-08-16 13:11         ` Alexander Graf
2010-08-16 13:11         ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280407688-9815-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.