All of lore.kernel.org
 help / color / mirror / Atom feed
* recipes for gsnmp and scli
@ 2010-08-04 10:43 Henri Bragge
  2010-08-04 10:43 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  0 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 10:43 UTC (permalink / raw)
  To: openembedded-devel


gsnmp:
http://packages.debian.org/sid/libgsnmp0

scli:
http://packages.debian.org/sid/scli

Tested with Angstrom on at91sam9261ek board, bitbake 1.8.18.

 gsnmp/gsnmp.inc    |    6 ++++++
 gsnmp/gsnmp_svn.bb |    8 ++++++++
 scli/scli.inc      |    6 ++++++
 scli/scli_svn.bb   |    8 ++++++++
 4 files changed, 28 insertions(+)




^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH 1/2] recipe for gsnmp-0.3.0
  2010-08-04 10:43 recipes for gsnmp and scli Henri Bragge
@ 2010-08-04 10:43 ` Henri Bragge
  2010-08-04 10:43   ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
  2010-08-04 11:51   ` [PATCH 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
  0 siblings, 2 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 10:43 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp.inc    |    6 ++++++
 recipes/gsnmp/gsnmp_svn.bb |    8 ++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp.inc
 create mode 100644 recipes/gsnmp/gsnmp_svn.bb

diff --git a/recipes/gsnmp/gsnmp.inc b/recipes/gsnmp/gsnmp.inc
new file mode 100644
index 0000000..66e88cc
--- /dev/null
+++ b/recipes/gsnmp/gsnmp.inc
@@ -0,0 +1,6 @@
+DESCRIPTION = "SNMP library written on top of glib and gnet."
+LICENSE = "GPLv2"
+SECTION = "libs/network"
+DEPENDS = "glib-2.0 gnet"
+
+inherit autotools pkgconfig
diff --git a/recipes/gsnmp/gsnmp_svn.bb b/recipes/gsnmp/gsnmp_svn.bb
new file mode 100644
index 0000000..ed27bb6
--- /dev/null
+++ b/recipes/gsnmp/gsnmp_svn.bb
@@ -0,0 +1,8 @@
+require gsnmp.inc
+
+SRCREV = "3372"
+PV = "0.3.0+svnr${SRCREV}"
+PR = "r1"
+
+SRC_URI = "svn://cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp;module=trunk;proto=https"
+S = "${WORKDIR}/trunk"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 2/2] recipe for scli-0.4.0
  2010-08-04 10:43 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Henri Bragge
@ 2010-08-04 10:43   ` Henri Bragge
  2010-08-04 11:54     ` Frans Meulenbroeks
  2010-08-04 11:51   ` [PATCH 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
  1 sibling, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 10:43 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/scli/scli.inc    |    6 ++++++
 recipes/scli/scli_svn.bb |    8 ++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 recipes/scli/scli.inc
 create mode 100644 recipes/scli/scli_svn.bb

diff --git a/recipes/scli/scli.inc b/recipes/scli/scli.inc
new file mode 100644
index 0000000..abe341d
--- /dev/null
+++ b/recipes/scli/scli.inc
@@ -0,0 +1,6 @@
+DESCRIPTION = "SNMP Command Line Interface"
+LICENSE = "GPLv2"
+SECTION = "console/network"
+DEPENDS = "gsnmp readline libxml2 ncurses"
+
+inherit autotools
diff --git a/recipes/scli/scli_svn.bb b/recipes/scli/scli_svn.bb
new file mode 100644
index 0000000..45bd08e
--- /dev/null
+++ b/recipes/scli/scli_svn.bb
@@ -0,0 +1,8 @@
+require scli.inc
+
+SRCREV = "3285"
+PV = "0.4.0+svnr${SRCREV}"
+PR = "r1"
+
+SRC_URI = "svn://cnds.eecs.jacobs-university.de/svn/schoenw/src/scli;module=trunk;proto=https"
+S = "${WORKDIR}/trunk"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/2] recipe for gsnmp-0.3.0
  2010-08-04 10:43 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2010-08-04 10:43   ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
@ 2010-08-04 11:51   ` Frans Meulenbroeks
  1 sibling, 0 replies; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-04 11:51 UTC (permalink / raw)
  To: openembedded-devel

2010/8/4 Henri Bragge <henri.bragge@dcombus.com>

> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
> ---
>  recipes/gsnmp/gsnmp.inc    |    6 ++++++
>  recipes/gsnmp/gsnmp_svn.bb |    8 ++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/gsnmp/gsnmp.inc
>  create mode 100644 recipes/gsnmp/gsnmp_svn.bb
>
> diff --git a/recipes/gsnmp/gsnmp.inc b/recipes/gsnmp/gsnmp.inc
> new file mode 100644
> index 0000000..66e88cc
> --- /dev/null
> +++ b/recipes/gsnmp/gsnmp.inc
> @@ -0,0 +1,6 @@
> +DESCRIPTION = "SNMP library written on top of glib and gnet."
> +LICENSE = "GPLv2"
> +SECTION = "libs/network"
> +DEPENDS = "glib-2.0 gnet"
> +
> +inherit autotools pkgconfig
> diff --git a/recipes/gsnmp/gsnmp_svn.bb b/recipes/gsnmp/gsnmp_svn.bb
> new file mode 100644
> index 0000000..ed27bb6
> --- /dev/null
> +++ b/recipes/gsnmp/gsnmp_svn.bb
> @@ -0,0 +1,8 @@
> +require gsnmp.inc
> +
> +SRCREV = "3372"
> +PV = "0.3.0+svnr${SRCREV}"
> +PR = "r1"
>

Why do you start with PR = r1?


> +
> +SRC_URI = "svn://
> cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp;module=trunk;proto=https
> "
>

Does it need to be https ?
If http is also supported, I would prefer http i.s.o. https


> +S = "${WORKDIR}/trunk"
> --
> 1.5.6.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 2/2] recipe for scli-0.4.0
  2010-08-04 10:43   ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
@ 2010-08-04 11:54     ` Frans Meulenbroeks
  2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
                         ` (2 more replies)
  0 siblings, 3 replies; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-04 11:54 UTC (permalink / raw)
  To: openembedded-devel

2010/8/4 Henri Bragge <henri.bragge@dcombus.com>

> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
> ---
>  recipes/scli/scli.inc    |    6 ++++++
>  recipes/scli/scli_svn.bb |    8 ++++++++
>  2 files changed, 14 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/scli/scli.inc
>  create mode 100644 recipes/scli/scli_svn.bb
>
> diff --git a/recipes/scli/scli.inc b/recipes/scli/scli.inc
> new file mode 100644
> index 0000000..abe341d
> --- /dev/null
> +++ b/recipes/scli/scli.inc
> @@ -0,0 +1,6 @@
> +DESCRIPTION = "SNMP Command Line Interface"
> +LICENSE = "GPLv2"
> +SECTION = "console/network"
> +DEPENDS = "gsnmp readline libxml2 ncurses"
> +
> +inherit autotools
> diff --git a/recipes/scli/scli_svn.bb b/recipes/scli/scli_svn.bb
> new file mode 100644
> index 0000000..45bd08e
> --- /dev/null
> +++ b/recipes/scli/scli_svn.bb
> @@ -0,0 +1,8 @@
> +require scli.inc
> +
> +SRCREV = "3285"
> +PV = "0.4.0+svnr${SRCREV}"
> +PR = "r1"
>
+
> +SRC_URI = "svn://
> cnds.eecs.jacobs-university.de/svn/schoenw/src/scli;module=trunk;proto=https
> "
> +S = "${WORKDIR}/trunk"
>

Same remarks as for the other one.
Also, do we need the .inc file. If I look at the content it is hardly worth
putting it in a separate file.

Then again *if* you insist on an inc file you should also have an INC_PR.

This also holds for the other recipe.

Frans

> --
> 1.5.6.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-04 11:54     ` Frans Meulenbroeks
@ 2010-08-04 12:48       ` Henri Bragge
  2010-08-04 12:48         ` [PATCH v2 2/2] recipe for scli-0.4.0 Henri Bragge
  2010-08-04 17:43         ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
  2010-08-04 12:54       ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
  2010-08-05  8:44       ` [PATCH v3 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2 siblings, 2 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 12:48 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp_svn.bb |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp_svn.bb

diff --git a/recipes/gsnmp/gsnmp_svn.bb b/recipes/gsnmp/gsnmp_svn.bb
new file mode 100644
index 0000000..3a2ac09
--- /dev/null
+++ b/recipes/gsnmp/gsnmp_svn.bb
@@ -0,0 +1,12 @@
+DESCRIPTION = "SNMP library written on top of glib and gnet."
+SECTION = "libs/network"
+LICENSE = "GPLv2"
+DEPENDS = "glib-2.0 gnet"
+SRCREV = "3372"
+PV = "0.3.0+svnr${SRCREV}"
+PR = "r0"
+
+inherit autotools pkgconfig
+
+SRC_URI = "svn://cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp;module=trunk;proto=https"
+S = "${WORKDIR}/trunk"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH v2 2/2] recipe for scli-0.4.0
  2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
@ 2010-08-04 12:48         ` Henri Bragge
  2010-08-04 17:43         ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
  1 sibling, 0 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 12:48 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/scli/scli_svn.bb |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 recipes/scli/scli_svn.bb

diff --git a/recipes/scli/scli_svn.bb b/recipes/scli/scli_svn.bb
new file mode 100644
index 0000000..589879b
--- /dev/null
+++ b/recipes/scli/scli_svn.bb
@@ -0,0 +1,12 @@
+DESCRIPTION = "SNMP Command Line Interface"
+SECTION = "console/network"
+LICENSE = "GPLv2"
+DEPENDS = "gsnmp readline libxml2 ncurses"
+SRCREV = "3285"
+PV = "0.4.0+svnr${SRCREV}"
+PR = "r0"
+
+inherit autotools
+
+SRC_URI = "svn://cnds.eecs.jacobs-university.de/svn/schoenw/src/scli;module=trunk;proto=https"
+S = "${WORKDIR}/trunk"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH 2/2] recipe for scli-0.4.0
  2010-08-04 11:54     ` Frans Meulenbroeks
  2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
@ 2010-08-04 12:54       ` Henri Bragge
  2010-08-05  8:44       ` [PATCH v3 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2 siblings, 0 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-04 12:54 UTC (permalink / raw)
  To: openembedded-devel

Frans Meulenbroeks wrote:
> 2010/8/4 Henri Bragge <henri.bragge@dcombus.com>
>
>   
>> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
>> ---
>>  recipes/scli/scli.inc    |    6 ++++++
>>  recipes/scli/scli_svn.bb |    8 ++++++++
>>  2 files changed, 14 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/scli/scli.inc
>>  create mode 100644 recipes/scli/scli_svn.bb
>>
>> diff --git a/recipes/scli/scli.inc b/recipes/scli/scli.inc
>> new file mode 100644
>> index 0000000..abe341d
>> --- /dev/null
>> +++ b/recipes/scli/scli.inc
>> @@ -0,0 +1,6 @@
>> +DESCRIPTION = "SNMP Command Line Interface"
>> +LICENSE = "GPLv2"
>> +SECTION = "console/network"
>> +DEPENDS = "gsnmp readline libxml2 ncurses"
>> +
>> +inherit autotools
>> diff --git a/recipes/scli/scli_svn.bb b/recipes/scli/scli_svn.bb
>> new file mode 100644
>> index 0000000..45bd08e
>> --- /dev/null
>> +++ b/recipes/scli/scli_svn.bb
>> @@ -0,0 +1,8 @@
>> +require scli.inc
>> +
>> +SRCREV = "3285"
>> +PV = "0.4.0+svnr${SRCREV}"
>> +PR = "r1"
>>
>>     
> +
>   
>> +SRC_URI = "svn://
>> cnds.eecs.jacobs-university.de/svn/schoenw/src/scli;module=trunk;proto=https
>> "
>> +S = "${WORKDIR}/trunk"
>>
>>     
>
> Same remarks as for the other one.
> Also, do we need the .inc file. If I look at the content it is hardly worth
> putting it in a separate file.
>
> Then again *if* you insist on an inc file you should also have an INC_PR.
>
> This also holds for the other recipe.
>   

Thanks for the comments, sent v2 of the patches.

Just thought .inc would be a good idea to separate generic stuff from 
svn-specific, but indeed there's very little of the generic part to 
justify its own file. Fixed the PRs also.

Btw, only https seems to be available.

- Henri



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2010-08-04 12:48         ` [PATCH v2 2/2] recipe for scli-0.4.0 Henri Bragge
@ 2010-08-04 17:43         ` Frans Meulenbroeks
  2010-08-05  8:53           ` Henri Bragge
  1 sibling, 1 reply; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-04 17:43 UTC (permalink / raw)
  To: openembedded-devel

2010/8/4 Henri Bragge <henri.bragge@dcombus.com>

> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
> ---
>  recipes/gsnmp/gsnmp_svn.bb |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/gsnmp/gsnmp_svn.bb
>
> diff --git a/recipes/gsnmp/gsnmp_svn.bb b/recipes/gsnmp/gsnmp_svn.bb
> new file mode 100644
> index 0000000..3a2ac09
> --- /dev/null
> +++ b/recipes/gsnmp/gsnmp_svn.bb
> @@ -0,0 +1,12 @@
> +DESCRIPTION = "SNMP library written on top of glib and gnet."
> +SECTION = "libs/network"
> +LICENSE = "GPLv2"
> +DEPENDS = "glib-2.0 gnet"
> +SRCREV = "3372"
> +PV = "0.3.0+svnr${SRCREV}"
> +PR = "r0"
> +
> +inherit autotools pkgconfig
> +
> +SRC_URI = "svn://
> cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp;module=trunk;proto=https
> "
> +S = "${WORKDIR}/trunk"


tried to build this, stranded at this:

NOTE: Fetch svn://
cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp;module=trunk;proto=https
Error validating server certificate for '
https://cnds.eecs.jacobs-university.de:443':
 - The certificate is not issued by a trusted authority. Use the
   fingerprint to validate the certificate manually!
Certificate information:
 - Hostname: cnds.eecs.jacobs-university.de
 - Valid: from Tue, 22 Sep 2009 08:07:16 GMT until Sun, 21 Sep 2014 08:07:16
GMT
 - Issuer: IRC-IT, Jacobs University Bremen gGmbH, DE
 - Fingerprint: a3:ed:4f:1d:a7:3b:dc:99:aa:0f:cb:d7:d3:19:f5:b0:ef:1c:06:00
(R)eject, accept (t)emporarily or accept (p)ermanently? svn: OPTIONS of '
https://cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp/trunk': Server
certificate verification failed: issuer is not trusted (
https://cnds.eecs.jacobs-university.de)
NOTE: Task failed: Fetch failed: Fetch command export HOME=/home/frans;
export SSH_AUTH_SOCK=/tmp/ssh-iwZKs1963/agent.1963; export
PATH=/home/frans/oe/tmp_angstrom/sysroots/i686-linux/usr/armv7a/bin:/home/frans/oe/tmp_angstrom/sysroots/i686-linux/usr/sbin:/home/frans/oe/tmp_angstrom/sysroots/i686-linux/usr/bin:/home/frans/oe/tmp_angstrom/sysroots/i686-linux/sbin:/home/frans/oe/tmp_angstrom/sysroots/i686-linux//bin:/home/frans/oe/bitbake/bin:/home/frans/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/opt/kde3/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin:/opt/gnome/bin:/usr/lib/qt3/bin:/home/frans/bin:.;
/usr/bin/env svn co -r 3372
https://cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp/trunk@3372trunk
failed with signal 1, output:
Error validating server certificate for '
https://cnds.eecs.jacobs-university.de:443':
 - The certificate is not issued by a trusted authority. Use the
   fingerprint to validate the certificate manually!
Certificate information:
 - Hostname: cnds.eecs.jacobs-university.de
 - Valid: from Tue, 22 Sep 2009 08:07:16 GMT until Sun, 21 Sep 2014 08:07:16
GMT
 - Issuer: IRC-IT, Jacobs University Bremen gGmbH, DE
 - Fingerprint: a3:ed:4f:1d:a7:3b:dc:99:aa:0f:cb:d7:d3:19:f5:b0:ef:1c:06:00
(R)eject, accept (t)emporarily or accept (p)ermanently? svn: OPTIONS of '
https://cnds.eecs.jacobs-university.de/svn/schoenw/src/gsnmp/trunk': Server
certificate verification failed: issuer is not trusted (
https://cnds.eecs.jacobs-university.de)

NOTE: oestats: task failed, see
http://tinderbox.openembedded.net/packages/668019/
ERROR: TaskFailed event exception, aborting


No idea what the policy on this is, but I'm not too eager to add all kind of
certificates to my system

Frans


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v3 1/2] recipe for gsnmp-0.3.0
  2010-08-04 11:54     ` Frans Meulenbroeks
  2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2010-08-04 12:54       ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
@ 2010-08-05  8:44       ` Henri Bragge
  2010-08-05  8:44         ` [PATCH v3 2/2] recipe for scli-0.4.0 Henri Bragge
  2 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-05  8:44 UTC (permalink / raw)
  To: openembedded-devel


Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp_0.3.0.bb |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp_0.3.0.bb

diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
new file mode 100644
index 0000000..b191762
--- /dev/null
+++ b/recipes/gsnmp/gsnmp_0.3.0.bb
@@ -0,0 +1,12 @@
+DESCRIPTION = "SNMP library written on top of glib and gnet."
+SECTION = "libs/network"
+LICENSE = "GPLv2"
+DEPENDS = "glib-2.0 gnet"
+PR = "r0"
+
+SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "466699c11b70e18a04d51388b8f89f1c"
+SRC_URI[sha256sum] = "e428b61071b8ba2971fc8737ed2987210b04a71ffde307900df12c06a0bed0f9"
+
+inherit autotools pkgconfig
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH v3 2/2] recipe for scli-0.4.0
  2010-08-05  8:44       ` [PATCH v3 1/2] recipe for gsnmp-0.3.0 Henri Bragge
@ 2010-08-05  8:44         ` Henri Bragge
  2010-08-05 18:47           ` Frans Meulenbroeks
  0 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-05  8:44 UTC (permalink / raw)
  To: openembedded-devel


Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/scli/scli_0.4.0.bb |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 recipes/scli/scli_0.4.0.bb

diff --git a/recipes/scli/scli_0.4.0.bb b/recipes/scli/scli_0.4.0.bb
new file mode 100644
index 0000000..3d24910
--- /dev/null
+++ b/recipes/scli/scli_0.4.0.bb
@@ -0,0 +1,12 @@
+DESCRIPTION = "SNMP Command Line Interface"
+SECTION = "console/network"
+LICENSE = "GPLv2"
+DEPENDS = "gsnmp readline libxml2 ncurses"
+PR = "r0"
+
+SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/pub/local/scli/scli-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "486c92c76059a35c87e88edf24cbf804"
+SRC_URI[sha256sum] = "308511589260d3da9bc5817ace363180070ac83ccba9231b7b9a01e1b0c29fe1"
+
+inherit autotools
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-04 17:43         ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
@ 2010-08-05  8:53           ` Henri Bragge
  2010-08-05 10:05             ` Frans Meulenbroeks
  0 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-05  8:53 UTC (permalink / raw)
  To: openembedded-devel

Frans Meulenbroeks <fransmeulenbroeks <at> gmail.com> writes:

> 
> tried to build this, stranded at this:
> 
> ...
> 
> NOTE: oestats: task failed, see
> http://tinderbox.openembedded.net/packages/668019/
> ERROR: TaskFailed event exception, aborting
> 
> No idea what the policy on this is, but I'm not too eager to add all kind of
> certificates to my system
> 

Posted v3, this time with ftp sources. Had forgotten that Deutsche Telekom
(which that certificate is rooted to) was an untrusted authority.

Sorry the hassle, this is my first patch to oe.

- Henri




^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-05  8:53           ` Henri Bragge
@ 2010-08-05 10:05             ` Frans Meulenbroeks
  2010-08-05 18:49               ` Frans Meulenbroeks
  0 siblings, 1 reply; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-05 10:05 UTC (permalink / raw)
  To: openembedded-devel

2010/8/5 Henri Bragge <henri.bragge@dcombus.com>:
> Frans Meulenbroeks <fransmeulenbroeks <at> gmail.com> writes:
>
>>
>> tried to build this, stranded at this:
>>
>> ...
>>
>> NOTE: oestats: task failed, see
>> http://tinderbox.openembedded.net/packages/668019/
>> ERROR: TaskFailed event exception, aborting
>>
>> No idea what the policy on this is, but I'm not too eager to add all kind of
>> certificates to my system
>>
>
> Posted v3, this time with ftp sources. Had forgotten that Deutsche Telekom
> (which that certificate is rooted to) was an untrusted authority.
>
> Sorry the hassle, this is my first patch to oe.

It is no problem, ftp is definitely better than svn/https (at least in
my opinion).
And wrt the hassle: we all had to go through the learning curve at one
point in time.

Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v3 2/2] recipe for scli-0.4.0
  2010-08-05  8:44         ` [PATCH v3 2/2] recipe for scli-0.4.0 Henri Bragge
@ 2010-08-05 18:47           ` Frans Meulenbroeks
  0 siblings, 0 replies; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-05 18:47 UTC (permalink / raw)
  To: openembedded-devel

2010/8/5 Henri Bragge <henri.bragge@dcombus.com>:
>
> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
> ---
>  recipes/scli/scli_0.4.0.bb |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/scli/scli_0.4.0.bb
>
> diff --git a/recipes/scli/scli_0.4.0.bb b/recipes/scli/scli_0.4.0.bb
> new file mode 100644
> index 0000000..3d24910
> --- /dev/null
> +++ b/recipes/scli/scli_0.4.0.bb
> @@ -0,0 +1,12 @@
> +DESCRIPTION = "SNMP Command Line Interface"
> +SECTION = "console/network"
> +LICENSE = "GPLv2"
> +DEPENDS = "gsnmp readline libxml2 ncurses"
> +PR = "r0"
> +
> +SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/pub/local/scli/scli-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "486c92c76059a35c87e88edf24cbf804"
> +SRC_URI[sha256sum] = "308511589260d3da9bc5817ace363180070ac83ccba9231b7b9a01e1b0c29fe1"
> +
> +inherit autotools
> --
>
Tried it. Fetch is ok now, but when building I get a QA issue causing
the build to fail (angstrom/beagleboard):

OTE: Running task 665 of 669 (ID: 16,
/home/frans/oe/openembedded/recipes/scli/scli_0.4.0.bb,
do_package_write_ipk)
ERROR: QA Issue with staging: libexslt.pc failed sanity test (tmpdir)
in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
ERROR: QA Issue with staging: libxslt.pc failed sanity test (tmpdir)
in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
ERROR: QA staging was broken by the package built above

see http://tinderbox.openembedded.net/builds/81310/


Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-05 10:05             ` Frans Meulenbroeks
@ 2010-08-05 18:49               ` Frans Meulenbroeks
  2010-08-06  9:32                 ` Frans Meulenbroeks
  0 siblings, 1 reply; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-05 18:49 UTC (permalink / raw)
  To: openembedded-devel

This one also failed building with a similar QA issue:

NOTE: Running task 629 of 630 (ID: 10,
/home/frans/oe/openembedded/recipes/gsnmp/gsnmp_0.3.0.bb,
do_qa_staging)
ERROR: QA Issue with staging: libexslt.pc failed sanity test (tmpdir)
in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
ERROR: QA Issue with staging: libxslt.pc failed sanity test (tmpdir)
in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
ERROR: QA staging was broken by the package built above


see http://tinderbox.openembedded.net/builds/81312

No idea how exactly to fix this.

Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-05 18:49               ` Frans Meulenbroeks
@ 2010-08-06  9:32                 ` Frans Meulenbroeks
  2010-08-06 10:05                   ` Henri Bragge
  0 siblings, 1 reply; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-06  9:32 UTC (permalink / raw)
  To: openembedded-devel

2010/8/5 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>:
> This one also failed building with a similar QA issue:
>
> NOTE: Running task 629 of 630 (ID: 10,
> /home/frans/oe/openembedded/recipes/gsnmp/gsnmp_0.3.0.bb,
> do_qa_staging)
> ERROR: QA Issue with staging: libexslt.pc failed sanity test (tmpdir)
> in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
> ERROR: QA Issue with staging: libxslt.pc failed sanity test (tmpdir)
> in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
> ERROR: QA staging was broken by the package built above
>
>
> see http://tinderbox.openembedded.net/builds/81312
>
> No idea how exactly to fix this.
>
> Frans
>
Please disregard ths comment and the one on the other recipe.
Apparently some other recipe (libxslt) left a faulty pc file in pkgconfig.
That is something that needs to be repaired (although I woudl not know
how), but does not affect your recipe.

Your recipes have been tested, build nicely and have been pushed.
Thank you for your contribution, and again apologies for any
inconvenience caused by the above mail)

Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-06  9:32                 ` Frans Meulenbroeks
@ 2010-08-06 10:05                   ` Henri Bragge
  2010-08-06 14:08                     ` Frans Meulenbroeks
  0 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-06 10:05 UTC (permalink / raw)
  To: openembedded-devel

Frans Meulenbroeks wrote:
> 2010/8/5 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>:
>   
>> This one also failed building with a similar QA issue:
>>
>> NOTE: Running task 629 of 630 (ID: 10,
>> /home/frans/oe/openembedded/recipes/gsnmp/gsnmp_0.3.0.bb,
>> do_qa_staging)
>> ERROR: QA Issue with staging: libexslt.pc failed sanity test (tmpdir)
>> in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
>> ERROR: QA Issue with staging: libxslt.pc failed sanity test (tmpdir)
>> in path /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
>> ERROR: QA staging was broken by the package built above
>>
>>
>> see http://tinderbox.openembedded.net/builds/81312
>>
>> No idea how exactly to fix this.
>>
>> Frans
>>
>>     
> Please disregard ths comment and the one on the other recipe.
> Apparently some other recipe (libxslt) left a faulty pc file in pkgconfig.
> That is something that needs to be repaired (although I woudl not know
> how), but does not affect your recipe.
>
> Your recipes have been tested, build nicely and have been pushed.
> Thank you for your contribution, and again apologies for any
> inconvenience caused by the above mail)
>   

No harm done, I suspected it was someone else's fault this time. Thanks 
for testing & comments.

- Henri



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-06 10:05                   ` Henri Bragge
@ 2010-08-06 14:08                     ` Frans Meulenbroeks
  2010-08-09 11:36                       ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
                                         ` (2 more replies)
  0 siblings, 3 replies; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-06 14:08 UTC (permalink / raw)
  To: openembedded-devel

Still one issue left:

I saw this warning when building another package:

/home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
warning: underquoted definition of AM_PATH_GSNMP
/home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
  run info '(automake)Extending aclocal'
/home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
  or see http://sources.redhat.com/automake/automake.html#Extending-aclocal

I suggest a patch to resolve this.

Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-06 14:08                     ` Frans Meulenbroeks
@ 2010-08-09 11:36                       ` Henri Bragge
  2010-08-09 11:52                         ` Paul Menzel
  2010-08-09 11:43                       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
  2010-08-09 12:20                       ` [PATCH v2 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
  2 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 11:36 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   24 ++++++++++++++++++++++++
 recipes/gsnmp/gsnmp_0.3.0.bb              |    3 ++-
 2 files changed, 26 insertions(+), 1 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch

diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
new file mode 100644
index 0000000..138c9e6
--- /dev/null
+++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
@@ -0,0 +1,24 @@
+diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
+--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
+@@ -6,7 +6,7 @@
+ dnl usually in <utime.h>.
+ dnl Some systems have utime.h but don't declare the struct anywhere.
+ 
+-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
+ [
+   AC_CHECK_HEADERS(utime.h)
+   AC_REQUIRE([AC_HEADER_TIME])
+diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
+--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
+@@ -1,7 +1,7 @@
+ dnl AM_PATH_GSNMP()
+ dnl 
+ 
+-AC_DEFUN(AM_PATH_GSNMP,
++AC_DEFUN([AM_PATH_GSNMP],
+ [
+   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
+ ])
diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
index b191762..6287010 100644
--- a/recipes/gsnmp/gsnmp_0.3.0.bb
+++ b/recipes/gsnmp/gsnmp_0.3.0.bb
@@ -4,7 +4,8 @@ LICENSE = "GPLv2"
 DEPENDS = "glib-2.0 gnet"
 PR = "r0"
 
-SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz"
+SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz \
+	   file://quote-fix.patch"
 
 SRC_URI[md5sum] = "466699c11b70e18a04d51388b8f89f1c"
 SRC_URI[sha256sum] = "e428b61071b8ba2971fc8737ed2987210b04a71ffde307900df12c06a0bed0f9"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH v2 1/2] recipe for gsnmp-0.3.0
  2010-08-06 14:08                     ` Frans Meulenbroeks
  2010-08-09 11:36                       ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
@ 2010-08-09 11:43                       ` Henri Bragge
  2010-08-09 12:20                       ` [PATCH v2 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
  2 siblings, 0 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 11:43 UTC (permalink / raw)
  To: openembedded-devel

Frans Meulenbroeks wrote:
> Still one issue left:
>
> I saw this warning when building another package:
>
> /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
> warning: underquoted definition of AM_PATH_GSNMP
> /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
>   run info '(automake)Extending aclocal'
> /home/frans/oe/tmp_angstrom/sysroots/armv7a-angstrom-linux-gnueabi/usr/share/aclocal/gsnmp.m4:4:
>   or see http://sources.redhat.com/automake/automake.html#Extending-aclocal
>
> I suggest a patch to resolve this.
>   

Posted a patch that should fix this. Couldn't really reproduce the 
problem but I hope it helps..

- Henri



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 11:36                       ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
@ 2010-08-09 11:52                         ` Paul Menzel
  2010-08-09 12:05                           ` Henri Bragge
  0 siblings, 1 reply; 27+ messages in thread
From: Paul Menzel @ 2010-08-09 11:52 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2040 bytes --]

Is there an upstream bug for this? If not, it would be great if you
could sent it upstream.

Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:
> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
> ---
>  recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   24 ++++++++++++++++++++++++
>  recipes/gsnmp/gsnmp_0.3.0.bb              |    3 ++-
>  2 files changed, 26 insertions(+), 1 deletions(-)
>  create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> 
> diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> new file mode 100644
> index 0000000..138c9e6
> --- /dev/null
> +++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
> @@ -0,0 +1,24 @@
> +diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
> +--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
> ++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
> +@@ -6,7 +6,7 @@
> + dnl usually in <utime.h>.
> + dnl Some systems have utime.h but don't declare the struct anywhere.
> + 
> +-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
> ++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
> + [
> +   AC_CHECK_HEADERS(utime.h)
> +   AC_REQUIRE([AC_HEADER_TIME])
> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
> +--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
> ++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
> +@@ -1,7 +1,7 @@
> + dnl AM_PATH_GSNMP()
> + dnl 
> + 
> +-AC_DEFUN(AM_PATH_GSNMP,
> ++AC_DEFUN([AM_PATH_GSNMP],
> + [
> +   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
> + ])

Why is this check needed? Maybe add a note to the commit message or
split the patch.

> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
> index b191762..6287010 100644
> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
>  DEPENDS = "glib-2.0 gnet"
>  PR = "r0"

I guess you need to increase `PR`.

[…]


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 11:52                         ` Paul Menzel
@ 2010-08-09 12:05                           ` Henri Bragge
  2010-08-09 12:36                             ` Paul Menzel
  0 siblings, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 12:05 UTC (permalink / raw)
  To: openembedded-devel

Paul Menzel wrote:
> Is there an upstream bug for this? If not, it would be great if you
> could sent it upstream.
>   

The bug is still present in upstream too, but I will send this patch to 
the gsnmp maintainer if it does the trick (or should it be the other way 
around?).

> Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:
>   
>> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
>> ---
>>  recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   24 ++++++++++++++++++++++++
>>  recipes/gsnmp/gsnmp_0.3.0.bb              |    3 ++-
>>  2 files changed, 26 insertions(+), 1 deletions(-)
>>  create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>>
>> diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>> new file mode 100644
>> index 0000000..138c9e6
>> --- /dev/null
>> +++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>> @@ -0,0 +1,24 @@
>> +diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
>> +--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
>> ++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
>> +@@ -6,7 +6,7 @@
>> + dnl usually in <utime.h>.
>> + dnl Some systems have utime.h but don't declare the struct anywhere.
>> + 
>> +-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
>> ++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
>> + [
>> +   AC_CHECK_HEADERS(utime.h)
>> +   AC_REQUIRE([AC_HEADER_TIME])
>> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
>> +--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
>> ++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
>> +@@ -1,7 +1,7 @@
>> + dnl AM_PATH_GSNMP()
>> + dnl 
>> + 
>> +-AC_DEFUN(AM_PATH_GSNMP,
>> ++AC_DEFUN([AM_PATH_GSNMP],
>> + [
>> +   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
>> + ])
>>     
>
> Why is this check needed? Maybe add a note to the commit message or
> split the patch.
>   

About that I've no idea, notice that I just added the brackets there.

>   
>> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
>> index b191762..6287010 100644
>> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
>> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
>> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
>>  DEPENDS = "glib-2.0 gnet"
>>  PR = "r0"
>>     
>
> I guess you need to increase `PR`.
>
> […]
>   

Will do.

- Henri



^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v2 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-06 14:08                     ` Frans Meulenbroeks
  2010-08-09 11:36                       ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
  2010-08-09 11:43                       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
@ 2010-08-09 12:20                       ` Henri Bragge
  2 siblings, 0 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 12:20 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   24 ++++++++++++++++++++++++
 recipes/gsnmp/gsnmp_0.3.0.bb              |    5 +++--
 2 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch

diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
new file mode 100644
index 0000000..138c9e6
--- /dev/null
+++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
@@ -0,0 +1,24 @@
+diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
+--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
+@@ -6,7 +6,7 @@
+ dnl usually in <utime.h>.
+ dnl Some systems have utime.h but don't declare the struct anywhere.
+ 
+-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
+ [
+   AC_CHECK_HEADERS(utime.h)
+   AC_REQUIRE([AC_HEADER_TIME])
+diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
+--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
+@@ -1,7 +1,7 @@
+ dnl AM_PATH_GSNMP()
+ dnl 
+ 
+-AC_DEFUN(AM_PATH_GSNMP,
++AC_DEFUN([AM_PATH_GSNMP],
+ [
+   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
+ ])
diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
index b191762..e27e3e9 100644
--- a/recipes/gsnmp/gsnmp_0.3.0.bb
+++ b/recipes/gsnmp/gsnmp_0.3.0.bb
@@ -2,9 +2,10 @@ DESCRIPTION = "SNMP library written on top of glib and gnet."
 SECTION = "libs/network"
 LICENSE = "GPLv2"
 DEPENDS = "glib-2.0 gnet"
-PR = "r0"
+PR = "r1"
 
-SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz"
+SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz \
+	   file://quote-fix.patch"
 
 SRC_URI[md5sum] = "466699c11b70e18a04d51388b8f89f1c"
 SRC_URI[sha256sum] = "e428b61071b8ba2971fc8737ed2987210b04a71ffde307900df12c06a0bed0f9"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 12:05                           ` Henri Bragge
@ 2010-08-09 12:36                             ` Paul Menzel
  2010-08-09 15:31                               ` [PATCH v3 " Henri Bragge
  2010-08-09 15:43                               ` [PATCH " Henri Bragge
  0 siblings, 2 replies; 27+ messages in thread
From: Paul Menzel @ 2010-08-09 12:36 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

Am Montag, den 09.08.2010, 15:05 +0300 schrieb Henri Bragge:
> Paul Menzel wrote:
> > Is there an upstream bug for this? If not, it would be great if you
> > could sent it upstream.
> 
> The bug is still present in upstream too, but I will send this patch to 
> the gsnmp maintainer if it does the trick (or should it be the other way 
> around?).

I have no idea [1]. But I guess it would not hurt if you send it
upstream anyway.

[1] http://wiki.openembedded.net/index.php/Push_patches_upstream

> > Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:

[…]

> >> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
> >> +--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
> >> ++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
> >> +@@ -1,7 +1,7 @@
> >> + dnl AM_PATH_GSNMP()
> >> + dnl 
> >> + 
> >> +-AC_DEFUN(AM_PATH_GSNMP,
> >> ++AC_DEFUN([AM_PATH_GSNMP],
> >> + [
> >> +   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
> >> + ])
> >
> > Why is this check needed? Maybe add a note to the commit message or
> > split the patch.
> 
> About that I've no idea, notice that I just added the brackets there.

Sorry, the double patch got me confused.

> >> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
> >> index b191762..6287010 100644
> >> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
> >> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
> >> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
> >>  DEPENDS = "glib-2.0 gnet"
> >>  PR = "r0"
> >>     
> >
> > I guess you need to increase `PR`.
> >
> > […]
> 
> Will do.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH v3 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 12:36                             ` Paul Menzel
@ 2010-08-09 15:31                               ` Henri Bragge
  2010-08-09 15:43                               ` [PATCH " Henri Bragge
  1 sibling, 0 replies; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 15:31 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
---
 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch |   28 ++++++++++++++++++++++++++++
 recipes/gsnmp/gsnmp_0.3.0.bb              |    5 +++--
 2 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch

diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
new file mode 100644
index 0000000..6cb2e0d
--- /dev/null
+++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
@@ -0,0 +1,28 @@
+upstream: n/a
+status: accepted in r3406
+comment: Fix underquoted macro definitions.
+
+diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
+--- gsnmp-0.3.0.orig/acinclude.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/acinclude.m4	2010-08-09 13:30:32.000000000 +0300
+@@ -6,7 +6,7 @@
+ dnl usually in <utime.h>.
+ dnl Some systems have utime.h but don't declare the struct anywhere.
+ 
+-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
+ [
+   AC_CHECK_HEADERS(utime.h)
+   AC_REQUIRE([AC_HEADER_TIME])
+diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
+--- gsnmp-0.3.0.orig/gsnmp.m4	2010-02-19 10:35:29.000000000 +0200
++++ gsnmp-0.3.0/gsnmp.m4	2010-08-09 13:30:46.000000000 +0300
+@@ -1,7 +1,7 @@
+ dnl AM_PATH_GSNMP()
+ dnl 
+ 
+-AC_DEFUN(AM_PATH_GSNMP,
++AC_DEFUN([AM_PATH_GSNMP],
+ [
+   PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
+ ])
diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
index b191762..e27e3e9 100644
--- a/recipes/gsnmp/gsnmp_0.3.0.bb
+++ b/recipes/gsnmp/gsnmp_0.3.0.bb
@@ -2,9 +2,10 @@ DESCRIPTION = "SNMP library written on top of glib and gnet."
 SECTION = "libs/network"
 LICENSE = "GPLv2"
 DEPENDS = "glib-2.0 gnet"
-PR = "r0"
+PR = "r1"
 
-SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz"
+SRC_URI = "ftp://ftp.ibr.cs.tu-bs.de/local/gsnmp/gsnmp-${PV}.tar.gz \
+	   file://quote-fix.patch"
 
 SRC_URI[md5sum] = "466699c11b70e18a04d51388b8f89f1c"
 SRC_URI[sha256sum] = "e428b61071b8ba2971fc8737ed2987210b04a71ffde307900df12c06a0bed0f9"
-- 
1.5.6.5




^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 12:36                             ` Paul Menzel
  2010-08-09 15:31                               ` [PATCH v3 " Henri Bragge
@ 2010-08-09 15:43                               ` Henri Bragge
  2010-08-09 19:16                                 ` Frans Meulenbroeks
  1 sibling, 1 reply; 27+ messages in thread
From: Henri Bragge @ 2010-08-09 15:43 UTC (permalink / raw)
  To: openembedded-devel

Paul Menzel wrote:
> Am Montag, den 09.08.2010, 15:05 +0300 schrieb Henri Bragge:
>   
>> Paul Menzel wrote:
>>     
>>> Is there an upstream bug for this? If not, it would be great if you
>>> could sent it upstream.
>>>       
>> The bug is still present in upstream too, but I will send this patch to 
>> the gsnmp maintainer if it does the trick (or should it be the other way 
>> around?).
>>     
>
> I have no idea [1]. But I guess it would not hurt if you send it
> upstream anyway.
>
> [1] http://wiki.openembedded.net/index.php/Push_patches_upstream
>   

Got it accepted, included some upstream info in the patch (see v3).

- Henri



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
  2010-08-09 15:43                               ` [PATCH " Henri Bragge
@ 2010-08-09 19:16                                 ` Frans Meulenbroeks
  0 siblings, 0 replies; 27+ messages in thread
From: Frans Meulenbroeks @ 2010-08-09 19:16 UTC (permalink / raw)
  To: openembedded-devel

2010/8/9 Henri Bragge <henri.bragge@dcombus.com>:

>
> Got it accepted, included some upstream info in the patch (see v3).
>
> - Henri


Pushed your patch. Thanks for contributing.
One small remark: I had to fix 3 whitespace errors.
Perhaps next time run contrib/oe-stylize.py
Looking forward for your next contribution

Have fun! Frans



^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2010-08-09 19:16 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-04 10:43 recipes for gsnmp and scli Henri Bragge
2010-08-04 10:43 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-04 10:43   ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-04 11:54     ` Frans Meulenbroeks
2010-08-04 12:48       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-04 12:48         ` [PATCH v2 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-04 17:43         ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
2010-08-05  8:53           ` Henri Bragge
2010-08-05 10:05             ` Frans Meulenbroeks
2010-08-05 18:49               ` Frans Meulenbroeks
2010-08-06  9:32                 ` Frans Meulenbroeks
2010-08-06 10:05                   ` Henri Bragge
2010-08-06 14:08                     ` Frans Meulenbroeks
2010-08-09 11:36                       ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
2010-08-09 11:52                         ` Paul Menzel
2010-08-09 12:05                           ` Henri Bragge
2010-08-09 12:36                             ` Paul Menzel
2010-08-09 15:31                               ` [PATCH v3 " Henri Bragge
2010-08-09 15:43                               ` [PATCH " Henri Bragge
2010-08-09 19:16                                 ` Frans Meulenbroeks
2010-08-09 11:43                       ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-09 12:20                       ` [PATCH v2 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
2010-08-04 12:54       ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-05  8:44       ` [PATCH v3 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-05  8:44         ` [PATCH v3 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-05 18:47           ` Frans Meulenbroeks
2010-08-04 11:51   ` [PATCH 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.