* [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
@ 2010-08-06 16:40 Anisse Astier
2010-08-06 17:06 ` Anisse Astier
2010-08-12 0:29 ` Lin Ming
0 siblings, 2 replies; 7+ messages in thread
From: Anisse Astier @ 2010-08-06 16:40 UTC (permalink / raw)
To: linux-acpi; +Cc: Anisse Astier, Len Brown, Lin Ming
This machine has a BIOS that corrupts the DSDT, and adding
acpi=copy_dsdt on cmdline fixes it. This feature and the corresponding
blacklist was added in commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
Cc: Len Brown <lenb@kernel.org>
Cc: Lin Ming <ming.m.lin@intel.com>
---
drivers/acpi/bus.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index c1d23cd..fe7d7b9 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
},
},
+ {
+ .callback = set_copy_dsdt,
+ .ident = "TOSHIBA Satellite C650D",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C650D"),
+ },
+ },
{}
};
#else
--
1.7.0.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-06 16:40 [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT Anisse Astier
@ 2010-08-06 17:06 ` Anisse Astier
2010-08-11 19:50 ` [stable] " Greg KH
2010-08-12 0:29 ` Lin Ming
1 sibling, 1 reply; 7+ messages in thread
From: Anisse Astier @ 2010-08-06 17:06 UTC (permalink / raw)
To: linux-acpi; +Cc: Len Brown, Lin Ming, stable
On Fri, 6 Aug 2010 18:40:18 +0200, Anisse Astier <anisse@astier.eu>
wrote :
> This machine has a BIOS that corrupts the DSDT, and adding
> acpi=copy_dsdt on cmdline fixes it. This feature and the corresponding
> blacklist was added in commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Lin Ming <ming.m.lin@intel.com>
> ---
> drivers/acpi/bus.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index c1d23cd..fe7d7b9 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> },
> },
> + {
> + .callback = set_copy_dsdt,
> + .ident = "TOSHIBA Satellite C650D",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C650D"),
> + },
> + },
> {}
> };
> #else
Other users experiencing problems as reference:
https://bugs.launchpad.net/ubuntu/+bug/612341
Also, I'm cc-ing stable as it might interest Greg for 35.1 (not earlier
versions since the feature was added by Lin Ming in .35).
Regards,
--
Anisse
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-06 17:06 ` Anisse Astier
@ 2010-08-11 19:50 ` Greg KH
2010-08-11 20:13 ` Anisse Astier
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2010-08-11 19:50 UTC (permalink / raw)
To: Anisse Astier; +Cc: linux-acpi, stable, Lin Ming, Len Brown
On Fri, Aug 06, 2010 at 07:06:18PM +0200, Anisse Astier wrote:
> On Fri, 6 Aug 2010 18:40:18 +0200, Anisse Astier <anisse@astier.eu>
> wrote :
>
> > This machine has a BIOS that corrupts the DSDT, and adding
> > acpi=copy_dsdt on cmdline fixes it. This feature and the corresponding
> > blacklist was added in commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
> >
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Lin Ming <ming.m.lin@intel.com>
> > ---
> > drivers/acpi/bus.c | 8 ++++++++
> > 1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> > index c1d23cd..fe7d7b9 100644
> > --- a/drivers/acpi/bus.c
> > +++ b/drivers/acpi/bus.c
> > @@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> > },
> > },
> > + {
> > + .callback = set_copy_dsdt,
> > + .ident = "TOSHIBA Satellite C650D",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C650D"),
> > + },
> > + },
> > {}
> > };
> > #else
>
> Other users experiencing problems as reference:
> https://bugs.launchpad.net/ubuntu/+bug/612341
>
> Also, I'm cc-ing stable as it might interest Greg for 35.1 (not earlier
> versions since the feature was added by Lin Ming in .35).
What is the git commit id of this patch in Linus's tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-11 19:50 ` [stable] " Greg KH
@ 2010-08-11 20:13 ` Anisse Astier
2010-08-11 20:27 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Anisse Astier @ 2010-08-11 20:13 UTC (permalink / raw)
To: Greg KH; +Cc: linux-acpi, stable, Lin Ming, Len Brown
AFAICT, it's not upstream yet.
Len and Lin didn't have the time to review the patch for now.
Regards,
Anisse
On Wed, Aug 11, 2010 at 7:50 PM, Greg KH <greg@kroah.com> wrote:
> On Fri, Aug 06, 2010 at 07:06:18PM +0200, Anisse Astier wrote:
>> On Fri, 6 Aug 2010 18:40:18 +0200, Anisse Astier <anisse@astier.eu>
>> wrote :
>>
>> > This machine has a BIOS that corrupts the DSDT, and adding
>> > acpi=copy_dsdt on cmdline fixes it. This feature and the corresponding
>> > blacklist was added in commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
>> >
>> > Cc: Len Brown <lenb@kernel.org>
>> > Cc: Lin Ming <ming.m.lin@intel.com>
>> > ---
>> > drivers/acpi/bus.c | 8 ++++++++
>> > 1 files changed, 8 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>> > index c1d23cd..fe7d7b9 100644
>> > --- a/drivers/acpi/bus.c
>> > +++ b/drivers/acpi/bus.c
>> > @@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
>> > DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
>> > },
>> > },
>> > + {
>> > + .callback = set_copy_dsdt,
>> > + .ident = "TOSHIBA Satellite C650D",
>> > + .matches = {
>> > + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
>> > + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C650D"),
>> > + },
>> > + },
>> > {}
>> > };
>> > #else
>>
>> Other users experiencing problems as reference:
>> https://bugs.launchpad.net/ubuntu/+bug/612341
>>
>> Also, I'm cc-ing stable as it might interest Greg for 35.1 (not earlier
>> versions since the feature was added by Lin Ming in .35).
>
> What is the git commit id of this patch in Linus's tree?
>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-11 20:13 ` Anisse Astier
@ 2010-08-11 20:27 ` Greg KH
2010-08-11 20:55 ` Anisse Astier
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2010-08-11 20:27 UTC (permalink / raw)
To: Anisse Astier; +Cc: linux-acpi, stable, Lin Ming, Len Brown
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Wed, Aug 11, 2010 at 08:13:29PM +0000, Anisse Astier wrote:
> AFAICT, it's not upstream yet.
> Len and Lin didn't have the time to review the patch for now.
Then there's nothing that I can do about it, right?
Please let stable@kernel.org know the git commit id of the patch when it
goes into Linus's tree.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [stable] [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-11 20:27 ` Greg KH
@ 2010-08-11 20:55 ` Anisse Astier
0 siblings, 0 replies; 7+ messages in thread
From: Anisse Astier @ 2010-08-11 20:55 UTC (permalink / raw)
To: Greg KH; +Cc: linux-acpi, stable, Lin Ming, Len Brown
On Wed, Aug 11, 2010 at 8:27 PM, Greg KH <greg@kroah.com> wrote:
>
> A: No.
> Q: Should I include quotations after my reply?
Indeed, sorry.
>
> On Wed, Aug 11, 2010 at 08:13:29PM +0000, Anisse Astier wrote:
>> AFAICT, it's not upstream yet.
>> Len and Lin didn't have the time to review the patch for now.
>
> Then there's nothing that I can do about it, right?
Nope. I jumped the gun too fast.
>
> Please let stable@kernel.org know the git commit id of the patch when it
> goes into Linus's tree.
I sure will.
Regards,
Anisse
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT
2010-08-06 16:40 [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT Anisse Astier
2010-08-06 17:06 ` Anisse Astier
@ 2010-08-12 0:29 ` Lin Ming
1 sibling, 0 replies; 7+ messages in thread
From: Lin Ming @ 2010-08-12 0:29 UTC (permalink / raw)
To: Anisse Astier; +Cc: linux-acpi, Len Brown
On Sat, 2010-08-07 at 00:40 +0800, Anisse Astier wrote:
> This machine has a BIOS that corrupts the DSDT, and adding
> acpi=copy_dsdt on cmdline fixes it. This feature and the corresponding
> blacklist was added in commit aa2110cb1a7510f9b834adfb39b05d4843a35d35
>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Lin Ming <ming.m.lin@intel.com>
> ---
> drivers/acpi/bus.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index c1d23cd..fe7d7b9 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -99,6 +99,14 @@ static struct dmi_system_id dsdt_dmi_table[] __initdata = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> },
> },
> + {
> + .callback = set_copy_dsdt,
> + .ident = "TOSHIBA Satellite C650D",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Satellite C650D"),
> + },
> + },
> {}
> };
> #else
Acked-by: Lin Ming <ming.m.lin@intel.com>
Len, could you please apply this patch?
Thanks,
Lin Ming
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-12 0:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-06 16:40 [PATCH] ACPI: Add Toshiba Satellite C650D to DMI blacklist for corrupting DSDT Anisse Astier
2010-08-06 17:06 ` Anisse Astier
2010-08-11 19:50 ` [stable] " Greg KH
2010-08-11 20:13 ` Anisse Astier
2010-08-11 20:27 ` Greg KH
2010-08-11 20:55 ` Anisse Astier
2010-08-12 0:29 ` Lin Ming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.